Uploaded image for project: 'Bug Repository'
  1. Bug Repository
  2. BUG-796

Pref > Shortcuts: Several NEW shortcuts are not working

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      Windows v11940

      The shortcuts with an may be unnecessary or are duplicated by something else. For example, we probably could get rid of Collapse and Expand and just keep toggle between the two.

      When setting NEW shortcuts these are not working:

      • All
      • Change BG color
      • Change FG color
      • Change label color
      • Clear script history
      • Collapse
      • Expand
      • Export preferences
      • Float
      • General help
      • Handle threads
      • Help for current tab
      • Hide
      • Import preferences
      • Join (Did we get rid of this option? I do not see it anywhere else.)
      • Load all sequence
      • Load sequence in view
      • Next search span
      • No tracks
      • Remove data from selected tracks
      • Repack all tracks
      • Repack selected tracks
      • Reset preferences to defaults
      • Restore to Default
      • Save selected annotations as file
      • Set direction style arrow
      • Set direction style color
      • Set range of color by score
      • Set threshold above
      • Set threshold below
      • Show tiers
      • Show (+/-) tiers
      • Show tiers
      • Show 1 track (+/-)
      • Show 2 tracks and
      • Shrink wrap sequence
      • Split (Did we get rid of this option? I do not see it anywhere else.)
      • Toggle expand and collapse
      • Toggle set threshold above and set threshold below
      • Toggle show 1 track...
      • Tracks*
      • Unset direction style arrow
      • Unset direction style color
      • View alignment sequence in sequence viewer
      • View genomic sequence in sequence viewer

        Attachments

          Activity

          kkubiak Katharine Kubiak (Inactive) created issue -
          kkubiak Katharine Kubiak (Inactive) made changes -
          Field Original Value New Value
          Description Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. We probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse*
          - Expand*
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow*
          - Set direction style color*
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)*
          - Show 2 tracks (+) and (-)*
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse*
          - Toggle set threshold above and set threshold below*
          - Toggle show 1 track...*
          - Tracks*
          - Unset direction style arrow*
          - Unset direction style color*
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. We probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow*
          - Set direction style color*
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)*
          - Show 2 tracks (+) and (-)*
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse*
          - Toggle set threshold above and set threshold below*
          - Toggle show 1 track...*
          - Tracks*
          - Unset direction style arrow*
          - Unset direction style color*
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          kkubiak Katharine Kubiak (Inactive) made changes -
          Description Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. We probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow*
          - Set direction style color*
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)*
          - Show 2 tracks (+) and (-)*
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse*
          - Toggle set threshold above and set threshold below*
          - Toggle show 1 track...*
          - Tracks*
          - Unset direction style arrow*
          - Unset direction style color*
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. We probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow(*)
          - Set direction style color(*)
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)(*)
          - Show 2 tracks (+) and (-)(*)
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse(*)
          - Toggle set threshold above and set threshold below(*)
          - Toggle show 1 track...(*)
          - Tracks*
          - Unset direction style arrow(*)
          - Unset direction style color(*)
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          kkubiak Katharine Kubiak (Inactive) made changes -
          Description Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. We probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow(*)
          - Set direction style color(*)
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)(*)
          - Show 2 tracks (+) and (-)(*)
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse(*)
          - Toggle set threshold above and set threshold below(*)
          - Toggle show 1 track...(*)
          - Tracks*
          - Unset direction style arrow(*)
          - Unset direction style color(*)
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. For example, we probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow(*)
          - Set direction style color(*)
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)(*)
          - Show 2 tracks (+) and (-)(*)
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse(*)
          - Toggle set threshold above and set threshold below(*)
          - Toggle show 1 track...(*)
          - Tracks*
          - Unset direction style arrow(*)
          - Unset direction style color(*)
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          kkubiak Katharine Kubiak (Inactive) made changes -
          Assignee Hiral Vora [ hiralv ]
          kkubiak Katharine Kubiak (Inactive) made changes -
          Description Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. For example, we probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow(*)
          - Set direction style color(*)
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)(*)
          - Show 2 tracks (+) and (-)(*)
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse(*)
          - Toggle set threshold above and set threshold below(*)
          - Toggle show 1 track...(*)
          - Tracks*
          - Unset direction style arrow(*)
          - Unset direction style color(*)
          - View alignment sequence in sequence viewer (Should we remove the '..." here?)
          - View genomic sequence in sequence viewer (Should we remove the '..." here?)
          Windows v11940

          The shortcuts with an (*) may be unnecessary or are duplicated by something else. For example, we probably could get rid of Collapse and Expand and just keep toggle between the two.

          When setting NEW shortcuts these are not working:
          - All
          - Change BG color
          - Change FG color
          - Change label color
          - Clear script history
          - Collapse(*)
          - Expand(*)
          - Export preferences
          - Float
          - General help
          - Handle threads
          - Help for current tab
          - Hide
          - Import preferences
          - Join (Did we get rid of this option? I do not see it anywhere else.)
          - Load all sequence
          - Load sequence in view
          - Next search span
          - No tracks
          - Remove data from selected tracks
          - Repack all tracks
          - Repack selected tracks
          - Reset preferences to defaults
          - Restore to Default
          - Save selected annotations as file
          - Set direction style arrow(*)
          - Set direction style color(*)
          - Set range of color by score
          - Set threshold above
          - Set threshold below
          - Show (+) tiers
          - Show (+/-) tiers
          - Show (-) tiers
          - Show 1 track (+/-)(*)
          - Show 2 tracks (+) and (-)(*)
          - Shrink wrap sequence
          - Split (Did we get rid of this option? I do not see it anywhere else.)
          - Toggle expand and collapse(*)
          - Toggle set threshold above and set threshold below(*)
          - Toggle show 1 track...(*)
          - Tracks*
          - Unset direction style arrow(*)
          - Unset direction style color(*)
          - View alignment sequence in sequence viewer
          - View genomic sequence in sequence viewer
          lfrohman Lance Frohman (Inactive) made changes -
          Assignee Hiral Vora [ hiralv ] Eric Blossom [ elb ]
          Hide
          elb Eric Blossom (Inactive) added a comment -

          There seem to be several things going on here.

          The troublesome (non working) actions are those that do not appear in the main menu system. The way Swing works these actions are not available for accelerator keys (the technical term for the shortcuts). Another problem is that the accelerators are not even set for these actions when IGB starts up.

          There are also several bugs in the editor for accelerator keys in the "shortcuts" panel. There are tool bar buttons to toggle between two client actions. e.g. Expand and Collapse. The client actions still appear in the menu system and, hence, should be able to have accelerators. We could do one of the following:

          1. Use the same accelerators for the tool bar button.
          2. Use a third accelerator for the tool bar button.
          3. Not use any accelerator for the tool bar button which is equivalent to the first option.

          IGB uses a GenericActionHolder instead of Swing's InputMap and ActionMap objects. Not sure if this helps or hurts.

          Show
          elb Eric Blossom (Inactive) added a comment - There seem to be several things going on here. The troublesome (non working) actions are those that do not appear in the main menu system. The way Swing works these actions are not available for accelerator keys (the technical term for the shortcuts). Another problem is that the accelerators are not even set for these actions when IGB starts up. There are also several bugs in the editor for accelerator keys in the "shortcuts" panel. There are tool bar buttons to toggle between two client actions. e.g. Expand and Collapse. The client actions still appear in the menu system and, hence, should be able to have accelerators. We could do one of the following: Use the same accelerators for the tool bar button. Use a third accelerator for the tool bar button. Not use any accelerator for the tool bar button which is equivalent to the first option. IGB uses a GenericActionHolder instead of Swing's InputMap and ActionMap objects. Not sure if this helps or hurts.
          Hide
          elb Eric Blossom (Inactive) added a comment -

          Fixed (revision 12074) the issue of some accelerators (shortcuts) not being set on the next start up. I also fixed it so that they are set right away, so you don't have to restart IGB. (Note that you still have to restart IGB to see tool bar changes.)

          You can set accelerators for toggles and their clients separately. e.g. for Collapse, Expand, and Toggle Collapse and Expand with three different accelerators if you like.

          The popup menu must be visible for the accelerators for those actions to work. Similarly, the Preferences dialog must be up for it's actions to be available through accelerator key strokes.

          So everything is working according to the Swing True Way. However, it is still a bit subtle to the user why the shortcuts to the popup menu items don't "work" when the popup is not visible.

          Show
          elb Eric Blossom (Inactive) added a comment - Fixed (revision 12074) the issue of some accelerators (shortcuts) not being set on the next start up. I also fixed it so that they are set right away, so you don't have to restart IGB. (Note that you still have to restart IGB to see tool bar changes.) You can set accelerators for toggles and their clients separately. e.g. for Collapse, Expand, and Toggle Collapse and Expand with three different accelerators if you like. The popup menu must be visible for the accelerators for those actions to work. Similarly, the Preferences dialog must be up for it's actions to be available through accelerator key strokes. So everything is working according to the Swing True Way. However, it is still a bit subtle to the user why the shortcuts to the popup menu items don't "work" when the popup is not visible.
          Hide
          elb Eric Blossom (Inactive) added a comment -

          It's all good now. Shortcuts work even for pop up menu items and toolbar buttons.
          svn revision 12116.

          Show
          elb Eric Blossom (Inactive) added a comment - It's all good now. Shortcuts work even for pop up menu items and toolbar buttons. svn revision 12116.
          elb Eric Blossom (Inactive) made changes -
          Assignee Eric Blossom [ elb ] Alyssa Gulledge [ alyssa ]
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment - - edited

          The short cuts shows "None", the list about shows "No tracks"...

          None is in reference to removing the transformation on an annotation track? What does No tracks come from? Is it a mistake, or has it been removed? Also using this shortcut seems to do nothing

          Set threshold above/below are not in shortcuts list. Have they been removed?

          "Float" does not toggle to an UNfloated state! This should self toggle.

          Set arrow and set direction color have separate 'unsets' - can't we just have one option that toggles? *BUG* Current the unset arrow clicks off the arrow box, but does NOT remove the arrows from the glyphs. Same for color.

          Activating 'Show 2 track' via shortcut does NOT properly check the '2 track' box in Data management. Also - why is there a short cut to show 1 track, a short cut to show 2 tracks AND a short cut to toggle between??? Just keep the toggle short cut!!

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - - edited The short cuts shows "None", the list about shows "No tracks"... None is in reference to removing the transformation on an annotation track? What does No tracks come from? Is it a mistake, or has it been removed? Also using this shortcut seems to do nothing Set threshold above/below are not in shortcuts list. Have they been removed? "Float" does not toggle to an UNfloated state! This should self toggle. Set arrow and set direction color have separate 'unsets' - can't we just have one option that toggles? * BUG * Current the unset arrow clicks off the arrow box, but does NOT remove the arrows from the glyphs. Same for color. Activating 'Show 2 track' via shortcut does NOT properly check the '2 track' box in Data management. Also - why is there a short cut to show 1 track, a short cut to show 2 tracks AND a short cut to toggle between??? Just keep the toggle short cut!!
          alyssa Alyssa Gulledge (Inactive) made changes -
          Assignee Alyssa Gulledge [ alyssa ] Eric Blossom [ elb ]
          Hide
          elb Eric Blossom (Inactive) added a comment -

          "All" and "None" refer to track selection. If you pull down "Edit" and click on "Select Tracks" you will see those as items in the pull right list. We can change them to "Select All Tracks" and "Deselect All Tracks" respectively.

          Yes, set threshold above/below have been removed.

          I'll work on a toggle for "Float" and its inverse.

          I'll look into new toggles for the directional arrows and colors. This a new (and a good) request and deserving of a new Jira issue.

          I'll look into the the coordination of "show 2 track" between the shortcut action and the data management table.

          There are a few instances of toggles that switch state. (Unfortunately, we overload this term a bit and also use it to refer to boolean menu items (checkbox menu items)). The confusion you are seeing with the 1 and 2 track actions is that there is one to show 1 track and another to show 2. The toggle in the tool bar uses those two as clients. It is reasonable to have a shortcut for all three. One might also prefer to have any of those three in the tool bar. Note that toggles use their clients' icons. Toggles start with the verb "Toggle".

          Show
          elb Eric Blossom (Inactive) added a comment - "All" and "None" refer to track selection. If you pull down "Edit" and click on "Select Tracks" you will see those as items in the pull right list. We can change them to "Select All Tracks" and "Deselect All Tracks" respectively. Yes, set threshold above/below have been removed. I'll work on a toggle for "Float" and its inverse. I'll look into new toggles for the directional arrows and colors. This a new (and a good) request and deserving of a new Jira issue. I'll look into the the coordination of "show 2 track" between the shortcut action and the data management table. There are a few instances of toggles that switch state. (Unfortunately, we overload this term a bit and also use it to refer to boolean menu items (checkbox menu items)). The confusion you are seeing with the 1 and 2 track actions is that there is one to show 1 track and another to show 2. The toggle in the tool bar uses those two as clients. It is reasonable to have a shortcut for all three. One might also prefer to have any of those three in the tool bar. Note that toggles use their clients' icons. Toggles start with the verb "Toggle".
          Hide
          elb Eric Blossom (Inactive) added a comment -

          I would like this to be resolved.
          I have opened new Jira issues (385 and 386)for the new toggles.
          I have also opened a new issue for the bug in coordination with the data management table (387)

          Show
          elb Eric Blossom (Inactive) added a comment - I would like this to be resolved. I have opened new Jira issues (385 and 386)for the new toggles. I have also opened a new issue for the bug in coordination with the data management table (387)
          elb Eric Blossom (Inactive) made changes -
          Assignee Eric Blossom [ elb ] Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Alyssa Gulledge [ alyssa ]
          Resolution Fixed [ 1 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Project IGB 7.0 [ 10140 ] Bug Repository [ 10030 ]
          Key IGBC-293 BUG-796
          Reporter Katharine Kubiak [ kkubiak ] Alyssa Gulledge [ alyssa ]

            People

            • Assignee:
              Unassigned
              Reporter:
              alyssa Alyssa Gulledge (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: