Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1182

Tools - Run Script -Convert file chooser to the operating system's Native File Chooser

        Details

        • Story Points:
          1
        • Sprint:
          Fall 2017

          Description

          Related to IGBF-1140.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              akadam3 Ashwini Kadam (Inactive) created issue -
              akadam3 Ashwini Kadam (Inactive) made changes -
              Field Original Value New Value
              Rank Ranked higher
              akadam3 Ashwini Kadam (Inactive) made changes -
              Rank Ranked higher
              akadam3 Ashwini Kadam (Inactive) made changes -
              Rank Ranked lower
              akadam3 Ashwini Kadam (Inactive) made changes -
              Rank Ranked lower
              akadam3 Ashwini Kadam (Inactive) made changes -
              Rank Ranked lower
              akadam3 Ashwini Kadam (Inactive) made changes -
              Rank Ranked lower
              akadam3 Ashwini Kadam (Inactive) made changes -
              Fix Version/s 9.0.1 Minor Release [ 10500 ]
              Sprint Early Fall 2017 [ 47 ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment - - edited

              Scripting:

              https://wiki.transvar.org/display/igbman/Scripting+and+the+IGB+command+language
              https://wiki.transvar.org/pages/viewpageattachments.action?pageId=17269487
              https://gist.github.com/Hillrunner2008/25976458488b65a3a25b

              Show
              ann.loraine Ann Loraine added a comment - - edited Scripting: https://wiki.transvar.org/display/igbman/Scripting+and+the+IGB+command+language https://wiki.transvar.org/pages/viewpageattachments.action?pageId=17269487 https://gist.github.com/Hillrunner2008/25976458488b65a3a25b
              Hide
              Permalink
              akadam3 Ashwini Kadam (Inactive) added a comment - - edited

              Fixed the issue. Need testing with Linux and Mac OS.
              https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/f444a6118b9b6b92f05e7e4c0d48e1eb3d7a3911?at=IGBF-1182

              Removed '.js' from file chooser UI as 'Run Scrpt' does not support javascript files.

              Show
              akadam3 Ashwini Kadam (Inactive) added a comment - - edited Fixed the issue. Need testing with Linux and Mac OS. https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/f444a6118b9b6b92f05e7e4c0d48e1eb3d7a3911?at=IGBF-1182 Removed '.js' from file chooser UI as 'Run Scrpt' does not support javascript files.
              akadam3 Ashwini Kadam (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              Hide
              Permalink
              akadam3 Ashwini Kadam (Inactive) added a comment -

              First Level Review :
              Bug is fixed on macOS. 'Run Script' is working as expected. Only .igb files are selectable by user. No support for javascript file as specified in fix.
              I did not do code-review as I have written it and expect that such review should be done by other developer.

              Show
              akadam3 Ashwini Kadam (Inactive) added a comment - First Level Review : Bug is fixed on macOS. 'Run Script' is working as expected. Only .igb files are selectable by user. No support for javascript file as specified in fix. I did not do code-review as I have written it and expect that such review should be done by other developer.
              akadam3 Ashwini Kadam (Inactive) made changes -
              Assignee Ashwini Kadam [ akadam3 ] Ann Loraine [ aloraine ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Assignee Ann Loraine [ aloraine ]
              spatil26 Sanket Patil (Inactive) made changes -
              Assignee Sanket Patil [ spatil26 ]
              spatil26 Sanket Patil (Inactive) made changes -
              Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
              spatil26 Sanket Patil (Inactive) made changes -
              Attachment IGBF1182_not workign on Linux.jpg [ 14041 ]
              Hide
              Permalink
              spatil26 Sanket Patil (Inactive) added a comment -

              Working on Mac and windows. However not working for Linux. Adding back to do List. Please see attached imaged.
              Code review done for fix which is working on windows and mac. Need to do it again once the fix for linux is added.

              Show
              spatil26 Sanket Patil (Inactive) added a comment - Working on Mac and windows. However not working for Linux. Adding back to do List. Please see attached imaged. Code review done for fix which is working on windows and mac. Need to do it again once the fix for linux is added.
              spatil26 Sanket Patil (Inactive) made changes -
              Status Reviewing [ 10301 ] Open [ 1 ]
              spatil26 Sanket Patil (Inactive) made changes -
              Assignee Sanket Patil [ spatil26 ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Assignee Ashwini Kadam [ akadam3 ]
              Hide
              Permalink
              akadam3 Ashwini Kadam (Inactive) added a comment -

              Dr. Loraine suggested that if you are building code from command line/terminal, change may not be reflected with latest jar.

              Sanket, could you please test the issue again by building the jar from netbeans instead of command line? Because I noticed that image you attached with issue for reference is not showing latest code change. (File chooser window should have 'Choose File' as title instead of 'Open). It is possible that you are not working with modified code.
              Please let me know the outcomes of new build on Linux.

              Moving to 'Needs 1st level review'.

              Show
              akadam3 Ashwini Kadam (Inactive) added a comment - Dr. Loraine suggested that if you are building code from command line/terminal, change may not be reflected with latest jar. Sanket, could you please test the issue again by building the jar from netbeans instead of command line? Because I noticed that image you attached with issue for reference is not showing latest code change. (File chooser window should have 'Choose File' as title instead of 'Open). It is possible that you are not working with modified code. Please let me know the outcomes of new build on Linux. Moving to 'Needs 1st level review'.
              akadam3 Ashwini Kadam (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Assignee Ashwini Kadam [ akadam3 ] Sanket Patil [ spatil26 ]
              Hide
              Permalink
              spatil26 Sanket Patil (Inactive) added a comment -

              Good catch Ashwini. I will test it again on Linux.

              Show
              spatil26 Sanket Patil (Inactive) added a comment - Good catch Ashwini. I will test it again on Linux.
              spatil26 Sanket Patil (Inactive) made changes -
              Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
              spatil26 Sanket Patil (Inactive) made changes -
              Attachment IGBF1182_Windows.jpg [ 14042 ]
              Attachment IGBF1182_workign on linux.PNG [ 14043 ]
              Hide
              Permalink
              spatil26 Sanket Patil (Inactive) added a comment - - edited

              As pointed out by Ashwini, i tested a jar build using netbeans. Its working fine on linux as well. Attached screen shot.
              As mentioned in earlier comment code review is done.
              Moving this issue to Ready for pull request.

              Show
              spatil26 Sanket Patil (Inactive) added a comment - - edited As pointed out by Ashwini, i tested a jar build using netbeans. Its working fine on linux as well. Attached screen shot. As mentioned in earlier comment code review is done. Moving this issue to Ready for pull request.
              spatil26 Sanket Patil (Inactive) made changes -
              Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
              spatil26 Sanket Patil (Inactive) made changes -
              Assignee Sanket Patil [ spatil26 ] Ashwini Kadam [ akadam3 ]
              akadam3 Ashwini Kadam (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              Hide
              Permalink
              akadam3 Ashwini Kadam (Inactive) added a comment -

              Submitted Pull Request

              Show
              akadam3 Ashwini Kadam (Inactive) added a comment - Submitted Pull Request
              akadam3 Ashwini Kadam (Inactive) made changes -
              Assignee Ashwini Kadam [ akadam3 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
              mason Mason Meyer (Inactive) made changes -
              Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
              mason Mason Meyer (Inactive) made changes -
              Rank Ranked higher
              Hide
              Permalink
              mason Mason Meyer (Inactive) added a comment -

              After testing this story I can confirm that the Tools menu's "Run Script" file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Scripts are still operating as expected and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.

              Show
              mason Mason Meyer (Inactive) added a comment - After testing this story I can confirm that the Tools menu's "Run Script" file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Scripts are still operating as expected and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.
              mason Mason Meyer (Inactive) made changes -
              Resolution Done [ 10000 ]
              Status Testing In Progress [ 10003 ] Closed [ 6 ]
              ann.loraine Ann Loraine made changes -
              Workflow Loraine Lab Workflow [ 17846 ] Fall 2019 Workflow Update [ 19814 ]
              ann.loraine Ann Loraine made changes -
              Workflow Fall 2019 Workflow Update [ 19814 ] Revised Fall 2019 Workflow Update [ 21933 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  akadam3 Ashwini Kadam (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: