Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.2 Minor Release
-
Labels:
-
Story Points:0.5
-
Sprint:B - Summer 2018, Summer 2018 Part 2
Description
The OSGi container caches bundles in version-specific folders in a user's hidden .igb directory. This directory resides in the user's HOME directory under Linux & MacOS and somewhere else under Windows.
When a developer runs "mvn clean", the clean process should delete the bundle cache for the version of IGB being built.
Currently, developer must do this manually.
Note: This issue requires understanding maven configuration. It would be a good issue for a beginner to learn maven and how to run/test IGB.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
| Story Points | 2 | 1 |
| Assignee | Kiran Korey [ kkorey ] |
| Sprint | B - Summer 2018 [ 48 ] |
| Rank | Ranked lower |
| Story Points | 1 | 0.5 |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Configured to delete bundles directory from project directory and users local cache directory.
(Tested in Windows and Linux)
Need a review for the branch
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1196-Cache-Clean
Thanks
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Please make this change:
Don't delete the entire bundles directory. Install, delete the sub-directory for this version.
Thanks.
Above mentioned change has been made and is available in the following commit.
Note: This issue has not been tested in mac.
Please test on Mac and Linux & then do pull request if both are fine.
Works fine on mac as well.
| Status | Needs 1st Level Review [ 10005 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
This feature deletes IGB OSGi bundle cache during maven clean lifecycle and goal.
Test in (1) IDE (Netbeans) and (2) command line maven.
Steps to test:
- run IGB 9.0.1
- observe IGB OSGi container creates v9.0.1-bundle-cache directory in ("dot igb") .igb/bundles directory.
Note: To determine location of "dot igb" directory on a system, choose Help > About in IGB. Look for a sentence like "Application data and OSGi bundle cache are stored in ..."
- execute "mvn clean" command in (1) IDE (Netbeans) and (2) command line maven.
- observe that .igb/bundles/v9.0.1-bundle-cache is deleted but .igb/bundles and any other version specific bundle caches
(Note upon assigning to Sneha for testing.)
Please test today or next week (Tuesday).
Also, review: https://www.tutorialspoint.com/maven/maven_build_life_cycle.htm
| Assignee | Kiran Korey [ kkorey ] | Sneha Ramesh Watharkar [ jdaly ] |
Worked in Net beans and command prompt too.
mvn clean worked as expected.
I was wondering if we build it again then should we not see cache bundles in Roaming/bundles folder?
I cannot see it after i clean and build again!.
correct me if i am wrong. Kiran Korey
The bundles get cached in Roaming/bundles only when you start IGB.
Build does not cache it, rather creates bundles only in the project directory.
| Assignee | Sneha Ramesh Watharkar [ jdaly ] | Kiran Korey [ kkorey ] |
Tested and works fine!
Assigning back to Kiran Korey
| Assignee | Kiran Korey [ kkorey ] |
| Fix Version/s | 9.0.2 [ 10600 ] |
| Resolution | Done [ 10000 ] | |
| Status | Needs Testing [ 10002 ] | Closed [ 6 ] |
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | Needs Testing [ 10002 ] |
| Assignee | Sneha Ramesh Watharkar [ jdaly ] |
When describing what you did regarding testing, indicate that you tested on mac, windows, unix or some subset of these.
None of the comments above mention if this has been tested on Linux.
| Rank | Ranked higher |
| Sprint | B - Summer 2018 [ 48 ] | B - Summer 2018, Summer 2018 Part 2 [ 48, 49 ] |
| Rank | Ranked higher |
| Resolution | Done [ 10000 ] | |
| Status | Needs Testing [ 10002 ] | Closed [ 6 ] |
| Workflow | Loraine Lab Workflow [ 17875 ] | Fall 2019 Workflow Update [ 19827 ] |
| Workflow | Fall 2019 Workflow Update [ 19827 ] | Revised Fall 2019 Workflow Update [ 21946 ] |
Analysis:
mvn install: Does not copy the bundles into users HOME directory, it compiles the classes and puts it in the target folder in project directory.
mvn clean: Deletes the target folder and files inside it.