Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.1 Minor Release
-
Labels:None
-
Story Points:1
-
Sprint:B - Summer 2018
Description
Annotation track items typically have score attributes, which are numeric. IGB has a "filter by" feature that lets users filter out (hide) items based on various attributes, including score.
Currently, the "filter by" feature does not allow users to enter decimal values in the "filter by" interface.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Ann Loraine [ aloraine ] |
| Summary | allow entering decimals in color by score | allow entering decimals in filter by score |
| Description |
Annotation track items typically have score attributes, which are numeric. IGB has a "filter by" feature that lets users filter out (hide) items based on various attributes, including score.
Currently, the "filter by" feature does not allow users to enter decimal values in the "filter by" interface. |
| Rank | Ranked higher |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Deepti Joshi [ djoshi4 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Assignee | Deepti Joshi [ djoshi4 ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Sneha Ramesh Watharkar [ jdaly ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Fixed the bug.
Now the input box of score takes decimal values and filtering works correctly during the time of dev testing.
Also verified by applying different filters.
Moving to "Needs 1st Level Review" phase.
Branch: https://bitbucket.org/swathark/integrated-genome-browser/branch/IGBF-1204-DecimalScore
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Sneha Ramesh Watharkar [ jdaly ] | Ivory Blakley [ ieclabau ] |
Reviewing the issue...
The changes to the code are appropriate and sufficiently limited in scope.
The code base builds. And the feature now functions as expected. I tested it with the test case (which has decimal scores) and with another file generated by tophat and one by LL junctions. All looks good.
The commit history includes a merge from main master, we'll remove that commit and then I think this branch will be ready for a pull request into main master.
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
Make corrections to git history (remove commits for "merged lorainelab/master" ) then make the pull request.
| Assignee | Ivory Blakley [ ieclabau ] | Sneha Ramesh Watharkar [ jdaly ] |
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Sneha Ramesh Watharkar [ jdaly ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Assignee | Mason Meyer [ mason ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
| Fix Version/s | 9.0.1 Minor Release [ 10500 ] |
After testing this story, I can confirm that this issue is functioning as expected. Decimals places are now allowed when using the Filter By feature and the feature seems to be functioning properly. Since this story is resolved and there seem to be no side effects related to this change, it will now be closed.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Loraine Lab Workflow [ 17883 ] | Fall 2019 Workflow Update [ 19832 ] |
| Workflow | Fall 2019 Workflow Update [ 19832 ] | Revised Fall 2019 Workflow Update [ 21951 ] |
Test case file:
IGB Quickload > ChIP-Seq > ARR10 PRJNA263839 > peaks > line a1 BA-treated
Load a region of the file.
With the track selected, go to the annotations tab, select Label Field: score.
Zoom to in enough to see the score above the annotated regions.
See that these scores have decimal values.
In this region [ Chr1:9,329,031-9,329,932 ] notice that there are two annotations with scores between 1 and 2.
Right click the track name > Filter... > Add > select Score > enter a value of 1.8.
Currently it is not possible to enter 1.8 as a value here.
Change the input to allow decimal values.
If 1.8 is supplied, and the filter is applied, then one of these two annotations should be removed from view.
Verify that the correct one is removed using different comparators (>, <, =>).