Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1305

Upgrade Jquery in Bioviz site to remove console errors and warrnings

    Details

    • Story Points:
      0.5
    • Sprint:
      B - Summer 2018, Summer 2018 Part 2

      Description

      • detect & fix any JS code errors
      • monitor error logs

        Attachments

          Activity

          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          Fixed console log errors which were appearing due to migration of Jquery from 1.1 to 3.3.1 version.

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - Fixed console log errors which were appearing due to migration of Jquery from 1.1 to 3.3.1 version.
          Hide
          ann.loraine Ann Loraine added a comment -

          Please add link to branch.

          Show
          ann.loraine Ann Loraine added a comment - Please add link to branch.
          Hide
          ann.loraine Ann Loraine added a comment -

          Questions:

          • This code: script src="js/libs/modernizr-2.5.3-respond-1.1.0.min.js" is now script src="//code.jquery.com/jquery-1.11.2.min.js" Can we now remove this and other .js files from the repository since we are now getting them from jquery (and other) CDNs ?
          • Why does src="//code.jquery.com/jquery-1.11.2.min.js work? There is no "http:" in front of //code.jquery.com/jquery-1.11.2.min.js
          Show
          ann.loraine Ann Loraine added a comment - Questions: This code: script src="js/libs/modernizr-2.5.3-respond-1.1.0.min.js" is now script src="//code.jquery.com/jquery-1.11.2.min.js" Can we now remove this and other .js files from the repository since we are now getting them from jquery (and other) CDNs ? Why does src="//code.jquery.com/jquery-1.11.2.min.js work? There is no "http:" in front of //code.jquery.com/jquery-1.11.2.min.js
          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          Ans1) I just moved src="js/libs/modernizr-2.5.3-respond-1.1.0.min.js" in scripts section to load when other scripts are being loaded. Its not a replacement to src="//code.jquery.com/jquery-1.11.2.min.js". modernizr plugin is not a part of jquery. So we cannot remove that plugin.

          Ans2) If there is no protocol specfied before the src, then browser uses the same protocol which is used for loading that html file (http or https).
          So, its okay to not specify protocol and the code still works in any case.

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - Ans1) I just moved src="js/libs/modernizr-2.5.3-respond-1.1.0.min.js" in scripts section to load when other scripts are being loaded. Its not a replacement to src="//code.jquery.com/jquery-1.11.2.min.js". modernizr plugin is not a part of jquery. So we cannot remove that plugin. Ans2) If there is no protocol specfied before the src, then browser uses the same protocol which is used for loading that html file (http or https). So, its okay to not specify protocol and the code still works in any case.
          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          Task related to this task are locally made and they are not present in the branch yet.
          I will make the changes to the branch once I have IGBF-1288 merged to master (because there might be code change in same files and it might lead to conflicts).
          So to save time, I have worked on the files locally.
          Once I have changes on the branch, I shall provide a link to this issue.

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - Task related to this task are locally made and they are not present in the branch yet. I will make the changes to the branch once I have IGBF-1288 merged to master (because there might be code change in same files and it might lead to conflicts). So to save time, I have worked on the files locally. Once I have changes on the branch, I shall provide a link to this issue.
          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          Completed changing the actual files for upgrading Jquery.
          Branch : https://bitbucket.org/swathark/bioviz/branch/IGBF-1305

          It also minor js changes related to upgrading jquery.

          Assigning it to Prof. [~aloraine] for review.

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - Completed changing the actual files for upgrading Jquery. Branch : https://bitbucket.org/swathark/bioviz/branch/IGBF-1305 It also minor js changes related to upgrading jquery. Assigning it to Prof. [~aloraine] for review.
          Hide
          ann.loraine Ann Loraine added a comment -

          Sorry, you need to rebase again due to changes on master.
          When that is done, submit pull request.

          Show
          ann.loraine Ann Loraine added a comment - Sorry, you need to rebase again due to changes on master. When that is done, submit pull request.

            People

            • Assignee:
              sneha Sneha Ramesh Watharkar (Inactive)
              Reporter:
              sneha Sneha Ramesh Watharkar (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: