Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1342

Diff operation on 2 tracks is giving " no point" in ycord value in selection info in Graph Track Operations

    Details

    • Story Points:
      2
    • Sprint:
      Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22, Winter 3 Jan 25 - Feb 5

      Description

      Diff operation on 2 tracks is giving " no point" in ycord value in selection info. Graph is not shown too.

        Attachments

          Issue Links

            Activity

            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            It looks like the "no point" is only for negative values.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - It looks like the "no point" is only for negative values.
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            We discovered this in 9.0.1 and reproduced it in 9.0.0.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - We discovered this in 9.0.1 and reproduced it in 9.0.0.
            Hide
            nfreese Nowlan Freese added a comment -

            Check IGBF-1344 for test graph files.

            Show
            nfreese Nowlan Freese added a comment - Check IGBF-1344 for test graph files.
            Hide
            inaylor Irvin Naylor (Inactive) added a comment -

            Log 11/19 -

            'No point' is still appearing in 9.1.6.
            Combed through the AbstractFloatTransformer and GraphGlyph.java to try and isolate instances where 'no point' should and should not come up in normal operations

            Steps to replicate:

            1) Open human genome (H_sapiens_Dec_2013)
            2) Navigate to: chr1:0-550
            3) Load the grapgWithNegative.bedgraph file (found in IGBF-1344)
            4) Click the graphWithNegative.bedgraph track label to select it.
            5) Click in the center of the graph where the values are negative.
            6) Navigate to the selection info to display coordinates (noting y-coordinate as 'no point').

            Show
            inaylor Irvin Naylor (Inactive) added a comment - Log 11/19 - 'No point' is still appearing in 9.1.6. Combed through the AbstractFloatTransformer and GraphGlyph.java to try and isolate instances where 'no point' should and should not come up in normal operations Steps to replicate: 1) Open human genome (H_sapiens_Dec_2013) 2) Navigate to: chr1:0-550 3) Load the grapgWithNegative.bedgraph file (found in IGBF-1344 ) 4) Click the graphWithNegative.bedgraph track label to select it. 5) Click in the center of the graph where the values are negative. 6) Navigate to the selection info to display coordinates (noting y-coordinate as 'no point').
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Potentially helpful suggestions:

            • Make a short screencast video demonstrating the above steps
            • Describe what the proper behavior should be in the comments text and/or in the video

            Once you determine what the proper behavior should be:

            • Search the code base for text "no point" to find code implementing the "no point" behavior
            • Use debugger figure out the logic flow and identify places to implement a change
            Show
            ann.loraine Ann Loraine added a comment - - edited Potentially helpful suggestions: Make a short screencast video demonstrating the above steps Describe what the proper behavior should be in the comments text and/or in the video Once you determine what the proper behavior should be: Search the code base for text "no point" to find code implementing the "no point" behavior Use debugger figure out the logic flow and identify places to implement a change
            Show
            inaylor Irvin Naylor (Inactive) added a comment - Fork Link: https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1342/
            Hide
            nfreese Nowlan Freese added a comment -

            Tested jar on Mac.

            The y coord value is now showing correctly for negative graph values.

            However, I noticed that values that should read no point, where there is no y coord value (no graph data), now show as -1.0. The code change Irvin made makes sense to me, so I think there is some further digging required to identify why a value with -1.0 is being recorded where there is no graph data.

            [~aloraine] - I'm unsure of whether we should move forward with a pull request or investigate further.

            Show
            nfreese Nowlan Freese added a comment - Tested jar on Mac. The y coord value is now showing correctly for negative graph values. However, I noticed that values that should read no point, where there is no y coord value (no graph data), now show as -1.0. The code change Irvin made makes sense to me, so I think there is some further digging required to identify why a value with -1.0 is being recorded where there is no graph data. [~aloraine] - I'm unsure of whether we should move forward with a pull request or investigate further.
            Hide
            inaylor Irvin Naylor (Inactive) added a comment -

            I've done a bit of digging into the code and found that the only time -1.0 comes up is in the Graph Strand Minus variable as an assigned constant.
            I have updated some of my solution code as well to make it a bit cleaner and have a specific time when "No Point" should show up (AKA when Y is neither greater than, less than, or equal to 0).

            Fork link: https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1342/

            Show
            inaylor Irvin Naylor (Inactive) added a comment - I've done a bit of digging into the code and found that the only time -1.0 comes up is in the Graph Strand Minus variable as an assigned constant. I have updated some of my solution code as well to make it a bit cleaner and have a specific time when "No Point" should show up (AKA when Y is neither greater than, less than, or equal to 0). Fork link: https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1342/
            Hide
            ann.loraine Ann Loraine added a comment -

            Nowlan Freese - Could you please review?

            Show
            ann.loraine Ann Loraine added a comment - Nowlan Freese - Could you please review?
            Hide
            nfreese Nowlan Freese added a comment - - edited

            I requested a change to the code from Irvin.

            Show
            nfreese Nowlan Freese added a comment - - edited I requested a change to the code from Irvin.
            Show
            inaylor Irvin Naylor (Inactive) added a comment - Nowlan Freese - here are the changes. Fork Link: https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1342/
            Hide
            nfreese Nowlan Freese added a comment -

            Tested Irvin's dmg for 1342 on Mac using the attached bedgraph files.

            Selection Info now shows "no point" where there is no data and negative values are showing correctly.
            Single-Graph operations are working correctly and saving the bedgraph from IGB works correctly.

            Recommend pull request.

            Show
            nfreese Nowlan Freese added a comment - Tested Irvin's dmg for 1342 on Mac using the attached bedgraph files. Selection Info now shows "no point" where there is no data and negative values are showing correctly. Single-Graph operations are working correctly and saving the bedgraph from IGB works correctly. Recommend pull request.
            Show
            inaylor Irvin Naylor (Inactive) added a comment - Nowlan Freese - Here's the pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/860/igbf-1342-diff-operations-on-2-tracks
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged and master branch installers are built. Please test.

            Show
            ann.loraine Ann Loraine added a comment - Merged and master branch installers are built. Please test.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested master dmg on Mac 10.14.6 (18G7016)

            Everything working correctly, nothing odd in the logs. Closing issue.

            Show
            nfreese Nowlan Freese added a comment - Tested master dmg on Mac 10.14.6 (18G7016) Everything working correctly, nothing odd in the logs. Closing issue.

              People

              • Assignee:
                inaylor Irvin Naylor (Inactive)
                Reporter:
                sneha Sneha Ramesh Watharkar (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: