Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1363

Fix foreground and add new style attributes to annots.xml for BAR Quickload

    Details

    • Story Points:
      0.25
    • Sprint:
      Summer 2018 Part 2, Summer 2018 Part 3

      Description

      Modify Arabidopsis annots.xml for BAR Quickload site.

      See:
      http://lorainelab-quickload.scidas.org/bar/A_thaliana_Jun_2009/annots.xml

      • Fix "foreground" attribute. Currently, foreground does not match the hexcolour attribute, but it should. For example, the first record should be a shade of green in IGB (0x64cc65) but instead it is a shade of blue (00FFFF)

      In Jira record, add a comment indicating the source code repository for your code.

      To test:

        Attachments

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment -

            Note: I manually edited the first record in the file for demo purposes. For testing, use second record.

            Show
            ann.loraine Ann Loraine added a comment - Note : I manually edited the first record in the file for demo purposes. For testing, use second record.
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            The code for this is on this branch of the IGBquickload repository (branch name is parse_XML_AWS_bams)
            https://bitbucket.org/lorainelab/igbquickload/branch/parse_XML_AWS_bams

            The color was being converted from 8-digit hex to 6-digit hex. This was something of a headache because most color functions I use don't account for an 8-digit hex option, and the documentation about the 8-digit format is unclear about when it aRGB or RGBA. Having documentation from BAR about how they formatted their color string might be helpful in the future. In the mean time, it looks like all of the colors start with 0x, so (assuming that's the transparency field) it doesn't actually change the color.
            We have made changes to how IGB limits the colors it will accept (it will accept a 6-digit string with or without a # in front). I think those changes may have changed how IGB handles the 8-digit string. I was quite sure IGB would only take a 6-digit hex, but it seems to be working now with the unchanged 8-digit hex as well. And obviously the best option would be to pass the color directly as it comes as long as that doesn't break anything. We should test this further.

            I added the new attributes but I made a point to keep those in a separate commit so we might cherry pick around that.
            For the max_depth and show2tracks, I think those values are already the defaults, so there is very little value in hard-coding them.
            I don't think direction_type=arrow is a default---and for good reason, its ugly. I think that setting is ok for gene models, but RNA-Seq reads are so short that they look weird with arrows, and all the introns look like a stack of barbed wire. ...my opinion.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - The code for this is on this branch of the IGBquickload repository (branch name is parse_XML_AWS_bams) https://bitbucket.org/lorainelab/igbquickload/branch/parse_XML_AWS_bams The color was being converted from 8-digit hex to 6-digit hex. This was something of a headache because most color functions I use don't account for an 8-digit hex option, and the documentation about the 8-digit format is unclear about when it aRGB or RGBA. Having documentation from BAR about how they formatted their color string might be helpful in the future. In the mean time, it looks like all of the colors start with 0x, so (assuming that's the transparency field) it doesn't actually change the color. We have made changes to how IGB limits the colors it will accept (it will accept a 6-digit string with or without a # in front). I think those changes may have changed how IGB handles the 8-digit string. I was quite sure IGB would only take a 6-digit hex, but it seems to be working now with the unchanged 8-digit hex as well. And obviously the best option would be to pass the color directly as it comes as long as that doesn't break anything. We should test this further. I added the new attributes but I made a point to keep those in a separate commit so we might cherry pick around that. For the max_depth and show2tracks, I think those values are already the defaults, so there is very little value in hard-coding them. I don't think direction_type=arrow is a default---and for good reason, its ugly. I think that setting is ok for gene models, but RNA-Seq reads are so short that they look weird with arrows, and all the introns look like a stack of barbed wire. ...my opinion.
            Hide
            ann.loraine Ann Loraine added a comment -
            • Yes, please change "direction_type" to a setting that does not show the "barbed wire" look but does not color by strand.
            • For foreground color, stick with hex convention used in our other annots.xml's - e.g., "FFFFFF" for black and "FF0000" for red, etc.
            • Yes, it is fine to leave out the "show2tracks" setting.
            Show
            ann.loraine Ann Loraine added a comment - Yes, please change "direction_type" to a setting that does not show the "barbed wire" look but does not color by strand. For foreground color, stick with hex convention used in our other annots.xml's - e.g., "FFFFFF" for black and "FF0000" for red, etc. Yes, it is fine to leave out the "show2tracks" setting.
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            I rolled back the last two commits. So the this branch what I think we have decided is ideal. The colors using this annots file look like the colors on http://bar.utoronto.ca/eFP-Seq_Browser/
            branch parse_XML_AWS_bams
            https://bitbucket.org/lorainelab/igbquickload/branch/parse_XML_AWS_bams

            I made a new branch that still has the two extra commits, just so you can see them on bitbucket in case you want to consider them.
            After reviewing this issue, if we don't want to use them, we should delete that branch to avoid confusion later.
            branch otherOptions
            http://bar.utoronto.ca/eFP-Seq_Browser/

            I'm moving to Needs first level review and assigning it to Ann.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - I rolled back the last two commits. So the this branch what I think we have decided is ideal. The colors using this annots file look like the colors on http://bar.utoronto.ca/eFP-Seq_Browser/ branch parse_XML_AWS_bams https://bitbucket.org/lorainelab/igbquickload/branch/parse_XML_AWS_bams I made a new branch that still has the two extra commits, just so you can see them on bitbucket in case you want to consider them. After reviewing this issue, if we don't want to use them, we should delete that branch to avoid confusion later. branch otherOptions http://bar.utoronto.ca/eFP-Seq_Browser/ I'm moving to Needs first level review and assigning it to Ann.
            Hide
            ann.loraine Ann Loraine added a comment -

            Merge to master & send AL new annots.xml

            Show
            ann.loraine Ann Loraine added a comment - Merge to master & send AL new annots.xml
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            done and done.

            I'm moving this to needs testing and assigning it to Ann.

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - done and done. I'm moving this to needs testing and assigning it to Ann.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Deployed and live on http://lorainelab-quickload.scidas.org/bar/
            To test:

            • Visit BAR page http://bar.utoronto.ca/eFP-Seq_Browser/
            • Click LOAD DATA
            • Scroll up & down to view coverage graphs
            • Load corresponding data sets into IGB
            • Note whether colors match
            • Note whether data set names from Details column match IGB track labels
            Show
            ann.loraine Ann Loraine added a comment - - edited Deployed and live on http://lorainelab-quickload.scidas.org/bar/ To test: Visit BAR page http://bar.utoronto.ca/eFP-Seq_Browser/ Click LOAD DATA Scroll up & down to view coverage graphs Load corresponding data sets into IGB Note whether colors match Note whether data set names from Details column match IGB track labels
            Hide
            mason Mason Meyer (Inactive) added a comment -

            During my testing, I reviewed the following items:

            -Colors from images on BAR site match the corresponding tracks from the BAR data source in IGB
            -Track names in IGB correspond to the details column from the BAR site. The track label is in the form: "carpels SRR1207194". This is one of the details seen in the details column of the BAR site, although there are many other details included.

            Since this story meets all expectations and there seem to be no side effects as a result of this cahnge, I am now marking this story as resolved.

            Show
            mason Mason Meyer (Inactive) added a comment - During my testing, I reviewed the following items: -Colors from images on BAR site match the corresponding tracks from the BAR data source in IGB -Track names in IGB correspond to the details column from the BAR site. The track label is in the form: "carpels SRR1207194". This is one of the details seen in the details column of the BAR site, although there are many other details included. Since this story meets all expectations and there seem to be no side effects as a result of this cahnge, I am now marking this story as resolved.

              People

              • Assignee:
                ieclabau Ivory Blakley (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: