Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1367

Modify bar.js to handle new query params

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Sprint:
      Summer 2018 Part 2

      Attachments

        Issue Links

          Activity

          sneha Sneha Ramesh Watharkar (Inactive) created issue -
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Field Original Value New Value
          Sprint Summer 2018 Part 2 [ 49 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Description Sample link from BAR:

          https://bioviz.org/bar.html?version=A_thaliana_Jun_2009
          &annotation_set=Araport11
          &server_url=http://lorainelab-quickload.scidas.org/bar
          &gene_id=AT1G07350

          BAR code that forms these links:
          https://github.com/asully/eFP-Seq-Browser/blob/master/cgi-bin/core/custom.js
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Description Sample link from BAR:

          https://bioviz.org/bar.html?version=A_thaliana_Jun_2009
          &annotation_set=Araport11
          &server_url=http://lorainelab-quickload.scidas.org/bar
          &gene_id=AT1G07350

          BAR code that forms these links:
          https://github.com/asully/eFP-Seq-Browser/blob/master/cgi-bin/core/custom.js
          Sample link from BAR:

          https://bioviz.org/bar.html?version=A_thaliana_Jun_2009
          &annotation_set=Araport11
          &server_url=bar
          &gene_id=AT1G07350

          When forming the IGB localhost URL, use &server_url=http://lorainelab-quickload.scidas.org/bar
          BAR code that forms these links:
          https://github.com/asully/eFP-Seq-Browser/blob/master/cgi-bin/core/custom.js
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Sample link to activate IGB on localhost:

          http://localhost:7085/IGBControl?version=A_thaliana_Jun_2009&seq_id=Chr1&start=2257408&end=2260187&server_url=http://lorainelab-quickload.scidas.org/bar&loadresidues=True&feature_url_0=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam&query_url=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam

          Note: query_url is the same as feature_url_0, feature_url_1, etc. For every feature_url_n, include an identical query_url. For example, if you have feature_url_0=foo&feature_url_1=bar, then include query_url=foo&query_url=bar

          This is just how IGB 9.0.1 and below wants it. We will investigate why this is necessary later.

          Show
          ann.loraine Ann Loraine added a comment - - edited Sample link to activate IGB on localhost: http://localhost:7085/IGBControl?version=A_thaliana_Jun_2009&seq_id=Chr1&start=2257408&end=2260187&server_url=http://lorainelab-quickload.scidas.org/bar&loadresidues=True&feature_url_0=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam&query_url=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam Note: query_url is the same as feature_url_0, feature_url_1, etc. For every feature_url_n, include an identical query_url. For example, if you have feature_url_0=foo&feature_url_1=bar, then include query_url=foo&query_url=bar This is just how IGB 9.0.1 and below wants it. We will investigate why this is necessary later.
          Show
          ann.loraine Ann Loraine added a comment - - edited Residues are getting loaded after data from feature_url_0 are getting loaded. Appears to be a thread-related issue. Workaround: In the Javascript (bar.js) first make this call: http://localhost:7085/IGBControl?version=A_thaliana_Jun_2009&seq_id=Chr1&start=2257408&end=2260187&server_url=http://lorainelab-quickload.scidas.org/bar&loadresidues=True Wait a moment, then make this call: http://localhost:7085/IGBControl?version=A_thaliana_Jun_2009&seq_id=Chr1&start=2257408&end=2260187&server_url=http://lorainelab-quickload.scidas.org/bar&feature_url_0=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam&query_url=http://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam This ensures that when IGB accesses the data set (feature_url_0), the reference sequence will already have been loaded.
          Hide
          ann.loraine Ann Loraine added a comment -
          Show
          ann.loraine Ann Loraine added a comment - http://bioviz.org/cgi-bin/geneIdLookup.py?gene_id=AT1G07350 returns JSON with gene coordinates
          ann.loraine Ann Loraine made changes -
          Description Sample link from BAR:

          https://bioviz.org/bar.html?version=A_thaliana_Jun_2009
          &annotation_set=Araport11
          &server_url=bar
          &gene_id=AT1G07350

          When forming the IGB localhost URL, use &server_url=http://lorainelab-quickload.scidas.org/bar
          BAR code that forms these links:
          https://github.com/asully/eFP-Seq-Browser/blob/master/cgi-bin/core/custom.js
          Sample link from BAR:

          https://bioviz.org/bar.html?version=A_thaliana_Jun_2009&annotation_set=Araport11&server_url=bar&gene_id=AT1G07350&

          Show
          ann.loraine Ann Loraine added a comment - BAR code that forms links: https://github.com/asully/eFP-Seq-Browser/blob/master/cgi-bin/core/custom.js
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Assignee Sneha Ramesh Watharkar [ jdaly ] Ann Loraine [ aloraine ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - You can find work on Branch: https://bitbucket.org/swathark/bioviz/branch/IGBF-1367#diff
          ann.loraine Ann Loraine made changes -
          Link This issue relates to IGBF-1353 [ IGBF-1353 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          PR submitted.

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - PR submitted.
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          ann.loraine Ann Loraine made changes -
          Status Testing In Progress [ 10003 ] In Progress [ 3 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          PR merged. Testing on https://ann.bioviz.org

          Show
          ann.loraine Ann Loraine added a comment - PR merged. Testing on https://ann.bioviz.org
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Fix bar.html to show footer correctly.

          Show
          ann.loraine Ann Loraine added a comment - - edited Fix bar.html to show footer correctly.
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Comment [ I don't understand "Handle old and new style BAR links" ? ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Sneha Ramesh Watharkar [ jdaly ]
          ann.loraine Ann Loraine made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          Hide
          sneha Sneha Ramesh Watharkar (Inactive) added a comment -

          Prof [~aloraine] : Fixed footer of bar.html
          Branch : https://bitbucket.org/swathark/bioviz/branch/IGBF-1367-barjsFooterFix#diff

          Show
          sneha Sneha Ramesh Watharkar (Inactive) added a comment - Prof [~aloraine] : Fixed footer of bar.html Branch : https://bitbucket.org/swathark/bioviz/branch/IGBF-1367-barjsFooterFix#diff
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Assignee Sneha Ramesh Watharkar [ jdaly ] Ann Loraine [ aloraine ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Sneha Ramesh Watharkar [ jdaly ]
          sneha Sneha Ramesh Watharkar (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged to master.

          Show
          ann.loraine Ann Loraine added a comment - Merged to master.
          ann.loraine Ann Loraine made changes -
          Resolution Done [ 10000 ]
          Status Pull Request Submitted [ 10101 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Link This issue relates to IGBF-1364 [ IGBF-1364 ]
          ann.loraine Ann Loraine made changes -
          Workflow Loraine Lab Workflow [ 18063 ] Fall 2019 Workflow Update [ 19928 ]
          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 19928 ] Revised Fall 2019 Workflow Update [ 22048 ]

            People

            • Assignee:
              sneha Sneha Ramesh Watharkar (Inactive)
              Reporter:
              sneha Sneha Ramesh Watharkar (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: