Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 2019 Sprint 8, Summer 2019 Sprint 9
Description
The Cytoscape project was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store as "Cytoscape 2" Apps.
Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-activate the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this.
Attachments
Activity
- Look at models.py in apps module in appstore project.
- Also remove reference to 2012 contest
I have made the changes required for the removal of Cystoscape version 2 reference.
Sai Charan Reddy Vallapureddy Could you plesae review the changes present at :
https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1434/
Also, I wanted to mention that there are two files named twox_plugins.html & twox_plugins.tmpl.html which I have kept as it is because even all of the references to those html files have been removed from the codebase.
Would that be okay or should I go ahead and delete those files as well? let me know your thoughts on that.
Please go ahead and delete twox_plugins.html & twox_plugins.tmpl.html.
The code looks good. Ready for pull request.
I have deleted those two files from the code base.
Pull request for the same has been submitted.
The code changes are available at:
https://bitbucket.org/lorainelab/appstore/pull-requests/48/igbf-1434-delete-all-the-references-to-the/diff
Prof. [~aloraine] could you please review it?
Merged to master but not yet deployed on testappstore
To test:
- Check that under Login there is no longer a 2.x Plugin Management link
- Also search the code base for references that may still need to be removed.
Kindly remove the references to 2012 competition from the following:
help\urls.py
help\views.py.
Shamika Gajanan Kulkarni Please review the code again.
https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1434/help/
Let me know if I can submit a pull request for the same once you are done with it.
The code looks fine. Please submit a pull request for the same.
Pull request has been issued for the same.
The code changes are present at:
https://bitbucket.org/lorainelab/appstore/pull-requests/51/igbf-1434-delete-all-the-references-to-the/diff
Merged to master and deployed on testappstore.bioviz.org.
Tested with the latest code. All the references to twox are deleted. Moving it to closed state.