Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 2019 Sprint 8, Summer 2019 Sprint 9
Description
The Cytoscape project was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store as "Cytoscape 2" Apps.
Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-activate the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
| Story Points | 0.5 |
| Description | Cytoscape was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store. Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-active the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this. |
| Description | Cytoscape was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store. Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-active the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this. |
The Cytoscape project was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store as "Cytoscape 2" Apps.
Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-active the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this. |
| Description |
The Cytoscape project was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store as "Cytoscape 2" Apps.
Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-active the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this. |
The Cytoscape project was an early adopter of plug-in architecture. Before OSGi tooling matured, they used a home-grown method to enable plug-ins. Later, the project adopted OSGi for supporting plug-ins. The earlier plug-ins are still being distributed and supported by the Cytoscape App Store as "Cytoscape 2" Apps.
Since IGB has no equivalent, we can't show users that part of the site. So we need to remove or de-activate the Cytoscape 2 related code. This issue requires finesse and care because we want to enable the Cytoscape developers to more easily use our code. If possible, we should try to make the changes in one or a small number of easily identifiable commits to facilitate this. |
| Sprint | Winter 2018 Sprint 1 [ 56 ] |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Sprint | Winter 2018 Sprint 1 [ 56 ] |
| Rank | Ranked higher |
| Sprint | Winter 2018 Sprint 1 [ 56 ] |
| Rank | Ranked lower |
| Sprint | Winter 2018 Sprint 1 [ 56 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Sprint | Summer 2019 Sprint 8 [ 67 ] |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Story Points | 0.5 | 1 |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Assignee | Prutha Kulkarni [ prutha ] |
Hide
Ann Loraine
added a comment -
Permalink
- Look at models.py in apps module in appstore project.
- Also remove reference to 2012 contest
Show
Ann Loraine
added a comment -
Look at models.py in apps module in appstore project.
Also remove reference to 2012 contest
| Status | Open [ 1 ] | In Progress [ 3 ] |
I have made the changes required for the removal of Cystoscape version 2 reference.
Sai Charan Reddy Vallapureddy Could you plesae review the changes present at :
https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1434/
Also, I wanted to mention that there are two files named twox_plugins.html & twox_plugins.tmpl.html which I have kept as it is because even all of the references to those html files have been removed from the codebase.
Would that be okay or should I go ahead and delete those files as well? let me know your thoughts on that.
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Please go ahead and delete twox_plugins.html & twox_plugins.tmpl.html.
| Status | Needs 1st Level Review [ 10005 ] | Ready for Pull Request [ 10304 ] |
The code looks good. Ready for pull request.
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
I have deleted those two files from the code base.
Pull request for the same has been submitted.
The code changes are available at:
https://bitbucket.org/lorainelab/appstore/pull-requests/48/igbf-1434-delete-all-the-references-to-the/diff
Prof. [~aloraine] could you please review it?
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
Merged to master but not yet deployed on testappstore
| Sprint | Summer 2019 Sprint 8 [ 67 ] | Summer 2019 Sprint 8, Summer 2019 Sprint 9 [ 67, 68 ] |
| Rank | Ranked higher |
To test:
- Check that under Login there is no longer a 2.x Plugin Management link
- Also search the code base for references that may still need to be removed.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Kindly remove the references to 2012 competition from the following:
help\urls.py
help\views.py.
| Status | Testing In Progress [ 10003 ] | Open [ 1 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Prutha Kulkarni [ prutha ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Shamika Gajanan Kulkarni Please review the code again.
https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1434/help/
Let me know if I can submit a pull request for the same once you are done with it.
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
The code looks fine. Please submit a pull request for the same.
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Prutha Kulkarni [ prutha ] |
Pull request has been issued for the same.
The code changes are present at:
https://bitbucket.org/lorainelab/appstore/pull-requests/51/igbf-1434-delete-all-the-references-to-the/diff
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Merged to master and deployed on testappstore.bioviz.org.
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
Tested with the latest code. All the references to twox are deleted. Moving it to closed state.
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] | Prutha Kulkarni [ prutha ] |
| Resolution | Done [ 10000 ] | |
| Status | Needs Testing [ 10002 ] | Closed [ 6 ] |
| Workflow | Loraine Lab Workflow [ 18140 ] | Fall 2019 Workflow Update [ 19962 ] |
| Workflow | Fall 2019 Workflow Update [ 19962 ] | Revised Fall 2019 Workflow Update [ 22083 ] |