Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: 9.1.0 Major Release
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12, Fall 2019 Sprint 1, Fall 2019 Sprint 2
Description
To increase usability between sessions, it is best to preserve as many user settings as possible.
Soft-clipping settings should be saved between sessions, such as soft-clip visualization choice and custom color selection.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] | Kiran Korey [ kkorey ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Need first level review for the branch
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1442-sc-settings
Thanks
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Status | Reviewing [ 10301 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Rank | Ranked higher |
| Sprint | Fall 2018 Sprint 4 [ 54 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5 [ 54, 55 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Fix Version/s | 9.1.0 Major Release [ 10601 ] | |
| Labels | Advanced |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Rank | Ranked higher |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5 [ 54, 55 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Winter 2018 Sprint 1 [ 54, 55, 56 ] |
| Rank | Ranked lower |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Winter 2018 Sprint 1 [ 54, 55, 56 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5 [ 54, 55 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
Looks like this got forgotten. Someone should pick it up - please grab the code, rebase, test, and move into 1st level review. Please consult with Dr. Freese as required.
| Epic Link | IGBF-1765 [ 17855 ] |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5 [ 54, 55 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 10 [ 54, 55, 69 ] |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 10 [ 54, 55, 69 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11 [ 54, 55, 70 ] |
| Rank | Ranked higher |
| Assignee | Kiran Korey [ kkorey ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
I have merged the latest changes with this branch.
Testing Steps followed:
1. Loaded a bam file and changed the soft clips settings.
2.Saved the session
3.Re-loaded the session and the settings were restored.
Working as expected.
Since I do not have write access to kiran korey's fork I have pulled the changes from his fork to mine
https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1442#diff
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11 [ 54, 55, 70 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12 [ 54, 55, 70, 71 ] |
| Rank | Ranked higher |
Noor Zahara, it is working as expcted. Code level review has been done for the same. You can now submit a pull request for it.
| Assignee | Prutha Kulkarni [ prutha ] | Noor Zahara [ noor91zahara ] |
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12 [ 54, 55, 70, 71 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12, Fall 2019 Sprint 1 [ 54, 55, 70, 71, 72 ] |
| Rank | Ranked higher |
| Status | Testing In Progress [ 10003 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Needed two small changes in TrackStyle.java. There were two places where the boolean values for soft clipped custom color were being incorrectly assigned by the default color.
Made changes and issued pull request .
The soft clip settings are otherwise being correctly saved in the session xml, and between IGB sessions.
| Workflow | Loraine Lab Workflow [ 18148 ] | Fall 2019 Workflow Update [ 19054 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12, Fall 2019 Sprint 1 [ 54, 55, 70, 71, 72 ] | Fall 2018 Sprint 4, Fall 2018 Sprint 5, Summer 2019 Sprint 11, Summer 2019 Sprint 12, Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 54, 55, 70, 71, 72, 73 ] |
| Rank | Ranked higher |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Noor Zahara, I have followed the steps mentioned above to test the ticket i.e. I have changed the soft clicked settings to use the custom color and then I saved the session. When I loaded the same saved session then the setting which was done previously was preserved.
Working as expected. Moving the ticket to DONE.
| Assignee | Prutha Kulkarni [ prutha ] | Noor Zahara [ noor91zahara ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 19054 ] | Revised Fall 2019 Workflow Update [ 22089 ] |
Within the class ToggleShowAsPairedAction, David Norris left a comment about needing to register state in the java preferences. Looking at the ToggleToolTipAction class file, this may be a couple lines of code to save to preferences in the PreferenceUtils.