Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1459

Improve testing in quickload module; relieve dependencies on externally hosted files

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      There are three test classes in the "quickload" sub-project of the "core" super-project which have dependencies on external QL hosting, which has changed.

      This tasks is to re-write the tests to use on-board test files, rather than externally hosted files.

      Suggestion:

      Create a simple QL site within the test resources directory for use in testing. Then modify the tests to use this local QL site.

      In addition, do your best to improve the test coverage so that more fragile aspects of the code are tested. Review Jira issues to get a sense of what aspects are the most fragile.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18168 ] Fall 2019 Workflow Update [ 18920 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 18920 ] Revised Fall 2019 Workflow Update [ 21047 ]
            Status Open [ 1 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Description There are three test classes in the "quickload" sub-project of the "core" super-project which have dependencies on external QL hosting, which has changed.

            This tasks is to re-write the tests to use on-board test files, rather than externally hosted files.

            For this tasks, create a simple QL site within the test resources directory for use in testing. Then modify the tests to use this local QL site.

            In addition, do your best to improve the test coverage so that more fragile aspects of the code are tested. Review Jira issues to get a sense of what aspects are the most fragile.

            This is possibly a good job for a beginner, as this will bring pretty good exposure to the QL system.
            There are three test classes in the "quickload" sub-project of the "core" super-project which have dependencies on external QL hosting, which has changed.

            This tasks is to re-write the tests to use on-board test files, rather than externally hosted files.

            Suggestion:

            Create a simple QL site within the test resources directory for use in testing. Then modify the tests to use this local QL site.

            In addition, do your best to improve the test coverage so that more fragile aspects of the code are tested. Review Jira issues to get a sense of what aspects are the most fragile.

            This is possibly a good job for a beginner, as this will bring pretty good exposure to the QL system.
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Epic Link IGBF-1531 [ 17617 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1: 14 Sep - 25 Sep [ 103 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            nfreese Nowlan Freese made changes -
            Link This issue relates to IGBF-2341 [ IGBF-2341 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1: 14 Sep - 25 Sep [ 103 ] Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 103, 104 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 103, 104 ] Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23 [ 103, 104, 106 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Description There are three test classes in the "quickload" sub-project of the "core" super-project which have dependencies on external QL hosting, which has changed.

            This tasks is to re-write the tests to use on-board test files, rather than externally hosted files.

            Suggestion:

            Create a simple QL site within the test resources directory for use in testing. Then modify the tests to use this local QL site.

            In addition, do your best to improve the test coverage so that more fragile aspects of the code are tested. Review Jira issues to get a sense of what aspects are the most fragile.

            This is possibly a good job for a beginner, as this will bring pretty good exposure to the QL system.
            There are three test classes in the "quickload" sub-project of the "core" super-project which have dependencies on external QL hosting, which has changed.

            This tasks is to re-write the tests to use on-board test files, rather than externally hosted files.

            Suggestion:

            Create a simple QL site within the test resources directory for use in testing. Then modify the tests to use this local QL site.

            In addition, do your best to improve the test coverage so that more fragile aspects of the code are tested. Review Jira issues to get a sense of what aspects are the most fragile.
            ann.loraine Ann Loraine made changes -
            Labels Beginner
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            [~aloraine] I believe Srishti Tiwari has already fixed this issue in IGBF-2341. I have tried to run the test cases without the internet and everything is working fine. We are not using any externally hosted files for testing in Quickload now. Please let me know if I need to work on anything more other than removing externally hosted files for this ticket?.

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - [~aloraine] I believe Srishti Tiwari has already fixed this issue in IGBF-2341 . I have tried to run the test cases without the internet and everything is working fine. We are not using any externally hosted files for testing in Quickload now. Please let me know if I need to work on anything more other than removing externally hosted files for this ticket?.
            ann.loraine Ann Loraine made changes -
            Comment [ I was hoping you could add some new test cases that will confirm that our quickload site parsing code is working correctly. ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Thank you - it is done. Moving to Closed.

            Show
            ann.loraine Ann Loraine added a comment - Thank you - it is done. Moving to Closed.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                ssegu Sai Supreeth Segu (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: