Details
-
Type: Improvement
-
Status: Closed (View Workflow)
-
Priority: Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 2019 Sprint 4
Description
Note: Complete Django tutorial parts 1,2, and 3 before starting.
Observe instances of hard-coding project directory name in current master branch:
on unix:
$ find . | grep \.py$ | xargs grep CyApp
./settings.py: SITE_DIR ="~/CyAppStore/"
./settings.py: SITE_DIR ="~/CyAppStore/"
./settings.py:# Django settings for CyAppStore project.
./settings.py:ROOT_URLCONF = 'CyAppStore.urls'
./settings.py: 'CyAppStore', # this must be included to find root templates
./dbmigration/screenshots.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore')
./dbmigration/releases.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore')
./dbmigration/ipaddr.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore')
./urls.py: # url(r'^$', 'CyAppStore.views.home', name='home'),
./urls.py: # url(r'^CyAppStore/', include('CyAppStore.foo.urls')),
./conf/dbs-template.py: 'NAME': 'CyAppStore', # sql database name
./conf/paths-template.py:# should be the absolute path to the CyAppStore directory on the filesystem
./apps/management/commands/add_plugins.py:from CyAppStore.util.id_util import fullname_to_name
./apps/management/commands/add_plugins.py:from CyAppStore.apps.views import _parse_iso_date
Recommend changing "CyAppStore" to "appstore" consistent with new project name.
Test after each edit to ensure can still hit URLs for each Django App in project.
Note: Complete Django tutorial parts 1,2, and 3 before starting.
Attachments
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link | IGBF-1388 [ 17463 ] |
Rank | Ranked higher |
Description |
Clone repo, observe instances of hard-coding project directory name:
on unix: $ find . | grep \.py$ | xargs grep CyApp ./settings.py: SITE_DIR ="~/CyAppStore/" ./settings.py: SITE_DIR ="~/CyAppStore/" ./settings.py:# Django settings for CyAppStore project. ./settings.py:ROOT_URLCONF = 'CyAppStore.urls' ./settings.py: 'CyAppStore', # this must be included to find root templates ./dbmigration/screenshots.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./dbmigration/releases.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./dbmigration/ipaddr.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./urls.py: # url(r'^$', 'CyAppStore.views.home', name='home'), ./urls.py: # url(r'^CyAppStore/', include('CyAppStore.foo.urls')), ./conf/dbs-template.py: 'NAME': 'CyAppStore', # sql database name ./conf/paths-template.py:# should be the absolute path to the CyAppStore directory on the filesystem ./apps/management/commands/add_plugins.py:from CyAppStore.util.id_util import fullname_to_name ./apps/management/commands/add_plugins.py:from CyAppStore.apps.views import _parse_iso_date Recommend changing "CyAppStore" to "appstore" consistent with new project name. Test after each edit to ensure can still hit URLs for each Django App in project. *Note*: Complete Django tutorial parts 1,2, and 3 before starting. |
*Note*: Complete Django tutorial parts 1,2, and 3 before starting.
Observe instances of hard-coding project directory name in current master branch: on unix: $ find . | grep \.py$ | xargs grep CyApp ./settings.py: SITE_DIR ="~/CyAppStore/" ./settings.py: SITE_DIR ="~/CyAppStore/" ./settings.py:# Django settings for CyAppStore project. ./settings.py:ROOT_URLCONF = 'CyAppStore.urls' ./settings.py: 'CyAppStore', # this must be included to find root templates ./dbmigration/screenshots.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./dbmigration/releases.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./dbmigration/ipaddr.py: con = mdb.connect('localhost', 'root', '', 'CyAppStore') ./urls.py: # url(r'^$', 'CyAppStore.views.home', name='home'), ./urls.py: # url(r'^CyAppStore/', include('CyAppStore.foo.urls')), ./conf/dbs-template.py: 'NAME': 'CyAppStore', # sql database name ./conf/paths-template.py:# should be the absolute path to the CyAppStore directory on the filesystem ./apps/management/commands/add_plugins.py:from CyAppStore.util.id_util import fullname_to_name ./apps/management/commands/add_plugins.py:from CyAppStore.apps.views import _parse_iso_date Recommend changing "CyAppStore" to "appstore" consistent with new project name. Test after each edit to ensure can still hit URLs for each Django App in project. *Note*: Complete Django tutorial parts 1,2, and 3 before starting. |
Resolution | Done [ 10000 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Status | Closed [ 6 ] | Closed [ 6 ] |
Resolution | Done [ 10000 ] | |
Status | Closed [ 6 ] | Open [ 1 ] |
Assignee | Narendra Kumar Vankayala [ narendra ] |
Rank | Ranked lower |
Sprint | Spring 2019 Sprint 4 [ 62 ] |
Rank | Ranked higher |
Status | Open [ 1 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Assignee | Narendra Kumar Vankayala [ narendra ] |
Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
Assignee | Ann Loraine [ aloraine ] |
Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
Assignee | Ann Loraine [ aloraine ] | Narendra Kumar Vankayala [ narendra ] |
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Assignee | Narendra Kumar Vankayala [ narendra ] |
Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
Resolution | Done [ 10000 ] | |
Status | Needs Testing [ 10002 ] | Closed [ 6 ] |
Assignee | Narendra Kumar Vankayala [ narendra ] |
Workflow | Loraine Lab Workflow [ 18349 ] | Fall 2019 Workflow Update [ 20078 ] |
Workflow | Fall 2019 Workflow Update [ 20078 ] | Revised Fall 2019 Workflow Update [ 22212 ] |
Please review the code changes.
https://bitbucket.org/narendravankayala/appstore-narendra/src/IGBF-1628/