Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1629

Invoke the REST Api of IGB to manage app lifecycle from AppStore

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          3
        • Sprint:
          Spring 2019 Sprint 3, Spring 2019 Sprint 4, Spring 2019 Sprint 5

          Attachments

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

            The code changes for Install/Update of apps from the App Store:-
            https://bitbucket.org/rpatil14/appstore-narendra-riddhi/commits/66424f74e2fb3ded2b64ff6db0ca4f703a66ab94?at=IGBF-1629

            TODO :-
            1) Dr.Loraine to provide more informative error message in case IGB is not running.
            2) Riddhi to create additional tickets related to this issue. (ex. rate it app, release history, make other links working on the website etc.)

            cc.[~aloraine], Narendra Kumar Vankayala, Sai Charan Reddy Vallapureddy

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - The code changes for Install/Update of apps from the App Store:- https://bitbucket.org/rpatil14/appstore-narendra-riddhi/commits/66424f74e2fb3ded2b64ff6db0ca4f703a66ab94?at=IGBF-1629 TODO :- 1) Dr.Loraine to provide more informative error message in case IGB is not running. 2) Riddhi to create additional tickets related to this issue. (ex. rate it app, release history, make other links working on the website etc.) cc. [~aloraine] , Narendra Kumar Vankayala , Sai Charan Reddy Vallapureddy
            Hide
            Permalink
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            Change Markdown to HTML for App description

            @riddhi

            Please change the line 198 in apps-->views.py

            From:
            app.details = base64.b64decode(app.details)
            To:
            app.details = base64.b64decode(app.details).decode("utf-8")

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Change Markdown to HTML for App description @riddhi Please change the line 198 in apps-->views.py From: app.details = base64.b64decode(app.details) To: app.details = base64.b64decode(app.details).decode("utf-8")
            Hide
            Permalink
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

            Pushed the changes for Markdown provided by Sai Charan Reddy Vallapureddy to my branch.

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Pushed the changes for Markdown provided by Sai Charan Reddy Vallapureddy to my branch.
            Hide
            Permalink
            ann.loraine Ann Loraine added a comment - - edited

            I looked at the branch. I think it's fine - I just had a few suggestions.

            Later on (in a later draft - after these changes are merged) I'd like us to remove references to "cy" from javascript variables, HTML div classes, etc. But I don't think this is important right now – and may never be. More important (probably) would be to remove business logic related to cytoscape version 2 apps, which pre-date Cytoscape's adoption of OSGi and isn't relevant to IGB.

            Before submitting a pull request, can you rebase onto the latest master branch? Looks like the last common commit was:

            • Narendra Kumar Vankayala cec0368 "Enable social login using Google"

            Please check for any possible conflicts. If you rebase and there are some conflicts, you will be in a good position to resolve them – better than me!

            Show
            ann.loraine Ann Loraine added a comment - - edited I looked at the branch. I think it's fine - I just had a few suggestions. Later on (in a later draft - after these changes are merged) I'd like us to remove references to "cy" from javascript variables, HTML div classes, etc. But I don't think this is important right now – and may never be. More important (probably) would be to remove business logic related to cytoscape version 2 apps, which pre-date Cytoscape's adoption of OSGi and isn't relevant to IGB. Before submitting a pull request, can you rebase onto the latest master branch? Looks like the last common commit was: Narendra Kumar Vankayala cec0368 "Enable social login using Google" Please check for any possible conflicts. If you rebase and there are some conflicts, you will be in a good position to resolve them – better than me!
            Hide
            Permalink
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

            Fixed the issue with decode of app description and incorporated review comments

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Fixed the issue with decode of app description and incorporated review comments
            Hide
            Permalink
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            Merged changes to 1682.

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Merged changes to 1682.

              People

              • Assignee:
                Unassigned
                Reporter:
                rpatil14 Riddhi Jagdish Patil (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: