I looked at the branch. I think it's fine - I just had a few suggestions.
Later on (in a later draft - after these changes are merged) I'd like us to remove references to "cy" from javascript variables, HTML div classes, etc. But I don't think this is important right now – and may never be. More important (probably) would be to remove business logic related to cytoscape version 2 apps, which pre-date Cytoscape's adoption of OSGi and isn't relevant to IGB.
Before submitting a pull request, can you rebase onto the latest master branch? Looks like the last common commit was:
- Narendra Kumar Vankayala cec0368 "Enable social login using Google"
Please check for any possible conflicts. If you rebase and there are some conflicts, you will be in a good position to resolve them – better than me!
The code changes for Install/Update of apps from the App Store:-
https://bitbucket.org/rpatil14/appstore-narendra-riddhi/commits/66424f74e2fb3ded2b64ff6db0ca4f703a66ab94?at=IGBF-1629
TODO :-
1) Dr.Loraine to provide more informative error message in case IGB is not running.
2) Riddhi to create additional tickets related to this issue. (ex. rate it app, release history, make other links working on the website etc.)
cc.[~aloraine], Narendra Kumar Vankayala, Sai Charan Reddy Vallapureddy