Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The following tags to be assigned to the corresponding apps.

      App : 23andMe-SNP-Converter
      Tag : personal genomics, SNP, variation, parsers

      App: Geometric mean graph operator
      Tag :genome graph, ChIP-Seq, RNA-Seq

      App : ProtAnnot
      Tag : annotation, search, splicing

      App : Command Socket
      Tag : REST, data sources, scripting

      App :Merge Annotation Track Operator
      Tag :annotation, RNA-Seq, ChIP-Seq

        Attachments

          Activity

          Narendra Narendra Kumar Vankayala (Inactive) created issue -
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Field Original Value New Value
          Epic Link IGBF-1388 [ 17463 ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Show
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - Please review the code changes. https://bitbucket.org/narendravankayala/appstore-narendra/branch/IGBF-1692
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Assignee Narendra Kumar Vankayala [ narendra ]
          Hide
          Narendra Narendra Kumar Vankayala (Inactive) added a comment -

          Added all the tags through admin interface and populated database

          Show
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - Added all the tags through admin interface and populated database
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Assignee Narendra Kumar Vankayala [ narendra ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Need to deploy on testappstore.bioviz.org

          Show
          ann.loraine Ann Loraine added a comment - Need to deploy on testappstore.bioviz.org
          ann.loraine Ann Loraine made changes -
          Assignee Narendra Kumar Vankayala [ narendra ] Ann Loraine [ aloraine ]
          ann.loraine Ann Loraine made changes -
          Sprint Spring 2019 Sprint 5 [ 63 ] Spring 2019 Sprint 5, Spring 2019 Sprint 6 [ 63, 64 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          Hide
          ann.loraine Ann Loraine added a comment -

          Deployed on testappstore.bioviz.org.
          When I visit the page for an App, I see the categories listed.
          However, the main (home) page is not showing the categories.
          Is this the expected behavior?

          Show
          ann.loraine Ann Loraine added a comment - Deployed on testappstore.bioviz.org. When I visit the page for an App, I see the categories listed. However, the main (home) page is not showing the categories. Is this the expected behavior?
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Narendra Kumar Vankayala [ narendra ]
          ann.loraine Ann Loraine made changes -
          Status Needs Testing [ 10002 ] Open [ 1 ]
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Assignee Narendra Kumar Vankayala [ narendra ] Sai Charan Reddy Vallapureddy [ svallapu ]
          Hide
          Narendra Narendra Kumar Vankayala (Inactive) added a comment -

          Dr.@Ann Loraine, Yes I guess this is the expected behaviour. I found that the minimum tag count for it be displayed on the Home page is 3(right now) i.e., a tag must be assigned to more than 3 apps. As we don't have any tag which is assigned to more than 3 apps, I suppose that should be reason for this behaviour.

          Show
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - Dr.@Ann Loraine, Yes I guess this is the expected behaviour. I found that the minimum tag count for it be displayed on the Home page is 3(right now) i.e., a tag must be assigned to more than 3 apps. As we don't have any tag which is assigned to more than 3 apps, I suppose that should be reason for this behaviour.
          Hide
          ann.loraine Ann Loraine added a comment -

          OK - makes sense!

          Could you change this to minimum of 1?

          Please make sure to state that clearly in the commit so that we can easily change it later.

          Show
          ann.loraine Ann Loraine added a comment - OK - makes sense! Could you change this to minimum of 1? Please make sure to state that clearly in the commit so that we can easily change it later.
          ann.loraine Ann Loraine made changes -
          Assignee Sai Charan Reddy Vallapureddy [ svallapu ] Narendra Kumar Vankayala [ narendra ]
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Assignee Narendra Kumar Vankayala [ narendra ] Sai Charan Reddy Vallapureddy [ svallapu ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Assignee Sai Charan Reddy Vallapureddy [ svallapu ] Narendra Kumar Vankayala [ narendra ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status In Progress [ 3 ] In Progress [ 3 ]
          Hide
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - - edited

          Please review the code changes for displaying tags with count under Categories in Home Page.

          https://bitbucket.org/narendravankayala/appstore-narendra/branch/IGBF-1692

          To change the number of tags to display in the home page
          Go to :
          appstore/views.py --> class _NavPanelConfig --> change min_tag_count
          Currently, min_tag_count =0 and num_of_top_tags=5
          min_tag_count - The count of number of apps assigned to a particular tag
          num_of_top_tags - The number of tags to be displayed above the [more>>] button on homepage

          Changes made in util/view_util.py
          In html_response method(template_name, context, request, processors = []) method :
          processors[] - This argument accepts method names to process if there are any.
          Added a loop to execute all the methods listed in the processors and update the context so that updated context is available to views.

          Show
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - - edited Please review the code changes for displaying tags with count under Categories in Home Page. https://bitbucket.org/narendravankayala/appstore-narendra/branch/IGBF-1692 To change the number of tags to display in the home page Go to : appstore/views.py --> class _NavPanelConfig --> change min_tag_count Currently, min_tag_count =0 and num_of_top_tags=5 min_tag_count - The count of number of apps assigned to a particular tag num_of_top_tags - The number of tags to be displayed above the [more>>] button on homepage Changes made in util/view_util.py In html_response method(template_name, context, request, processors = []) method : processors[] - This argument accepts method names to process if there are any. Added a loop to execute all the methods listed in the processors and update the context so that updated context is available to views.
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Assignee Narendra Kumar Vankayala [ narendra ]
          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          Site is crashing when we try to load apps with categories having spaces and other special characters.

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Site is crashing when we try to load apps with categories having spaces and other special characters.
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] Open [ 1 ]
          Hide
          Narendra Narendra Kumar Vankayala (Inactive) added a comment -

          Please review the code changes. Fixed issue with tags having spaces and special character ( - ).

          Changed regex in urls.py file to accpet tags with space and without space.

          Show
          Narendra Narendra Kumar Vankayala (Inactive) added a comment - Please review the code changes. Fixed issue with tags having spaces and special character ( - ). Changed regex in urls.py file to accpet tags with space and without space.
          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          I have reviewed the new changes and everything is working as expected.

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - I have reviewed the new changes and everything is working as expected.
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Assignee Narendra Kumar Vankayala [ narendra ]
          Narendra Narendra Kumar Vankayala (Inactive) made changes -
          Status Open [ 1 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged to master.

          Show
          ann.loraine Ann Loraine added a comment - Merged to master.
          svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Needs Testing [ 10002 ] Closed [ 6 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Deployed to testappstore.bioviz.org

          Show
          ann.loraine Ann Loraine added a comment - Deployed to testappstore.bioviz.org
          ann.loraine Ann Loraine made changes -
          Story Points 0.25
          ann.loraine Ann Loraine made changes -
          Workflow Loraine Lab Workflow [ 18414 ] Fall 2019 Workflow Update [ 20130 ]
          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 20130 ] Revised Fall 2019 Workflow Update [ 22266 ]

            People

            • Assignee:
              Narendra Narendra Kumar Vankayala (Inactive)
              Reporter:
              Narendra Narendra Kumar Vankayala (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: