Details
-
Type:
New Feature
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1.5
-
Epic Link:
-
Sprint:Summer 2019 Sprint 8, Summer 2019 Sprint 9
Description
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
For functional review, please deploy to show the functionality and changed appearance.
| Status | Needs 1st Level Review [ 10005 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
The code has been deployed on EC2 instance and demo apps have been added for functional review. Kindly review.
| Sprint | Summer 2019 Sprint 8 [ 67 ] | Summer 2019 Sprint 8, Summer 2019 Sprint 9 [ 67, 68 ] |
| Rank | Ranked higher |
Please provide link to EC2 instance and move back to Needs First Level Review.
Then, please ask another member of the App Store team to look at it and review.
They should do this ASAP so that the link will work – once the EC2 is turned off for the evening, the next time you start it, the link will be different. Try to do this today if at all possible.
| Status | Needs 1st Level Review [ 10005 ] | Open [ 1 ] |
| Rank | Ranked higher |
Kindly check the public IP for my EC2 instance which has the code deployed to it.
| Status | Open [ 1 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Sai Charan Reddy Vallapureddy [ svallapu ] |
Pagination is working great. It would be great if you could handle links in Django way(urls.py). The whole site is following that convention.
Shamika Gajanan Kulkarni
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Needs 1st Level Review [ 10005 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Comment | [ @Sai Charan Reddy Vallapureddy Kindly review the EC2 instance for the changes deployed. ] |
Kindly review the changes deployed to EC2 instance.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
I have tested the Pagination. Everything is perfect as expected.
Please submit the pull request.
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] | Shamika Gajanan Kulkarni [ shamika ] |
The pull request has been issued for the same. Please find the code changes at
https://bitbucket.org/lorainelab/appstore/pull-requests/52/igbf-1770-pagination-using-django-urlconf/diff
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Merged to master, deployed to testappstore.bioviz.org.
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
Tested in testappstore.bioviz.org. Everything is working as expected. Moving it to done state.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Resolution | Done [ 10000 ] | |
| Status | Needs Testing [ 10002 ] | Closed [ 6 ] |
| Workflow | Loraine Lab Workflow [ 18492 ] | Fall 2019 Workflow Update [ 20194 ] |
| Workflow | Fall 2019 Workflow Update [ 20194 ] | Revised Fall 2019 Workflow Update [ 22331 ] |
I have made the necessary changes to the code to implement pagination on top page.
Also, to enable proper display of all apps the height had to be adjusted. The code includes changes for that as well.
The link is as follows.
https://bitbucket.org/sgk27/s-appstore/branch/IGBF-1770#diff
Kindly review.