Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1771

Fix sorting when there are ties (or all are zero)

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:

          Description

          To reproduce:

          • Visit All Apps link under Categories on home page
          • Click various sorts to observe weird behavior

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              ann.loraine Ann Loraine created issue -
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-1388 [ 17463 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1771

              Code diff for review.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1771 Code diff for review.
              Hide
              Permalink
              prutha Prutha Kulkarni (Inactive) added a comment -

              Reviewed the code changes for the same. If all apps have 0 attribute value then the app order is untouched and when some of the apps are having a non-zero attriibute value while others have 0 attribute value then the sorting is done by name.
              Noor Zahara You can submit a pull request for the ticket.

              Show
              prutha Prutha Kulkarni (Inactive) added a comment - Reviewed the code changes for the same. If all apps have 0 attribute value then the app order is untouched and when some of the apps are having a non-zero attriibute value while others have 0 attribute value then the sorting is done by name. Noor Zahara You can submit a pull request for the ticket.
              prutha Prutha Kulkarni (Inactive) made changes -
              Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Hi Noor! I added a comment in bitbucket. Please take a look!

              Show
              ann.loraine Ann Loraine added a comment - Hi Noor! I added a comment in bitbucket. Please take a look!
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment - - edited

              [~aloraine]

              I have created a pull request :
              https://bitbucket.org/lorainelab/appstore/pull-requests/47/igbf-1771/diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - - edited [~aloraine] I have created a pull request : https://bitbucket.org/lorainelab/appstore/pull-requests/47/igbf-1771/diff
              noor91zahara Noor Zahara (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ] Prutha Kulkarni [ prutha ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
              Hide
              Permalink
              prutha Prutha Kulkarni (Inactive) added a comment -

              Noor Zahara Functional testing has been done for the issue.It is working fine. Attribute name & type parameters are added to the sorting function in order to handle ties. In case of ties the sorting is done by app name.
              I am moving the ticket to "Done".

              Show
              prutha Prutha Kulkarni (Inactive) added a comment - Noor Zahara Functional testing has been done for the issue.It is working fine. Attribute name & type parameters are added to the sorting function in order to handle ties. In case of ties the sorting is done by app name. I am moving the ticket to "Done".
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Prutha Kulkarni [ prutha ] Noor Zahara [ noor91zahara ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Resolution Done [ 10000 ]
              Status Testing In Progress [ 10003 ] Closed [ 6 ]
              ann.loraine Ann Loraine made changes -
              Workflow Loraine Lab Workflow [ 18493 ] Fall 2019 Workflow Update [ 20195 ]
              ann.loraine Ann Loraine made changes -
              Workflow Fall 2019 Workflow Update [ 20195 ] Revised Fall 2019 Workflow Update [ 22332 ]

                People

                • Assignee:
                  noor91zahara Noor Zahara (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: