Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1800

Include git properties in Genoviz SDK jar

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
        • Story Points:
          0.25
        • Epic Link:
        • Sprint:
          Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11, Summer 2019 Sprint 12

          Description

          Include git properties file in Genoviz SDK bundle to enable better artifact tracking for developers.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-1798 Check: Does source code get packaged with genoviz sdk bundle?

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1520 Deploy Genoviz SDK to Nexus

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1216 Set up bitbucket pipeline build process for GenoViz SDK

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1548 Add more details about version/build to About IGB screen

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1773 Create new repos for optionalPlugins

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                ann.loraine Ann Loraine created issue -
                ann.loraine Ann Loraine made changes -
                Field Original Value New Value
                Epic Link IGBF-1531 [ 17617 ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-1520 [ IGBF-1520 ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-1216 [ IGBF-1216 ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-1548 [ IGBF-1548 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-1773 [ IGBF-1773 ]
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                https://bitbucket.org/nzahara/genoviz-sdk-local/branch/IGBF-1800#diff - Code change

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - https://bitbucket.org/nzahara/genoviz-sdk-local/branch/IGBF-1800#diff - Code change
                noor91zahara Noor Zahara (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                ann.loraine Ann Loraine made changes -
                Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
                ann.loraine Ann Loraine made changes -
                Assignee Noor Zahara [ noor91zahara ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Needs 1st Level Review [ 10005 ]
                ann.loraine Ann Loraine made changes -
                Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
                ann.loraine Ann Loraine made changes -
                Assignee Noor Zahara [ noor91zahara ] Ann Loraine [ aloraine ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                To make review easier:

                • Set up bitbucket pipeline on your fork to build genoviz jars
                • Provide testing instructions as comments here (Explain what has changed.)
                Show
                ann.loraine Ann Loraine added a comment - - edited To make review easier: Set up bitbucket pipeline on your fork to build genoviz jars Provide testing instructions as comments here (Explain what has changed.)
                ann.loraine Ann Loraine made changes -
                Assignee Ann Loraine [ aloraine ] Noor Zahara [ noor91zahara ]
                ann.loraine Ann Loraine made changes -
                Status Reviewing [ 10301 ] Open [ 1 ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-1798 [ IGBF-1798 ]
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                [~aloraine]

                I have made the pipeline set up on my fork.

                Changes made: Added git commit plugin to genoviz_sdk pom file.
                Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] I have made the pipeline set up on my fork. Changes made: Added git commit plugin to genoviz_sdk pom file. Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Can you provide some additional explanation for:

                "Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder."

                Show
                ann.loraine Ann Loraine added a comment - Can you provide some additional explanation for: "Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder."
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                1. Build genoviz project and deploy it on nexus maven repositories.
                2. Genoviz jar is injected as a dependency in IGB Project through pom.xml.
                3. When IGB is built, the genovize bundle should contain the git.properties file.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - 1. Build genoviz project and deploy it on nexus maven repositories. 2. Genoviz jar is injected as a dependency in IGB Project through pom.xml. 3. When IGB is built, the genovize bundle should contain the git.properties file.
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Open [ 1 ] Needs 1st Level Review [ 10005 ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ] Ann Loraine [ aloraine ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Ann Loraine [ aloraine ] Noor Zahara [ noor91zahara ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                ann.loraine Ann Loraine made changes -
                Sprint Summer 2019 Sprint 8 [ 67 ] Summer 2019 Sprint 8, Summer 2019 Sprint 9 [ 67, 68 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                See related issue IGBF-1798 for instructions if above is not clear. Please note: we want the file to appear in the jar that is build off the master branch of Genoviz project. This project is version-controlled in the Loraine Lab bitbucket team account.

                Show
                ann.loraine Ann Loraine added a comment - See related issue IGBF-1798 for instructions if above is not clear. Please note: we want the file to appear in the jar that is build off the master branch of Genoviz project. This project is version-controlled in the Loraine Lab bitbucket team account.
                ann.loraine Ann Loraine made changes -
                Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
                svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
                Hide
                Permalink
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

                git.properties file is added to the jar. Everything is working as expected.
                You may proceed to submit the pull request. Noor Zahara

                Show
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - git.properties file is added to the jar. Everything is working as expected. You may proceed to submit the pull request. Noor Zahara
                svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
                Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
                svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
                Assignee Sai Charan Reddy Vallapureddy [ svallapu ] Noor Zahara [ noor91zahara ]
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Pull Request submitted :

                https://bitbucket.org/lorainelab/genoviz-sdk/pull-requests/14/igbf-1800/diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Pull Request submitted : https://bitbucket.org/lorainelab/genoviz-sdk/pull-requests/14/igbf-1800/diff
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged to master but not yet deployed on nexus.
                [~aloraine] needs to deploy the artifact to nexus repository.

                Show
                ann.loraine Ann Loraine added a comment - Merged to master but not yet deployed on nexus. [~aloraine] needs to deploy the artifact to nexus repository.
                ann.loraine Ann Loraine made changes -
                Assignee Noor Zahara [ noor91zahara ] Ann Loraine [ aloraine ]
                ann.loraine Ann Loraine made changes -
                Assignee Ann Loraine [ aloraine ]
                ann.loraine Ann Loraine made changes -
                Sprint Summer 2019 Sprint 8, Summer 2019 Sprint 9 [ 67, 68 ] Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10 [ 67, 68, 69 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Shamika Gajanan Kulkarni [ shamika ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                git.properties file is not added to jar. Tested the master branch. Assigning the ticket back to Noor. Kindly check.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - git.properties file is not added to jar. Tested the master branch. Assigning the ticket back to Noor. Kindly check.
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Shamika Gajanan Kulkarni [ shamika ] Noor Zahara [ noor91zahara ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Status Testing In Progress [ 10003 ] Open [ 1 ]
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Fix the issue
                Code change can be viewed
                https://bitbucket.org/nzahara/genoviz-sdk-local/commits/94b31630a09d5f6cd652eb227e763a8e22df6024

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Fix the issue Code change can be viewed https://bitbucket.org/nzahara/genoviz-sdk-local/commits/94b31630a09d5f6cd652eb227e763a8e22df6024
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Open [ 1 ] Needs 1st Level Review [ 10005 ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Shamika Gajanan Kulkarni [ shamika ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                The code has been reviewed and git.properties file has been added to the jar. Kindly submit a pull request for the same.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The code has been reviewed and git.properties file has been added to the jar. Kindly submit a pull request for the same.
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Shamika Gajanan Kulkarni [ shamika ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Pull request merged.
                This should trigger a new build of master branch for Genoviz SDK repository, with jar file copied to downloads section.
                Shamika Gajanan Kulkarni please review.
                If it looks good, please assign to [~aloraine] to deploy new jar file on our Nexus maven repository.

                Show
                ann.loraine Ann Loraine added a comment - Pull request merged. This should trigger a new build of master branch for Genoviz SDK repository, with jar file copied to downloads section. Shamika Gajanan Kulkarni please review. If it looks good, please assign to [~aloraine] to deploy new jar file on our Nexus maven repository.
                ann.loraine Ann Loraine made changes -
                Status Needs Testing [ 10002 ] Needs Testing [ 10002 ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ] Shamika Gajanan Kulkarni [ shamika ]
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

                I have reviewed this ticket and the jar contains the git.properties file. It is working as expected. Assigning it to Dr. Loraine for deployment on Nexus maven repository.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited I have reviewed this ticket and the jar contains the git.properties file. It is working as expected. Assigning it to Dr. Loraine for deployment on Nexus maven repository.
                shamika Shamika Gajanan Kulkarni (Inactive) made changes -
                Assignee Shamika Gajanan Kulkarni [ shamika ] Ann Loraine [ aloraine ]
                ann.loraine Ann Loraine made changes -
                Sprint Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10 [ 67, 68, 69 ] Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 67, 68, 69, 70 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                ann.loraine Ann Loraine made changes -
                Sprint Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 67, 68, 69, 70 ] Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11, Summer 2019 Sprint 12 [ 67, 68, 69, 70, 71 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Modified bitbucket pipeline YML to use the new Docker image, built, and deployed on our Nexus repository.

                Show
                ann.loraine Ann Loraine added a comment - Modified bitbucket pipeline YML to use the new Docker image, built, and deployed on our Nexus repository.
                ann.loraine Ann Loraine made changes -
                Resolution Done [ 10000 ]
                Status Testing In Progress [ 10003 ] Closed [ 6 ]
                ann.loraine Ann Loraine made changes -
                Workflow Loraine Lab Workflow [ 18522 ] Fall 2019 Workflow Update [ 20215 ]
                ann.loraine Ann Loraine made changes -
                Workflow Fall 2019 Workflow Update [ 20215 ] Revised Fall 2019 Workflow Update [ 22353 ]

                  People

                  • Assignee:
                    ann.loraine Ann Loraine
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: