Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1800

Include git properties in Genoviz SDK jar

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      0.25
    • Sprint:
      Summer 2019 Sprint 8, Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11, Summer 2019 Sprint 12

      Description

      Include git properties file in Genoviz SDK bundle to enable better artifact tracking for developers.

        Attachments

          Issue Links

            Activity

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - https://bitbucket.org/nzahara/genoviz-sdk-local/branch/IGBF-1800#diff - Code change
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            To make review easier:

            • Set up bitbucket pipeline on your fork to build genoviz jars
            • Provide testing instructions as comments here (Explain what has changed.)
            Show
            ann.loraine Ann Loraine added a comment - - edited To make review easier: Set up bitbucket pipeline on your fork to build genoviz jars Provide testing instructions as comments here (Explain what has changed.)
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            [~aloraine]

            I have made the pipeline set up on my fork.

            Changes made: Added git commit plugin to genoviz_sdk pom file.
            Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] I have made the pipeline set up on my fork. Changes made: Added git commit plugin to genoviz_sdk pom file. Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder.
            Hide
            ann.loraine Ann Loraine added a comment -

            Can you provide some additional explanation for:

            "Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder."

            Show
            ann.loraine Ann Loraine added a comment - Can you provide some additional explanation for: "Once the jar is built and pushed to nexus , git.properties file should appear in the genoviz jar under bundles folder."
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            1. Build genoviz project and deploy it on nexus maven repositories.
            2. Genoviz jar is injected as a dependency in IGB Project through pom.xml.
            3. When IGB is built, the genovize bundle should contain the git.properties file.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - 1. Build genoviz project and deploy it on nexus maven repositories. 2. Genoviz jar is injected as a dependency in IGB Project through pom.xml. 3. When IGB is built, the genovize bundle should contain the git.properties file.
            Hide
            ann.loraine Ann Loraine added a comment -

            See related issue IGBF-1798 for instructions if above is not clear. Please note: we want the file to appear in the jar that is build off the master branch of Genoviz project. This project is version-controlled in the Loraine Lab bitbucket team account.

            Show
            ann.loraine Ann Loraine added a comment - See related issue IGBF-1798 for instructions if above is not clear. Please note: we want the file to appear in the jar that is build off the master branch of Genoviz project. This project is version-controlled in the Loraine Lab bitbucket team account.
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            git.properties file is added to the jar. Everything is working as expected.
            You may proceed to submit the pull request. Noor Zahara

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - git.properties file is added to the jar. Everything is working as expected. You may proceed to submit the pull request. Noor Zahara
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Pull Request submitted : https://bitbucket.org/lorainelab/genoviz-sdk/pull-requests/14/igbf-1800/diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged to master but not yet deployed on nexus.
            [~aloraine] needs to deploy the artifact to nexus repository.

            Show
            ann.loraine Ann Loraine added a comment - Merged to master but not yet deployed on nexus. [~aloraine] needs to deploy the artifact to nexus repository.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            git.properties file is not added to jar. Tested the master branch. Assigning the ticket back to Noor. Kindly check.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - git.properties file is not added to jar. Tested the master branch. Assigning the ticket back to Noor. Kindly check.
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Fix the issue Code change can be viewed https://bitbucket.org/nzahara/genoviz-sdk-local/commits/94b31630a09d5f6cd652eb227e763a8e22df6024
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            The code has been reviewed and git.properties file has been added to the jar. Kindly submit a pull request for the same.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The code has been reviewed and git.properties file has been added to the jar. Kindly submit a pull request for the same.
            Hide
            ann.loraine Ann Loraine added a comment -

            Pull request merged.
            This should trigger a new build of master branch for Genoviz SDK repository, with jar file copied to downloads section.
            Shamika Gajanan Kulkarni please review.
            If it looks good, please assign to [~aloraine] to deploy new jar file on our Nexus maven repository.

            Show
            ann.loraine Ann Loraine added a comment - Pull request merged. This should trigger a new build of master branch for Genoviz SDK repository, with jar file copied to downloads section. Shamika Gajanan Kulkarni please review. If it looks good, please assign to [~aloraine] to deploy new jar file on our Nexus maven repository.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

            I have reviewed this ticket and the jar contains the git.properties file. It is working as expected. Assigning it to Dr. Loraine for deployment on Nexus maven repository.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited I have reviewed this ticket and the jar contains the git.properties file. It is working as expected. Assigning it to Dr. Loraine for deployment on Nexus maven repository.
            Hide
            ann.loraine Ann Loraine added a comment -

            Modified bitbucket pipeline YML to use the new Docker image, built, and deployed on our Nexus repository.

            Show
            ann.loraine Ann Loraine added a comment - Modified bitbucket pipeline YML to use the new Docker image, built, and deployed on our Nexus repository.

              People

              • Assignee:
                ann.loraine Ann Loraine
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: