Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.0 Major Release
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Summer 2019 Sprint 9, Summer 2019 Sprint 10
Description
Currently, if you add a new app repository (using the app manager GUI) and include a final trailing slash (or other path separator) the app repository is not recognized.
Let's modify this so that a user can add a new repository with or without the trailing file separator.
Also, be aware that users (developers) can add repositories as local folders or on-line as Internet sites.
(When starting, consult Shamika who is familiar with the details. You can use her App download sites for testing.)
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Status | Open [ 1 ] | Open [ 1 ] |
| Assignee | Ann Loraine [ aloraine ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
I'm not sure this will work as expected on platforms that are using a different file path separator. Remember that App repositories can be local or remote.
Instead of hard-coding the "/" character, could you find a way to generalize. In a lot of languages, there's a global constant representing the system file path separator. I'm pretty sure there is something like that in Java – please investigate.
This change will need to be tested in Windows, Mac, and Linux with local repos as well as when using a remote repository served from the Internet.
| Status | Needs 1st Level Review [ 10005 ] | Open [ 1 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Sprint | Summer 2019 Sprint 9 [ 68 ] | Summer 2019 Sprint 9, Summer 2019 Sprint 10 [ 68, 69 ] |
| Rank | Ranked higher |
Yes I shall look into it.
I have tested this on Windows for both local as well as a remote repository. Initially the code had the variable "REPOSITORY_XML_FILE_PATH" along with the path separator "/repository.xml". Since it was already in the variable, I separated it into conditions. But it is a really good point to have it generalized and I shall work on it and also test it on Mac as well as Linux. Thank you for letting me know.
| Status | Open [ 1 ] | In Progress [ 3 ] |
As discussed with Professor, adding a generalized variable for path separator, i.e. File.separator removes consistency in URLs. On Windows platform, the File.separator picks up "\" character, which should not be present for URLs. Also, since the method where these changes are made is used for URLs, hard-coding "/" character seems to be a working approach.
The code which includes hard-coding of "/" character has been successfully tested on Windows, Linux and Mac along with local as well as remote repositories. Kindly review.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Needs 1st Level Review [ 10005 ] | Ready for Pull Request [ 10304 ] |
Ok thanks! Moving this to "ready for pull request" column.
| Status | Ready for Pull Request [ 10304 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Thank you for reviewing Professor. The pull request for the same has been submitted. The link is as follows:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/707/igbf-1846/diff
I have re-submitted the pull request. The link is as follows:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/708/igbf-1846/diff
Kindly review and let me know if any changes are required to be made. Thank you.
Kindly review the re-submitted pull request as follows:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/709/igbf-1846/diff
I have recreated the branch as suggested by Professor.
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Working as expected.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Shamika Gajanan Kulkarni [ shamika ] |
| Workflow | Loraine Lab Workflow [ 18568 ] | Fall 2019 Workflow Update [ 20251 ] |
| Workflow | Fall 2019 Workflow Update [ 20251 ] | Revised Fall 2019 Workflow Update [ 22392 ] |
The code changes are present here :
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-1846#diff
This should enable users to add repositories with or without a trailing path separator in the URL for the Downloads section of each optional plugin repository.
Kindly review.