Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1898

Add email popup related issues - close button and error message

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          1
        • Sprint:
          Summer 2019 Sprint 10, Summer 2019 Sprint 11

          Description

          1. In editing options of the app, I was unable to add email addresses which were not registered with AppStore. Got the error saying "Email is invalid. This is correct. But "email is invalid" message is misleading as one can understand it as - the format of email is wrong. It can be something more informative, something like - "Editor email should be a registered user". Also the popup of "add email" does not close after an "invalid" email is entered.

          2. I was also not able to close the "add email" pop-up after I entered unregistered emails by clicking on the close button. Please fix this minor issue.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-1860 Test App Store workflow

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Code changes are as below

                https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1898#diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Code changes are as below https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1898#diff
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Can be merged to master.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Can be merged to master.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment - - edited

                Pull Request submitted
                https://bitbucket.org/lorainelab/appstore/pull-requests/74/igbf-1898-fix-editor-email-error-message/diff

                [~aloraine] - Could you merge these changes to master?

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - - edited Pull Request submitted https://bitbucket.org/lorainelab/appstore/pull-requests/74/igbf-1898-fix-editor-email-error-message/diff [~aloraine] - Could you merge these changes to master?
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged to master but not yet deployed to testappstore.bioviz.org

                Show
                ann.loraine Ann Loraine added a comment - Merged to master but not yet deployed to testappstore.bioviz.org
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Working as expected. Moving it to done.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Working as expected. Moving it to done.

                  People

                  • Assignee:
                    noor91zahara Noor Zahara (Inactive)
                    Reporter:
                    stiwari8 Srishti Tiwari (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: