Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1898

Add email popup related issues - close button and error message

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          1
        • Sprint:
          Summer 2019 Sprint 10, Summer 2019 Sprint 11

          Description

          1. In editing options of the app, I was unable to add email addresses which were not registered with AppStore. Got the error saying "Email is invalid. This is correct. But "email is invalid" message is misleading as one can understand it as - the format of email is wrong. It can be something more informative, something like - "Editor email should be a registered user". Also the popup of "add email" does not close after an "invalid" email is entered.

          2. I was also not able to close the "add email" pop-up after I entered unregistered emails by clicking on the close button. Please fix this minor issue.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-1860 Test App Store workflow

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                stiwari8 Srishti Tiwari (Inactive) created issue -
                stiwari8 Srishti Tiwari (Inactive) made changes -
                Field Original Value New Value
                Link This issue relates to IGBF-1860 [ IGBF-1860 ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Assignee Noor Zahara [ noor91zahara ]
                noor91zahara Noor Zahara (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                ann.loraine Ann Loraine made changes -
                Sprint Summer 2019 Sprint 10 [ 69 ] Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 69, 70 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Code changes are as below

                https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1898#diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Code changes are as below https://bitbucket.org/nzahara/appstore-local/branch/IGBF-1898#diff
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Can be merged to master.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Can be merged to master.
                sameer Sameer Shanbhag (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ]
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment - - edited

                Pull Request submitted
                https://bitbucket.org/lorainelab/appstore/pull-requests/74/igbf-1898-fix-editor-email-error-message/diff

                [~aloraine] - Could you merge these changes to master?

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - - edited Pull Request submitted https://bitbucket.org/lorainelab/appstore/pull-requests/74/igbf-1898-fix-editor-email-error-message/diff [~aloraine] - Could you merge these changes to master?
                noor91zahara Noor Zahara (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Pull Request Submitted [ 10101 ] In Progress [ 3 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged to master but not yet deployed to testappstore.bioviz.org

                Show
                ann.loraine Ann Loraine added a comment - Merged to master but not yet deployed to testappstore.bioviz.org
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Working as expected. Moving it to done.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Working as expected. Moving it to done.
                sameer Sameer Shanbhag (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Resolution Done [ 10000 ]
                Status Testing In Progress [ 10003 ] Closed [ 6 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ] Noor Zahara [ noor91zahara ]
                ann.loraine Ann Loraine made changes -
                Workflow Loraine Lab Workflow [ 18621 ] Fall 2019 Workflow Update [ 20283 ]
                ann.loraine Ann Loraine made changes -
                Workflow Fall 2019 Workflow Update [ 20283 ] Revised Fall 2019 Workflow Update [ 22431 ]

                  People

                  • Assignee:
                    noor91zahara Noor Zahara (Inactive)
                    Reporter:
                    stiwari8 Srishti Tiwari (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: