Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1948

Investigate AffxFusion jar - can we remove from project?

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      We would like to simplify the project and remove legacy maven repositories repo1, repo2, repo3 from 9.1.0 top-level parent POM and all child POMs.
      As per comments below, Prutha Kulkarni learned that this cannot safely be done without removing some dependencies provided by these legacy repositories.

      To test:

      • Ensure that all maven profiles can run
      • Check that default and clean lifecycles can run up to and including "install" phase

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1531 [ 17617 ]
            ann.loraine Ann Loraine made changes -
            Link This issue is blocked by IGBF-1949 [ IGBF-1949 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Assignee Prutha Kulkarni [ prutha ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            [~aloraine], I have tried to build IGB project after removing these legacy maven repos from the POM.
            Build was failing for affymetrix common and was asking for missing dependency jlgfr. I commented it from the POM and it was built successfully.
            After that, it was failing for genometry module because com.affymetrix:fusion dependency. It is being used in the module and its not there in nexus.bioviz.org.
            Please let me know if there is any other repository location which can be referred in the POM?

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - [~aloraine] , I have tried to build IGB project after removing these legacy maven repos from the POM. Build was failing for affymetrix common and was asking for missing dependency jlgfr. I commented it from the POM and it was built successfully. After that, it was failing for genometry module because com.affymetrix:fusion dependency. It is being used in the module and its not there in nexus.bioviz.org. Please let me know if there is any other repository location which can be referred in the POM?
            Hide
            ann.loraine Ann Loraine added a comment -

            For the next steps, can you do this?

            • investigate "affymetrix fusion" - where is the source code? What packages/classes are being used, and where? We may be able to eliminate it. (If the source code is not available, we should write it out of the project.)
            • investigate: what is jlgfr ? Same as above.
            Show
            ann.loraine Ann Loraine added a comment - For the next steps, can you do this? investigate "affymetrix fusion" - where is the source code? What packages/classes are being used, and where? We may be able to eliminate it. (If the source code is not available, we should write it out of the project.) investigate: what is jlgfr ? Same as above.
            Hide
            ann.loraine Ann Loraine added a comment -

            Feel free to make these tasks two new Jira tickets - as you see fit.

            Show
            ann.loraine Ann Loraine added a comment - Feel free to make these tasks two new Jira tickets - as you see fit.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            affymetrix fusion -
            1) Its is being used in two files under genometry module.
            comaprator/QuantByIntIdComparator
            comparator/QuantDetectByIntIdComparator
            package used : affymetrix.calvin.data
            2)The source code is present at :
            https://github.com/HenrikBengtsson/Affx-Fusion-SDK/tree/master/affy/sdk/java/AffxFusion

            jlfgr-
            I am not able to locate the source code but it has something to do with the icons in IGB.
            Its a java look and feel Graphics repository dependency.
            Also, in the NOTICES.txt file it is mentioned that " IGB can be used with or without this jar file.".
            So, I am not sure if that is necessary.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - affymetrix fusion - 1) Its is being used in two files under genometry module. comaprator/QuantByIntIdComparator comparator/QuantDetectByIntIdComparator package used : affymetrix.calvin.data 2)The source code is present at : https://github.com/HenrikBengtsson/Affx-Fusion-SDK/tree/master/affy/sdk/java/AffxFusion jlfgr- I am not able to locate the source code but it has something to do with the icons in IGB. Its a java look and feel Graphics repository dependency. Also, in the NOTICES.txt file it is mentioned that " IGB can be used with or without this jar file.". So, I am not sure if that is necessary.
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18672 ] Fall 2019 Workflow Update [ 19079 ]
            ann.loraine Ann Loraine made changes -
            Link This issue is blocked by IGBF-1949 [ IGBF-1949 ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Changing scope of this ticket: please remove reference to AffxFusion jar on a topic branch named for this Jira ticket - IGBF-1948.

            We will remove the other dependencies as part of other Jira issues.

            Show
            ann.loraine Ann Loraine added a comment - - edited Changing scope of this ticket: please remove reference to AffxFusion jar on a topic branch named for this Jira ticket - IGBF-1948 . We will remove the other dependencies as part of other Jira issues.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Summary Remove legacy maven repos from 9.1.0 pom Remove AffxFusion jar from project
            ann.loraine Ann Loraine made changes -
            Description To simplify POM for IGB project, remove repo1, repo2, repo3 from 9.1.0 top-level parent POM and all child POMs.

            Do this after releasing new version of markdown encoder plugin. See linked issue.

            To test:

            * Ensure that all maven profiles can run
            * Check that default and clean lifecycles can run up to and including "install" phase
            We would like to simplify the project and remove legacy maven repositories repo1, repo2, repo3 from 9.1.0 top-level parent POM and all child POMs.
            As per comments below, [~prutha] learned that this cannot safely be done without removing some dependencies provided by these legacy repositories.

            To test:

            * Ensure that all maven profiles can run
            * Check that default and clean lifecycles can run up to and including "install" phase
            ann.loraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 2019 Sprint 1 [ 72 ] Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 72, 73 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            Prof. [~aloraine], I have removed AffxFusion dependency from everywhere except igb module.
            It used in the "ChpParser" file of the Parsers directory of igb module which is used in "getGenome" function of "QuickLoadSymLoaderChp" class. This getGenome function is used almost everywhere in IGB codebase. I am not sure if we can remove this dependency.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Prof. [~aloraine] , I have removed AffxFusion dependency from everywhere except igb module. It used in the "ChpParser" file of the Parsers directory of igb module which is used in "getGenome" function of "QuickLoadSymLoaderChp" class. This getGenome function is used almost everywhere in IGB codebase. I am not sure if we can remove this dependency.
            prutha Prutha Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Thanks Prutha Kulkarni!

            For the next step, can you do this?

            Add a new comment that all functions coming from the AffxFusion artifact that are used in IGB code base?

            Please list:

            • function name - name of function in AffxFusion
            • class name - class where the function is implemented
            • package - package (in AffxFusion) where the class resides

            When done, move this to Needs First Level Review.

            Show
            ann.loraine Ann Loraine added a comment - Thanks Prutha Kulkarni ! For the next step, can you do this? Add a new comment that all functions coming from the AffxFusion artifact that are used in IGB code base? Please list: function name - name of function in AffxFusion class name - class where the function is implemented package - package (in AffxFusion) where the class resides When done, move this to Needs First Level Review.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            package is common for all which is "affymetrix.fusion.chp"
            List of classes and function used is given below:
            1) class: FusionCHPData
            function name: getHeader, getExpressionResults
            2) class: FusionCHPDataReg
            function name: read
            3) class: FusionCHPGenericData
            function name: fromBase
            4) class: FusionCHPHeader
            function name: getAlgName, getAlgVersion, getAssayType, getChipType, getRows, getCols, getParentCellFile, getProgID, getNumProbeSets
            5) class: FusionCHPLegacyData
            function name: registerReader
            6) class: FusionCHPQuantificationData
            function name: registerReader
            7) class: FusionCHPQuantificationDetectionData
            function name: registerReader
            8) class: FusionCHPTilingData
            function name: registerReader
            9) class: FusionExpressionProbeSetResults
            function name: getDetectionPValue, getSignal, clear

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - package is common for all which is "affymetrix.fusion.chp" List of classes and function used is given below: 1) class: FusionCHPData function name: getHeader, getExpressionResults 2) class: FusionCHPDataReg function name: read 3) class: FusionCHPGenericData function name: fromBase 4) class: FusionCHPHeader function name: getAlgName, getAlgVersion, getAssayType, getChipType, getRows, getCols, getParentCellFile, getProgID, getNumProbeSets 5) class: FusionCHPLegacyData function name: registerReader 6) class: FusionCHPQuantificationData function name: registerReader 7) class: FusionCHPQuantificationDetectionData function name: registerReader 8) class: FusionCHPTilingData function name: registerReader 9) class: FusionExpressionProbeSetResults function name: getDetectionPValue, getSignal, clear
            prutha Prutha Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Assignee Prutha Kulkarni [ prutha ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 72, 73 ] Fall 2019 Sprint 1, Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 72, 73, 74 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Use of affx jar is documented above. Moving to Closed.

            Show
            ann.loraine Ann Loraine added a comment - Use of affx jar is documented above. Moving to Closed.
            ann.loraine Ann Loraine made changes -
            Summary Remove AffxFusion jar from project Investigate AffxFusion jar - can we remove from project?
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-2052 [ IGBF-2052 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 19079 ] Revised Fall 2019 Workflow Update [ 22463 ]
            ann.loraine Ann Loraine made changes -
            Fix Version/s 9.1.0 Major Release [ 10601 ]
            ann.loraine Ann Loraine made changes -
            Assignee Prutha Kulkarni [ prutha ]

              People

              • Assignee:
                prutha Prutha Kulkarni (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: