Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1956

Stop printing repository.xml to log when something goes wrong

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Latest master branch prints entire repository.xml read from user's uploaded jar to the django log file.

      It is not clear if this happening because there is a problem or if this is just left over from development.

      Please review all code in app module and remove all unnecessary print statements that increase the log size for no benefit.

        Attachments

          Activity

          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 19016 ] Revised Fall 2019 Workflow Update [ 22470 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          No able to reproduce this problem.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - No able to reproduce this problem.
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Open [ 1 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Summer 2019 Sprint 12, Fall 2019 Sprint 1 [ 71, 72 ] Summer 2019 Sprint 12, Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 71, 72, 73 ]
          ann.loraine Ann Loraine made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          ann.loraine Ann Loraine made changes -
          Workflow Loraine Lab Workflow [ 18680 ] Fall 2019 Workflow Update [ 19016 ]
          ann.loraine Ann Loraine made changes -
          Summary Stop printing repository.xml to log Stop printing repository.xml to log when something goes wrong
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Summer 2019 Sprint 12 [ 71 ] Summer 2019 Sprint 12, Fall 2019 Sprint 1 [ 71, 72 ]
          ann.loraine Ann Loraine made changes -
          Assignee Sameer Shanbhag [ sameer ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] Open [ 1 ]
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          To see the behavior, check what happens when submitting a jar file causes an error. Observe that the repository.xml is getting printed to the log file.

          Show
          ann.loraine Ann Loraine added a comment - - edited To see the behavior, check what happens when submitting a jar file causes an error. Observe that the repository.xml is getting printed to the log file.
          Hide
          ann.loraine Ann Loraine added a comment -

          This happened when I tried to submit an App jar file to the alpha App Store.

          Show
          ann.loraine Ann Loraine added a comment - This happened when I tried to submit an App jar file to the alpha App Store.
          sameer Sameer Shanbhag (Inactive) made changes -
          Assignee Sameer Shanbhag [ sameer ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          I cannot see anything printed in the log file. I tired to do the following

          ~Command : tail -f debug.log
          1. Go to http://testappstore.bioviz.org/obr/releases/repository.xml
          2. Check if the repository content is printed [Was not printed]
          3. Add A new application. Accept the application and check the log file [Not printed in this process as well]

          I guess there were some test changes on the testappstore earlier which was causing that and is fixed now.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - I cannot see anything printed in the log file. I tired to do the following ~Command : tail -f debug.log 1. Go to http://testappstore.bioviz.org/obr/releases/repository.xml 2. Check if the repository content is printed [Was not printed] 3. Add A new application. Accept the application and check the log file [Not printed in this process as well] I guess there were some test changes on the testappstore earlier which was causing that and is fixed now.
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Sprint Summer 2019 Sprint 12 [ 71 ]
          ann.loraine Ann Loraine made changes -
          Status Open [ 1 ] Open [ 1 ]
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-1388 [ 17463 ]
          ann.loraine Ann Loraine created issue -

            People

            • Assignee:
              sameer Sameer Shanbhag (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: