Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.0 Major Release
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov
Description
BookMark project is compiling successfully but shows errors in the NetBeans editor.
Tried to add necessary dependencies to pom.xml but it still shows errors in Netbeans editor.
Attachments
Issue Links
- relates to
-
IGBF-1977 Remove unneeded logging and println statements from tests
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Workflow | Loraine Lab Workflow [ 18705 ] | Fall 2019 Workflow Update [ 19025 ] |
| Epic Link | IGBF-1531 [ 17617 ] |
| Fix Version/s | 9.1.0 Major Release [ 10601 ] | |
| Story Points | 2 | |
| Sprint | Fall 2019 Sprint 1 [ 72 ] | Fall 2019 Sprint 2 [ 73 ] |
| Labels | Beginner | Intermediate |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Story Points | 2 | 1 |
| Priority | Major [ 3 ] | Minor [ 4 ] |
| Summary | Errors in BookMarkTest.java (BookMark Plugin) | Investigate and fix test errors in BookMarkTest.java (BookMark Plugin) |
| Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
| Rank | Ranked higher |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
[~aloraine]
To reproduce
go to below file location (I have tested this in Netbeans)
plugins/Bookmark/src/test/com/affymetrix/igb/bookmarks/BookMarkTest.java
When I opened the file, it shows errors in the IDE but it builds without any issues. (Maybe a dependency problem or IDE?)
I have attached a screenshot of BookMarkTest.java for reference.
| Attachment | igbf-1981.JPG [ 14405 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
I think that IGB builds without any issues maybe because BookMarkTest.java is a Test class. Kindly correct me if I am wrong.
I found out that the plugin for "junit" was missing in the pom.xml for Bookmark and I have added the plugin and also an import statement. Now it shows no errors on my IDE. I am attaching a screenshot for the same. The code changes are present in the link below. Kindly review.
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-1981#diff
| Attachment | IGBF-1981-no errors.JPG [ 14424 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Follow-up question for Shamika Gajanan Kulkarni:
- Does the test execute during the build?
(I think it will, based on your changes, but we should check.)
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3 [ 73, 74 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 73, 74, 75 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Rank | Ranked lower |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct [ 73, 74, 75 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 73, 74, 75, 76 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Workflow | Fall 2019 Workflow Update [ 19025 ] | Revised Fall 2019 Workflow Update [ 21193 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
The BookMarkTest.java was not executing during the build since the java file was not in the java folder and hence maven could not find the test class. When corrected, the test file runs successfully without any problem. The changes are present in the link below:
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-1981#diff
Also, we had a discussion once that all the test cases need to be verified and so, I tried running all the test cases which are skipped during the build and found out that some test cases fail while others run successfully. I was trying to dig a little deeper into the ones failing and was thinking should we fix them or skip them just the way they are being skipped right now. Kindly let me know what should be done. For now, moving this ticket to Needs First Level review.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Sorry, I am little bit confused. Do you mean you moved the file with test cases (add-the-rate Test annotation) into the "test" folder? If yes, that is correct. If you do that, then maven will locate the tests and run them during the default lifecycle. Also, your addition to the pom will ensure they can run, since they depend on junit. If there are other "Test" files under the "main" folder, then they should also be moved to "test".
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Actually they were in the Test folder but not under Java. Maven locates the test sources under "src/test/java", and the path in our IGB project for BookMarkTest.java was "src/test/com/..." I just moved the file to "src/test/java/com...". This way, maven could locate and run the test file. Sorry for not being clear about this earlier.
Yes I have checked for the notations and this was the only test class in BookMarks plugin.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 73, 74, 75, 76 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov [ 73, 74, 75, 76, 77 ] |
| Rank | Ranked higher |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Shamika Gajanan Kulkarni, I've tested your version of BookMarkTest.java in netbeans and it is not showing any errors now. Also, when I tried to build it, it is not throwing any exceptions.
Moving it to DONE.
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Prutha Kulkarni [ prutha ] | Shamika Gajanan Kulkarni [ shamika ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Please provide steps on how to reproduce this. Also please describe what the bug looks like – maybe a stack trace?