Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar
Description
AppStore codebase contains code that is not being used.
Remove it.
Attachments
Issue Links
- blocks
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Please review branch:
https://bitbucket.org/aloraine/appstore/branch/IGBF-1994-BigDelete
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Description |
AppStore codebase contains code that is not being used.
Remove it. Document what's left. |
AppStore codebase contains code that is not being used.
Remove it. |
| Summary | Remove un-needed code and document what is left | Remove un-needed code |
| Summary | Remove un-needed code | Remove un-needed code - API and App dependencies |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
App store functionality is working fine even after removing the following things:
1) javadocs, API, previously commented code
2) Unneeded code, templates for submitting APIs, parsing POMs
3) App logos
Moving the ticket to DONE.
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 20751 ] | Revised Fall 2019 Workflow Update [ 22500 ] |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
There is still some vestigial code related to API bundles that causes a server error when a user tries to submit a bundle that contains export tags.
See: https://jira.transvar.org/browse/IGBF-2238
| Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb [ 73, 86 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | To-Do [ 10305 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Changes to IGBF-2238 can be found here:
https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/13aa8ee0392365a788329a7f769638ede8546c96
Prof. [~aloraine] Please let me know if I have to get rid of the Export-Package parsing logic as well. The above commit solves the Internal Server Error.
Please do this on a different branch named for IGBF-1994
I have named the new branch as IGBF-1994-1 Commit can be fund here:
https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/28aafec4c4b143d6efd0811d5f8efc8f15080173
P.S. [~aloraine]
Please submit PR for IGBF-1994-1
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Because the branch had some other edits, I copied over the relevant code from Sameer's branch and added it directly the master branch.
See:
https://bitbucket.org/lorainelab/appstore/commits/8f49e256a17506b8019c52648aa8f55512d67130
The fix is now part of the master branch but is not yet deployed on dev-appstore-2.
| Sprint | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb [ 73, 86 ] | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 73, 86, 87 ] |
| Rank | Ranked higher |
FYI: master branch deployed on dev-appstore-2 up to and including these commits:
9db2675 (HEAD -> master, origin/master, origin/HEAD) Merged in IGBF-2231 (pull request #210)
f5753c0 IGBF-2231 : Remove old search logic | Xapian Search
daadc80 IGBF-2231 : Remove unnecessary line of codes and organizing file imports
bf6733a IGBF-2231 : Remove support for Geological Tracking
| Sprint | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb [ 73, 86, 87 ] | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 73, 86, 87, 89 ] |
| Rank | Ranked higher |
| Sprint | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 73, 86, 87, 89 ] | Fall 2019 Sprint 2, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 73, 86, 87, 89, 90 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Working as expected.
| Assignee | Noor Zahara [ noor91zahara ] | Sameer Shanbhag [ sameer ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Remove: