Details
-
Type: Improvement
-
Status: Closed (View Workflow)
-
Priority: Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3
Description
- Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
- Remove the name variable as it will no longer be used and Bundle_Name will be used instead, but only in user-facing places
Attachments
Activity
Riddhi Jagdish Patil (Inactive)
created issue -
Riddhi Jagdish Patil (Inactive)
made changes -
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Ann Loraine [ aloraine ] | Riddhi Jagdish Patil [ rpatil14 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Status | Open [ 1 ] | To-Do [ 10305 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Sprint | Fall 2019 Sprint 2 [ 73 ] |
Ann Loraine
made changes -
Summary | Rename fullname variable to bundle_name and remove name variable | Rename fullname variable to Bundle_Name and remove name variable |
Ann Loraine
made changes -
Description |
* Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-Name of MANIFEST.MF file
* Remove the name variable as it will no longer be used and bundle_name will be used instead |
* Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
* Remove the name variable as it will no longer be used and bundle_name will be used instead |
Ann Loraine
made changes -
Description |
* Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
* Remove the name variable as it will no longer be used and bundle_name will be used instead |
* Refactor the app store code base to rename the fullname variable to bundle_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
* Remove the name variable as it will no longer be used and Bundle_Name will be used instead, but only in user-facing places |
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Sameer Shanbhag [ sameer ] |
Sameer Shanbhag (Inactive)
made changes -
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Ann Loraine
made changes -
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Ann Loraine
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Ann Loraine
made changes -
Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Ann Loraine
made changes -
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Ann Loraine
made changes -
Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Ann Loraine
made changes -
Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Ann Loraine
made changes -
Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
Ann Loraine
made changes -
Rank | Ranked higher |
Ann Loraine
made changes -
Assignee | Sameer Shanbhag [ sameer ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Resolution | Done [ 10000 ] | |
Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Riddhi Jagdish Patil (Inactive)
made changes -
Assignee | Sameer Shanbhag [ sameer ] |
Ann Loraine
made changes -
Workflow | Fall 2019 Workflow Update [ 20757 ] | Revised Fall 2019 Workflow Update [ 22504 ] |
Pull Request Updated with the Requirement Specified:
https://bitbucket.org/rpatil14/appstore_riddhi/pull-requests/2/igbf-2000-refactoring-fullname-to/diff
Noor Zahara Riddhi Jagdish Patil
Please check if your commits adhere with the following requirements:
We are using the same capitalization convention as the MANIFEST.MF variable to signal to developers where such variables are coming from.
All other variables use the python convention word_[word_]word. (I’m not sure if this style of variable naming has a name the same way camel case variables do.)
So far these fields/variable names are coming from the MANIFEST.MF:
Bundle_Name
Bundle_SymbolicName
Bundle_Description
Bundle_Version
However I just noticed the title of
IGBF-2000gives variable name Bundle_name, but it should have been Bundle_Name. I will fix it now. Sorry to waste your time on that.You might be able to do a global replace using sed and xargs, for example:
find . -type f -exec grep -Iq . {} \; -print | xargs -I FILE sed -i s/fullname/Bundle_name/g FILE
Refs:
https://stackoverflow.com/questions/4767396/linux-command-how-to-find-only-text-files
https://www.digitalocean.com/community/tutorials/the-basics-of-using-the-sed-stream-editor-to-manipulate-text-in-linux