Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2003

Rename tags variable as categories to make it more meaningful

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Refactor the app store code base to rename the tags variable to categories to make it more meaningful.

        Attachments

        1. issue-1.PNG
          issue-1.PNG
          54 kB
        2. issue-2.PNG
          issue-2.PNG
          128 kB
        3. issue-3.PNG
          issue-3.PNG
          165 kB
        4. issue-4.PNG
          issue-4.PNG
          167 kB

          Activity

          rpatil14 Riddhi Jagdish Patil (Inactive) created issue -
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Field Original Value New Value
          Epic Link IGBF-1996 [ 18087 ]
          ann.loraine Ann Loraine made changes -
          Summary Rename Tags variable as Categories to make it more meaningful Rename tags variable as categories to make it more meaningful
          ann.loraine Ann Loraine made changes -
          Status Open [ 1 ] To-Do [ 10305 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged to master in team repository. Please commence testing.

          Show
          ann.loraine Ann Loraine added a comment - Merged to master in team repository. Please commence testing.
          ann.loraine Ann Loraine made changes -
          Sprint Fall 2019 Sprint 2 [ 73 ] Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          ann.loraine Ann Loraine made changes -
          Status Post-merge Testing In Progress [ 10003 ] Merged Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Assignee Noor Zahara [ noor91zahara ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Assignee Riddhi Jagdish Patil [ rpatil14 ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

          Issue 1: Go to admin page -> click Apps -> Select any app -> Click on "+" besides categories -> new pop-up window to add categories appears. Change the title and the label of pop-up window to "Add Category" from "Add Tag"

          Issue 2: When new category is added from admin panel it is displayed in Categories section as "Tag Object " instead of "Category Object"

          Issue 3: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page. The edit app page shows "Add Tag" instead of "Add Category"

          Issue 4: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag . The add tag pop-up has title as "Select a Tag to Add" instead of "Select a Category to Add"

          Issue 5: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. The message while saving tags should be "Category saved" instead of "Tag saved"

          Critical Issue - Issue 6: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. Add 2 tags and save. After adding third tag and clicking on Save throws "Internal Server error"

          Please refer attached screenshots for test results.
          cc. [~aloraine], Noor Zahara

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Issue 1: Go to admin page -> click Apps -> Select any app -> Click on "+" besides categories -> new pop-up window to add categories appears. Change the title and the label of pop-up window to "Add Category" from "Add Tag" Issue 2: When new category is added from admin panel it is displayed in Categories section as "Tag Object " instead of "Category Object" Issue 3: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page. The edit app page shows "Add Tag" instead of "Add Category" Issue 4: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag . The add tag pop-up has title as "Select a Tag to Add" instead of "Select a Category to Add" Issue 5: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. The message while saving tags should be "Category saved" instead of "Tag saved" Critical Issue - Issue 6: Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. Add 2 tags and save. After adding third tag and clicking on Save throws "Internal Server error" Please refer attached screenshots for test results. cc. [~aloraine] , Noor Zahara
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Attachment issue-1.PNG [ 14430 ]
          Attachment issue-2.PNG [ 14431 ]
          Attachment issue-3.PNG [ 14432 ]
          Attachment issue-4.PNG [ 14433 ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Assignee Riddhi Jagdish Patil [ rpatil14 ]
          ann.loraine Ann Loraine made changes -
          Sprint Fall 2019 Sprint 2, Fall 2019 Sprint 3 [ 73, 74 ] Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 73, 74, 75 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2003-1#diff
          noor91zahara Noor Zahara (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          ann.loraine Ann Loraine made changes -
          Comment [ Please commence testing. ]
          ann.loraine Ann Loraine made changes -
          Resolution Unresolved [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Needs 1st Level Review [ 10005 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Resolution Unresolved [ 10101 ]
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          I reviewed the code but did not do functional testing.
          Please rebase onto master branch, perform testing above, make whatever changes are required, and submit PR.

          Show
          ann.loraine Ann Loraine added a comment - I reviewed the code but did not do functional testing. Please rebase onto master branch, perform testing above, make whatever changes are required, and submit PR.
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment - - edited

          I have rebased the code with master and have tested the above scenarios.

          PR Raised https://bitbucket.org/lorainelab/appstore/pull-requests/131/igbf-2003-1/diff

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - - edited I have rebased the code with master and have tested the above scenarios. PR Raised https://bitbucket.org/lorainelab/appstore/pull-requests/131/igbf-2003-1/diff
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged to master, deployed to https://dev-appstore-2.bioviz.org

          Show
          ann.loraine Ann Loraine added a comment - Merged to master, deployed to https://dev-appstore-2.bioviz.org
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Assignee Riddhi Jagdish Patil [ rpatil14 ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

          Professor [~aloraine], can you accept the two apps which I submitted on devAppStore2? Cannot proceed with testing without apps released.

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Professor [~aloraine] , can you accept the two apps which I submitted on devAppStore2? Cannot proceed with testing without apps released.
          Hide
          ann.loraine Ann Loraine added a comment -

          Please use user name & password which I will send you shortly! Riddhi Jagdish Patil

          Show
          ann.loraine Ann Loraine added a comment - Please use user name & password which I will send you shortly! Riddhi Jagdish Patil
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

          Tested below scenarios successfully:
          1) Go to admin page -> click Apps -> Select any app -> Click on "+" besides categories -> new pop-up window to add categories appears. The title and the label of pop-up window is "Add Category"

          2) When new category is added from admin panel it is displayed in Categories section as "Category Object"

          3) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page. The edit app page shows "Add Category"

          4) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag . The add tag pop-up has title as "Select a Category to Add"

          5) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. The message while saving tags is "Category saved"

          6) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. Add 2 tags and save.

          cc. [~aloraine], Noor Zahara

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Tested below scenarios successfully: 1) Go to admin page -> click Apps -> Select any app -> Click on "+" besides categories -> new pop-up window to add categories appears. The title and the label of pop-up window is "Add Category" 2) When new category is added from admin panel it is displayed in Categories section as "Category Object" 3) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page. The edit app page shows "Add Category" 4) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag . The add tag pop-up has title as "Select a Category to Add" 5) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. The message while saving tags is "Category saved" 6) Click on any app which has category added to it from the admin page -> Click Editor Actions -> Edit this page -> Click Add Tag -> Add a Tag -> Save. Add 2 tags and save. cc. [~aloraine] , Noor Zahara
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Assignee Riddhi Jagdish Patil [ rpatil14 ] Noor Zahara [ noor91zahara ]
          rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 20760 ] Revised Fall 2019 Workflow Update [ 22507 ]

            People

            • Assignee:
              noor91zahara Noor Zahara (Inactive)
              Reporter:
              rpatil14 Riddhi Jagdish Patil (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: