Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3
Description
- Refactor the app store code base to rename the version variable to bundle_version to make it more meaningful and to let the developers know that the version is Bundle-Version of MANIFEST.MF file
- Change the version field size from text field to char field which shows up in admin UI.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Summary | Rename version to bundle_version to make it more meaningful | Rename version to Bundle_Version to make it more meaningful |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged to master. Commence testing once all issues from epic https://jira.transvar.org/browse/IGBF-1996 are merged.
Please commence testing.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Bug fix has been made. Below is the code change
https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2005-1#diff
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Code is fine and feature is working as expected. Please submit PR.
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested the code changes by deploying latest code changes on https://dev-appstore-6.bioviz.org
Testing steps:
1) Open admin panel -> Apps -> Select any app to open app details.
Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field
2) Open admin panel -> App pendings -> Select any app to open app details.
Check that the version label is replaced with "Bundle Version" and the char field for version is replaced with input text field
Marking ticket as done
| Assignee | Noor Zahara [ noor91zahara ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 20762 ] | Revised Fall 2019 Workflow Update [ 22509 ] |
Code change can be found
https://bitbucket.org/rpatil14/appstore_refactoring/branch/IGBF-2005#diff