Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.0 Major Release
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov
Description
In https://jira.transvar.org/browse/IGBF-1902, we added an "Edit" button to the App Repositories tab in the IGB Preferences window.
Currently, if a user selects a row and clicks "Edit", a dialog appears that lets them manually edit the App Repository address and name.
However, there is no way to select a local folder. This is a problem because it blocks a user from switching to using a local directory instead of a remote one. To do this, they would need to know the proper syntax for specifying a local folder via a URL.
The "Add" button opens a dialog that contains a button labeled "Choose local folder" - this helps ensure that the user can use a system file chooser to pick the folder they want.
To fix this, modify the dialog to include "Choose local folder" button just like the "Add" dialog shows.
Lastly, modify the "Edit" button label to include the same ellipse (...) character show in the "Add" button.
Attachments
Activity
The code changes are present in the link below. Kindly review.
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2012#diff
The test cases that can be used for testing are as follows:
1) Editing http to https
2) Adding a url and then removing trailing path separators
3) Editing existing urls to incorrect paths
4) Editing correct local folder paths to incorrect ones
5) Removing an entry
6) Editing the name field for any entry using Edit button
7) Renaming any entry with the same name as that of any other entry in the table.
Kindly add any test case if not mentioned above. Thank you.
The code looks good.
When you pushed your branch, the bitbucket pipeline code was broken and an installer for your topic branch above did not get built.
It is now fixed!
Can you please rebase your branch onto master and push again to your fork?
That should trigger building the installer for your branch, allowing a reviewer to test the functionality.
Kindly review the code in the link below. Also, reframed the error message observed during editing the path to the app repo.
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2012#diff
Please let me know if anything else needs to be fixed. Thank you.
Some change requests:
- Don't use a text area to display user feedback. When there is no feedback, it looks like a place where the user needs to enter some text, which is confusing. Use a JLabel instead. Ensure that font size and face do not look weird when viewed next to the other text components of the dialog. They should look similar, not different.
- Check what happens when the user resizes the window. The Submit button expands currently. Compare to what happens when the "Add..." dialog gets resized.
- Move "Edit..." button on Plugin Repositories Preferences window to the right of "Add..."
Made the changes. Kindly review.
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2012#diff
Also, I tried to keep the JLabel in the center when the user resizes the window. But due to the default space between the "Save Changes" button and the right edge, the JLabel shifts a bit to the right. Please let me know if any further changes are needed.
Please rebase to get the latest code and trigger build of the installer for this revised branch.
Sorry about that. Its done. Please check.
Checked following things:
1) Resizing the dialog box is working fine and the alignment is not breaking.
2) "..." are being displayed for the edit button as well.
3) "Choose local folder" option is no added to the edit app repository button functionality which makes it easier to select a local plugin.
4) The error messages are also being displayed according to the option selected.
Everything seems to work fine.
Moving it forward to submit a PR column.
Shamika Gajanan Kulkarni, One request from my side.
Could you please mention how to navigate to Manage repository so that it would be super easy for people who has not worked on IGB to test this ticket. Please mention a detailed set instructions for testing as it would be a great help at the time of 9.1.0 release.
Thanks.
Pull Request Submitted:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/744/igbf-2012-change-textfield-to-jlabel/diff
Yes I shall shortly mention the steps to test.
Merged and built. Please test early release installers from bioviz web site.
Tested the functionality using the early release installers from bioviz site. Everything is working as expected.
Moving it to DONE.
As mentioned in https://jira.transvar.org/browse/IGBF-1902, we may have to use a GUI builder, since the code changes in normal Java code to add a "Choose local folder" button were not visible without using a GUI. The code changes are almost complete. I am working on testing all the test cases done for https://jira.transvar.org/browse/IGBF-1902. Two test case results are not up to the mark and I am currently working on fixing them before moving to Needs First Level Review. Also, the ellipse (...) has been included similar to "Add" button.