Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct
Description
Currently, App logo files uploaded by users are getting saved in the top level of the "media" directory in S3. Also, these files are named after whatever the user uploaded, with an added ".png" extension.
This is problematic because it makes the S3 bucket file and folder organization very hard to understand and manage. Also, it's a bit weird that we automatically add the ".png" extension. It's not clear what will happen if the file is not actually in png format.
Let's make our infrastructure more rationale as follows:
- When a user uploads a logo file for a given version of an App, the logo file will be stored in the version subdirectory for that App.
- Also, the logo file will be named after the App Bundle-Symbolic name and version.
For example:
User uploads a logo file named "goofy_Weird_strange_and_ bizarre name for a file.JPG" for an App with Bundle-SymbolicName "goofy-app" and Bundle-Version "0.0.1"
The App Store will allow this file to be uploaded but will re-name it goofy-app-0.0.1.jpg.
*Note*: We transform the file extension to lower-case letters and we keep whatever file extension the user assigned, assuming the file format is not actually getting changed to "png" in our code. (PNG is a different file format from JPEG, which is lossy and is typically used only for photographs and not computer-generated graphic art such as logo images.)
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Un-assigning (for now) because Noor Zahara may need to take the rest of the week to focus on classes and other things.
| Assignee | Noor Zahara [ noor91zahara ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Pull Request Submitted for this change:
https://bitbucket.org/lorainelab/appstore/pull-requests/116/igbf-2016-change-thumbnail-and-screenshot/diff
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Merged to master branch.
Sameer Shanbhag please deploy to your dev appstore instance for testing.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
Change requests:
- Do not prefix the file name with "logo_"
- Do not store the file in a "logo" subdirectory. Instead, store it in the release directory.
For example:
If I upload a file named "1545938680.png" as the new logo for super-simple-igb-app (Bundle-SymbolicName) version 0.0.1 (Bundle-Version), then the file should be stored as follows in S3:
/media/super-simple-igb-app/releases/0.0.1/super-simple-igb-app-0.0.1.png
not as
/media/super-simple-igb-app/releases/0.0.1/logo/logo_super-simple-igb-app-0.0.1.png
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Pull Request Submitted :
https://bitbucket.org/lorainelab/appstore/pull-requests/118/igbf-2016-change-logo-location/diff
Merged but not yet deployed to dev-appstore-2.bioviz.org (App Store master branch)
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Sprint | Fall 2019 Sprint 3 [ 74 ] | Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 74, 75 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Resolution | Fixed [ 1 ] | |
| Attachment | LogoStorageTest.png [ 14434 ] |
Working as Expected. Screenshot Attached. Moving it to done.
| Resolution | Fixed [ 1 ] | Done [ 10000 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 20773 ] | Revised Fall 2019 Workflow Update [ 22515 ] |
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Would you work on this one next time you are in Kannapolis?
Let me know if you have any questions/concerns or need anything!