Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2044

Fix: Accept of re-submitted pending apps saves incomplete app information

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov

      Description

      Steps to reproduce the issue:
      1) Submit any app by clicking Submit your App button on homepage.
      2) Upload app using either URL or jar and click Next
      3) Verify all the information and submit the app
      4) Try re-submitting same app using above steps without releasing the app
      5) Go to the pending apps and try to accept the submitted app.
      The app gets accepted but the loading spinner keeps on spinning.

      Check the admin page for that released app. The release file name and release file information is missing.

        Attachments

          Issue Links

            Activity

            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

            Issue:
            Multiple submission of same app with same version without releasing should create single entry in pending app and released on accept

            Files changed:
            https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF_2044#diff
            submit_app/views.py

            Testing steps:
            1) Submit any app by clicking Submit your App button on homepage
            2) Upload app using either URL or jar and click Next
            3) Verify all the information and submit the app
            4) Part I: Build a new jar for the same app, same version, but slightly different functionality so that you can tell the difference between them once installed into IGB. Try submitting this new jar (same Bundle-SymbolicName, same Bundle-Version) using above steps without releasing the previous submitted app
            5) Login as Admin
            6) Go to the pending apps and accept the submitted app. (There should be only one with this Bundle-SymbolicName and Bundle-Version.)
            7) The app will be accepted and released. Check that it is the correct one by installing it into IGB and running it.

            Testing result:
            Code changes deployed to -https://dev-appstore-6.bioviz.org
            S3 jar upload URL - https://s3.console.aws.amazon.com/s3/buckets/devappstore6-media-0000/media/super-simple-igb-app/releases/0.0.3/?region=us-east-1
            cc. Ann Loraine

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Issue: Multiple submission of same app with same version without releasing should create single entry in pending app and released on accept Files changed: https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF_2044#diff submit_app/views.py Testing steps: 1) Submit any app by clicking Submit your App button on homepage 2) Upload app using either URL or jar and click Next 3) Verify all the information and submit the app 4) Part I: Build a new jar for the same app, same version, but slightly different functionality so that you can tell the difference between them once installed into IGB. Try submitting this new jar (same Bundle-SymbolicName, same Bundle-Version) using above steps without releasing the previous submitted app 5) Login as Admin 6) Go to the pending apps and accept the submitted app. (There should be only one with this Bundle-SymbolicName and Bundle-Version.) 7) The app will be accepted and released. Check that it is the correct one by installing it into IGB and running it. Testing result: Code changes deployed to - https://dev-appstore-6.bioviz.org S3 jar upload URL - https://s3.console.aws.amazon.com/s3/buckets/devappstore6-media-0000/media/super-simple-igb-app/releases/0.0.3/?region=us-east-1 cc. Ann Loraine
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Looks good. Can be Deployed.
            Can you please raise the Pull Request.

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Looks good. Can be Deployed. Can you please raise the Pull Request.
            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/133/igbf-2044-multiple-submission-of-same-app/diff
            Hide
            aloraine Ann Loraine added a comment -

            Merged.

            Show
            aloraine Ann Loraine added a comment - Merged.
            Hide
            svallapu Sai Charan Reddy Vallapureddy added a comment -

            Riddhi Jagdish Patil

            File is getting updated in the release folder. But, the date of the file is not changing in the appstore UI.

            My suggestion is to change the date and time in the appstore UI. (It helps admin or users to check the latest version without looking in the file system)

            Show
            svallapu Sai Charan Reddy Vallapureddy added a comment - Riddhi Jagdish Patil File is getting updated in the release folder. But, the date of the file is not changing in the appstore UI. My suggestion is to change the date and time in the appstore UI. (It helps admin or users to check the latest version without looking in the file system)
            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

            Submitted pull request for wrong branch. Submitting pull request for correct branch below
            Pull request submitted
            https://bitbucket.org/lorainelab/appstore/pull-requests/136/igbf-2044/diff

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Submitted pull request for wrong branch. Submitting pull request for correct branch below Pull request submitted https://bitbucket.org/lorainelab/appstore/pull-requests/136/igbf-2044/diff
            Hide
            aloraine Ann Loraine added a comment -

            Merged but not yet deployed on dev-appstore-2.bioviz.org

            Show
            aloraine Ann Loraine added a comment - Merged but not yet deployed on dev-appstore-2.bioviz.org
            Hide
            noor91zahara Noor Zahara added a comment -

            Tested

            Issue Found -
            1. Release file name not getting updated upon accepting the pending app.

            Show
            noor91zahara Noor Zahara added a comment - Tested Issue Found - 1. Release file name not getting updated upon accepting the pending app.
            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

            Release file name not getting updated upon accepting the pending app issue will be fixed as a part of the ticket IGBF-2072
            Keeping this ticket in "Needs testing step". Can be tested once IGBF-2072 is merged to master.
            cc. Ann Loraine, Noor Zahara

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Release file name not getting updated upon accepting the pending app issue will be fixed as a part of the ticket IGBF-2072 Keeping this ticket in "Needs testing step". Can be tested once IGBF-2072 is merged to master. cc. Ann Loraine , Noor Zahara
            Hide
            aloraine Ann Loraine added a comment -

            Deployed on https://dev-appstore-2.bioviz.org and ready for testing.

            Show
            aloraine Ann Loraine added a comment - Deployed on https://dev-appstore-2.bioviz.org and ready for testing.
            Hide
            noor91zahara Noor Zahara added a comment -

            Testing result-

            Same App submitted multiple times is getting accepted with all the details being updated.
            App released time shown in release history is incorrect.

            Show
            noor91zahara Noor Zahara added a comment - Testing result- Same App submitted multiple times is getting accepted with all the details being updated. App released time shown in release history is incorrect.
            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -
            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Fixed release time in app release history: https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2044-BugFix#diff cc. Noor Zahara
            Hide
            aloraine Ann Loraine added a comment -

            Have not done functional review of new branch but feel it will be fine to merge this into master as-is.

            Show
            aloraine Ann Loraine added a comment - Have not done functional review of new branch but feel it will be fine to merge this into master as-is.
            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/151/igbf-2044-display-release-date-in-human/diff
            Hide
            noor91zahara Noor Zahara added a comment -

            It is working as expected.
            TimeZone considered is UTC.

            Show
            noor91zahara Noor Zahara added a comment - It is working as expected. TimeZone considered is UTC.

              People

              • Assignee:
                rpatil14 Riddhi Jagdish Patil (Inactive)
                Reporter:
                rpatil14 Riddhi Jagdish Patil (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: