Details
-
Type: Bug
-
Status: Closed (View Workflow)
-
Priority: Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov
Description
Steps to re-produce the issue:
1) Submit app say "super-simple-igb-app" of version "0.0.1"
2) Submit app "super-simple-igb-app" of version "0.0.3"
Now pending apps section will have two entries for "super-simple-igb-app-0.0.1" and "super-simple-igb-app-0.0.3".
Ideal scenario - Both the versions of the apps should be released when accepted in pending apps section
Current behavior - If any one version of app is selected, the other version of app cannot be released and the spinner keeps on rotating
Cause of Issue which needs further debugging - Database has primary key as Bundle_SymbolicName. Since both the apps have same symbolicName duplicate entries are not allowed in database.
Probable solution - To use both Bundle_SymbolicName and Bundle_Version as primary key for App table.
Issue:
Pending app of different versions is not able to be released
Solution:
Instead of creating new object whenever accepting request from pending, check if the object with same App already exists in Database, if yes, update the version and release path of that object else create new one.
Files changed:
Code changes are present in branch
IGBF-2050https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2050
submit_app/models.py
submit_app/views.py
Testing steps:
1) Click on Submit Your App -> Upload an app with some version. for eg - super-simple-igb-app-0.0.1.jar
2) Click on Submit Your App -> Upload same app with different version. for eg - super-simple-igb-app-0.0.3.jar
3) Login as admin
4) Go to Pending apps
5) Accept pending request for super-simple-igb-app-0.0.1 app
6) Accept pending request for super-simple-igb-app-0.0.3 app
Both the apps should be accepted
Check the behavior by logging to the admin page
1) Only one app with Bundle_SymbolicName super-simple-igb-app should be present and its version and release file should be 0.0.3
2) Releases tab should have two entries - one for release 0.0.1 and another for release 0.0.3
Code changes deployed to https://dev-appstore-6.bioviz.org
cc.[~aloraine]