Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov
Description
- Install4J configuration file refers to non-existent files and/or directories. Remove these references.
- Remove now-redundant App code - developmentPlugins and optionalPlugins - as these have been migrated to new repositories.
- Improve name tags for modules to better reflect functionality and improve readability when viewed in Netbeans IDE.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Rank | Ranked higher |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Modified "name" tag in all pom.xml's in IGB project modules to better reflect function and position in the file tree.
Goal: make it easier for developers to find where different parts of the GUI are implemented in the project.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Description |
Top-level POM refers to obsolete or non-exist files.
Also, remove non-redundant App code. Migrate remaining App code to new repos. |
* Install4J configuration file refers to non-existent files and/or directories. Remove these references.
* Remove now-redundant App code - developmentPlugins and optionalPlugins - as these have been migrated to new repositories. * Improve name tags for modules to better reflect functionality and improve readability when viewed in Netbeans IDE. |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Prof. [~aloraine], I have reviewed the changes and the updated name(i.e. Plugin - Rest APIs for App Store/ Core - ) makes it really easy to understand what would be the content of the bundle from a developer point view.
Also, I installed IGB using IGBF-2069branch installer on my mac as well as sameer's windows machine to check if the installation directory looks fine. As mentioned above there aren't any unnecessary files in the directory.
Is there anything else that needs to be tested then let me know. Also let me know if I can now move the ticket forward to Ready for PR or not.
Thanks.
Thank you. If you still feel it is ready, go ahead and move to the next step in Jira.
Prof. [~aloraine], One last time I will check each pom, just to make sure each name tag is updated if necessary.
I will let you know if I find anything else I will move it to done.
Thanks.
| Workflow | Fall 2019 Workflow Update [ 20826 ] | Revised Fall 2019 Workflow Update [ 21165 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged to master.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Prutha Kulkarni [ prutha ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Sprint | Fall 5 : 14 Oct to 25 Oct [ 76 ] | Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov [ 76, 77 ] |
| Rank | Ranked higher |
I have tested the ticket and checked the names in all necessary pom files. The name changes are visible.
I would just like to mention that when I opened the installation directory after installing IGB, I could see the .gitignore file present in the directory. Moving the ticket to To-do.
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
Edited configuration file distribution/igb_7.install4j.
Added new "exclude" tag instructing install4j to exclude .gitignore from installers.
Please review by downloading and unpacking new master branch installer from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ann Loraine [ aloraine ] | Shamika Gajanan Kulkarni [ shamika ] |
Prof. [~aloraine] as per the following lines, I think we are attempting to exclude all the folders namely, core, distribution, doc, etc.
<entry location="core" fileType="regular" />
<entry location="distribution" fileType="regular" />
<entry location="docs" fileType="regular" />
<entry location="main" fileType="regular" />
<entry location="plugins" fileType="regular" />
But the contents of the doc folder are still visible in the installation directory. I am sorry for not noticing this earlier. Just wanted to confirm is it okay if that folder is visible?
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
If we change "docs" to "doc" will that fix it?
| Assignee | Ann Loraine [ aloraine ] | Shamika Gajanan Kulkarni [ shamika ] |
Yes, I think it should. Since the name of the folder is "doc", I feel doing that can fix it.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
I have made the change directly on the master branch and trigger a new installer build. Please re-review once the installer is built and ready for download. Shamika Gajanan Kulkarni
| Sprint | Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov [ 76, 77 ] | Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov [ 76, 77, 78 ] |
| Rank | Ranked higher |
Downloaded newly built installer and confirmed "doc" directory is no longer present. Moving to closed.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Suggestions for testing:
.git directory
.gitignore directory
pom.xml
scripts for running IGB from command line (except Linux installer maybe?)