Is there a case where the versions of org.lorainelab.igb packages might be different from one another? Is it necessary to look into all the packages?

Code changes = https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2099#diff

IGB platform released by us will always have the same bundle versions as eachother.

[~aloraine] - Kindly confirm if the attached screenshot looks fine or should the IGB version format be changed?

If the import statements for platform bundles specify [9.1.0,10,0.0], then change the user-facing text to look like:

"Works with IGB [9.1.0,10.0.0)"

Please:

• Omit the word "version" here – I think it's clear from the context that we're talking about a version.
• Indicate the allowed range of versions. I can't think of a better way to this than the syntax [9.1.0,10.0.0). I've explained what this means dozens of times in many different settings. People seem to instantly know what it means just from looking at the string. So I think it will work fine to communicate the basic idea. If I'm wrong this about, we will find out from usability testing.
• Make sure that version strings that don't indicate a range are also supported. Please review: https://jira.transvar.org/browse/IGBF-1906

I recommend:

• Store the version string from the XML itself, along with platform major, minor, and micro (patch) versions extracted from same.
• Store the parsed platform version upper bound major, minor, micro numbers and lower bound major, minor, and micro numbers
• If a developer does not specify an upper bound (it's possible) then leave these fields as null values
• Lower bound should be specified with no defaults. The code that processes the bundle and prepares it for release should warn the developer and reject the bundle if we can't figure out what lower bound version the App depends on
• Handle cases where the App developers does not indicate an upper bound. In that case, we assume the range is open-ended. Indicate that with lower-bound+, e.g., "Works with IGB 9.1.0+"

I have made the changes as per the above comment.
Kindly check the screenshots to view the changes

Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2099#diff

Scope changes from discussion earlier today:

• Please change field named "works_with" to "platform_compatibility"
• Please save the compatibility string exactly as reported in the XML. (Not sure if this already been done?)

For example, if the string is: "[9.1.0,10.0.0]" then save exactly that.
Or, if the string is "9.1.0", then save exactly that.

• Within the app's page itself, simply extract this string from and show it as is.
• (minor change: change "verison" to "version")

Please review IGB packages. Unfortunately, there are some that do not match the pattern in the regular expression being used.

To avoid increasing the scope much more, I think we should modify the _create_pending in apps/views.py code as follows:

First assemble a list of all artifact id's in IGB (see top-level pom for these).
Then, build a set of regular expressions that can match each of these.
Modify the views.py _create_pending code to extract the platform compatibility string for each platform artifactId. Get the version compatibility string for each platform bundle.
Add code to check that all of these are the same. If some are different, use the Django logging system to add a warning to the log.
Pick the version compatibility string that appears most often and use that.

We will build a warning to the user later on as part of different ticket – possibly after the refactoring of App and Release models in apps/apps/models.py.

The only other valid IGB package I see is com.affymetrix. Could you verify the same? (I am a bit confused.)

Also my suggestion would be changing "works_with" to "platform_compatibility" as a part of refactoring ticket.

Yes, I agree. Changing "works_with" to "platform_compatibility" should be done as a part of refactoring ticket.

Regarding getting a list of packages in the platform:
The only way I can think of to do it would be to look at all the pom.xml files and parse out the exported packages. Or manually go through every module in the project and look at all the package names. That would take a lot of time and would probably be hard to maintain. There is surely a better way.

Here is an example of a package that does not contain "igb" in the name:
https://bitbucket.org/lorainelab/integrated-genome-browser/src/master/core/common/src/main/java/com/affymetrix/common/

To close this, maybe best approach is:

• add the logic for searching for with more than one regular expression
• add a regex to catch the packages in the link above but don't spend a lot of time digging through the entire code base and all the pom's
• create a new ticket where the task is to identify all packages
• create a new ticket to find a more robust approach that does not require us to update App Store every time we add or refactor platform packages

As of now I have added a logic to support multiple IGB packages.

Creating tickets for finding out all the IGB packages and also a way to avoid updating Appstore each time a new IGB package is added.

Kindly review the code.

Merged into the master branch and deployed to https://dev-appstore-2.bioviz.org for testing.

Testing on hold, since Sameer Shanbhag is working on a ticket related to 'Improve box-release-info on apps page'

Logic is not working for Command Socket App Moving it back to To-Do

This is fixed as a part of IGBF-2139

Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2099-1#diff

Related to IGBF-2148

Please rebase onto the master branch and deploy on an EC2 for pre-merge testing.
Noor Zahara

This has been rebased with master. Kindly review the change.

Change request:

Please change error_message (line 105) to:

"Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."

I have changed the error message to "Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."

https://bitbucket.org/lorainelab/appstore/pull-requests/171/igbf-2099-1/diff - PR raised

Merged and deployed to https://dev-appstore-2.bioviz.org.

Tested on dev-appstore-2. The works with field along with whichever IGB version it is compatible with is shown properly on the app page.
Moving it to DONE.