Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2108

Account for bookmark export cancellation

        Details

        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec

          Description

          I noticed that when clicking - in the menu bar - Bookmarks -> Export Bookmarks... -> cancel/esc will result in an exception being thrown in the console. Usability doesn't seem to be negatively affected in any way, so this exception/case simply needs to be handled in the code.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1153 Convert Export Bookmark file chooser to the operating system's Native File Chooser

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. REL-9 Verify functionality of the bookmark subsystem

              • Major - Major loss of function.
              • Testing Complete

                Activity

                Ascending order - Click to sort in descending order
                pbadzuh Philip Badzuh (Inactive) created issue -
                pbadzuh Philip Badzuh (Inactive) made changes -
                Field Original Value New Value
                Epic Link IGBF-1531 [ 17617 ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Link This issue relates to REL-9 [ REL-9 ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Epic Link IGBF-1531 [ 17617 ] IGBF-1765 [ 17855 ]
                ann.loraine Ann Loraine made changes -
                Sprint Fall 6 : 28 Oct to 8 Nov [ 77 ] Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov [ 77, 78 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                pbadzuh Philip Badzuh (Inactive) made changes -
                Assignee Philip Badzuh [ pbadzuh ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                I learned that IGBF-1153 introduced a couple print statements that may or may not be needed anymore. One such print statement was the cause of this issue's error, and I have fixed it here: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2108#diff

                Please review and advise if the print statements are still necessary or if they should be removed prior to submitting a pull request.

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - I learned that IGBF-1153 introduced a couple print statements that may or may not be needed anymore. One such print statement was the cause of this issue's error, and I have fixed it here: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2108#diff Please review and advise if the print statements are still necessary or if they should be removed prior to submitting a pull request.
                pbadzuh Philip Badzuh (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Assignee Philip Badzuh [ pbadzuh ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Thank you for noticing this. I don't think it is needed, so removing it is great. Please submit PR.

                Show
                ann.loraine Ann Loraine added a comment - Thank you for noticing this. I don't think it is needed, so removing it is great. Please submit PR.
                ann.loraine Ann Loraine made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                ann.loraine Ann Loraine made changes -
                Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
                ann.loraine Ann Loraine made changes -
                Assignee Philip Badzuh [ pbadzuh ]
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                No problem. Please see the pull request here: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/753/igbf-2108-remove-bookmark-export/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - No problem. Please see the pull request here: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/753/igbf-2108-remove-bookmark-export/diff
                pbadzuh Philip Badzuh (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Assignee Philip Badzuh [ pbadzuh ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                ann.loraine Ann Loraine made changes -
                Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
                pbadzuh Philip Badzuh (Inactive) made changes -
                Link This issue relates to IGBF-1153 [ IGBF-1153 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Merged. Master branch installers built and deployed to bioviz.org early access release location.

                Show
                ann.loraine Ann Loraine added a comment - - edited Merged. Master branch installers built and deployed to bioviz.org early access release location.
                prutha Prutha Kulkarni (Inactive) made changes -
                Assignee Prutha Kulkarni [ prutha ]
                ann.loraine Ann Loraine made changes -
                Sprint Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov [ 77, 78 ] Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec [ 77, 78, 79 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                prutha Prutha Kulkarni (Inactive) made changes -
                Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                Philip Badzuh, I have tested the "Export Bookmark" functionality in the IGB early access version and no exceptions were thrown when I clicked on cancel/esc. Moving the ticket to DONE.

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - Philip Badzuh , I have tested the "Export Bookmark" functionality in the IGB early access version and no exceptions were thrown when I clicked on cancel/esc. Moving the ticket to DONE.
                prutha Prutha Kulkarni (Inactive) made changes -
                Assignee Prutha Kulkarni [ prutha ] Philip Badzuh [ pbadzuh ]
                prutha Prutha Kulkarni (Inactive) made changes -
                Resolution Done [ 10000 ]
                Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                  People

                  • Assignee:
                    pbadzuh Philip Badzuh (Inactive)
                    Reporter:
                    pbadzuh Philip Badzuh (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: