Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec
Description
Change App page layout as shown in Slide 2 of:
https://www.dropbox.com/s/7k8ue6ha3l1ggc5/apppage.pptx?dl=0.
Summary:
- Move App install button to position immediately underneath where Editor Actions menu appears when an editor is logged in.
- Show App version above Categories (two places on the page, not just one)
- Area on the page where Editor Actions menu appears is always either empty or is showing the Editor Actions menu. Goal is to provide an instant cue to user regarding their login status and permissions
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Sprint | Fall 7 : 11 Nov to 22 Nov [ 78 ] |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Code looks fine functionally, but I have not seen it live. Moving to ready for PR anyway.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged not yet deployed on dev-appstore-2.bioviz.org.
| Comment |
[ There are many instances of "latest" in the code, suggesting the business logic for display apps is using date not version. This should be fixed. Because this is a different issue, have created a new ticket for that - https://jira.transvar.org/browse/IGBF-2145
] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested the ticket. Observed that the following is working as expected.
1) The App version is visible above Categories with font size as mentioned in pptx
2) The App install button is positioned immediately underneath the Editor Actions
3) The 'Go back to home' link is not visible anymore.
4) When IGB 9.1 endpoint does not respond, the download symbol besides 'Get latest IGB' is visible, which when clicked redirects to 'https://bioviz.org'
5) When IGB endpoint responds, 'Install this App' is visible along with the download symbol.
6) On installing the app, the content changes to 'Installed' with a success checkmark
7) The hyperlink from version compatibility has been removed
However, there are two observations which did not satisfy what was mentioned in pptx
1) If the app is installed, I was still able to see the 'Hand Pointer' on box-release-info content.
2) If a new version of the app is released and the lower version of app is already installed, the content does not change to 'Update this app'. Please refer the screenshot attached.
Kindly check Noor Zahara
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Noor Zahara [ noor91zahara ] |
| Attachment | appstore1.JPG [ 14518 ] | |
| Attachment | appstore2.JPG [ 14519 ] |
1. Needs to be fixed. Noor Zahara Riddhi Jagdish Patil
2. Known Bug and reported in IGBF-2149
Prof. [~aloraine] The 'Update this app' feature works for App for Testing App Workflow and Get average score after refreshing App Manager, but is not working for Super Simple IGB App.
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Fixed issue 1:
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2139-BugFix#diff
cc.[~aloraine]
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Sprint | Fall 7 : 11 Nov to 22 Nov [ 78 ] | Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec [ 78, 79 ] |
| Rank | Ranked higher |
I have not tested this, but it looks like it will work. Please submit PR Riddhi Jagdish Patil
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Merged not yet deployed on dev-appstore-2.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed to https://dev-appstore-2.bioviz.org and ready for testing.
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
The app page layouts are changed according to the powerpoint slide no. 2. Everything change mentioned in the slide is implemented and tested on dev-appstore.
Moving the ticket to DONE.
| Assignee | Prutha Kulkarni [ prutha ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2139#diff