Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      I am not able to submit the 23 and Me App on dev-appstore-2.

      Code deployed on dev-appstore-2 is - latest commit first:

      99bc28f (HEAD -> master, origin/master, origin/HEAD) Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
      efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes

      To repeat (if using Chrome):

      • Close all open Chrome windows or tabs
      • Open incognito window
      • Log in to App Store
      • Go to Submit App page
      • Copy jar file URL into box, click Next
      • Observe an error message at the top of the page: "max() arg is an empty sequence"

      Jar link:

      https://bitbucket.org/lorainelab/23andme-snp-converter/downloads/23andMe-snp-converter-9.1.0.jar

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1388 [ 17463 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Summary Fix: Can not submit 23 and Me App Fix: Can not submit any App tested
            ann.loraine Ann Loraine made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            Hide
            ann.loraine Ann Loraine added a comment -
            Show
            ann.loraine Ann Loraine added a comment - Observing same problem for: https://bitbucket.org/lorainelab/app-for-testing-app-workflow/downloads/app-for-testing-app-workflow-1.0.0.jar on both Chrome and Safari
            ann.loraine Ann Loraine made changes -
            Description I am not able to submit the 23 and Me App on dev-appstore-2.

            Code deployed on dev-appstore-2 is - latest commit first:

            99bc28f (HEAD -> master, origin/master, origin/HEAD) Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
            efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes

            To repeat (if using Chrome):

            * Close all open Chrome windows or tabs
            * Open incognito window
            * Log in to App Store
            * Go to Submit App page
            * Copy jar file URl into box, click Next
            * Observe an error message at the top of the page: "max() arg is an empty sequence"

            Jar link:

            https://bitbucket.org/lorainelab/23andme-snp-converter/downloads/23andMe-snp-converter-9.1.0.jar

            I am not able to submit the 23 and Me App on dev-appstore-2.

            Code deployed on dev-appstore-2 is - latest commit first:

            99bc28f (HEAD -> master, origin/master, origin/HEAD) Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
            efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes

            To repeat (if using Chrome):

            * Close all open Chrome windows or tabs
            * Open incognito window
            * Log in to App Store
            * Go to Submit App page
            * Copy jar file URL into box, click Next
            * Observe an error message at the top of the page: "max() arg is an empty sequence"

            Jar link:

            https://bitbucket.org/lorainelab/23andme-snp-converter/downloads/23andMe-snp-converter-9.1.0.jar

            Hide
            ann.loraine Ann Loraine added a comment -

            Just now merged PRs into master.
            Am deploying new master to dev-appstore-2

            Show
            ann.loraine Ann Loraine added a comment - Just now merged PRs into master. Am deploying new master to dev-appstore-2
            Hide
            ann.loraine Ann Loraine added a comment -

            Redeployed newest master. Same problem occurs.

            Latest code on dev-appstore-2 is:

            ae5bd57 (HEAD -> master, origin/master, origin/HEAD) Merged in nzahara/appstore-local/IGBF-2137 (pull request #160)
            d7baac6 Merged in rpatil14/appstore_riddhi/IGBF-2131 (pull request #161)
            9579d5a IGBF-2137 Purge unwanted code from app and app edit pages.
            99bc28f Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
            efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes
            44a8218 Merged in nzahara/appstore-local/IGBF-2139 (pull request #158)
            52e7510 IGBF-2139 Layout/ UI Changes in App page and fix the bug related to repository.xml parsing.

            Show
            ann.loraine Ann Loraine added a comment - Redeployed newest master. Same problem occurs. Latest code on dev-appstore-2 is: ae5bd57 (HEAD -> master, origin/master, origin/HEAD) Merged in nzahara/appstore-local/ IGBF-2137 (pull request #160) d7baac6 Merged in rpatil14/appstore_riddhi/ IGBF-2131 (pull request #161) 9579d5a IGBF-2137 Purge unwanted code from app and app edit pages. 99bc28f Merged in sshanbh1/sameer-appstorefork/ IGBF-2138 (pull request #159) efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes 44a8218 Merged in nzahara/appstore-local/ IGBF-2139 (pull request #158) 52e7510 IGBF-2139 Layout/ UI Changes in App page and fix the bug related to repository.xml parsing.
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Summary Fix: Can not submit any App tested Fix: Can not submit any App
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Code change - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2146#diff
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Check:

            • version_pattern ="^[0-9].[0-9].[0-9]+"

            looks like it will fail if major, minor, or micro are more than one digit, e.g., 10.1.0 or 9.10.1

            Be sure to check semantic versioning Web page - see link below.

            Show
            ann.loraine Ann Loraine added a comment - - edited Check: version_pattern ="^ [0-9] . [0-9] . [0-9] +" looks like it will fail if major, minor, or micro are more than one digit, e.g., 10.1.0 or 9.10.1 Be sure to check semantic versioning Web page - see link below.
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Semantic versioning Web page has regex's that properly match major.minor.micro version strings:
            See: https://semver.org/

            Show
            ann.loraine Ann Loraine added a comment - Semantic versioning Web page has regex's that properly match major.minor.micro version strings: See: https://semver.org/
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            I just tested with 'App for testing" jar version 3.0.1 which is supported by IGB version 10.0.11. It worked fine with the changes.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - I just tested with 'App for testing" jar version 3.0.1 which is supported by IGB version 10.0.11. It worked fine with the changes.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Change error message:

            raise ValueError("The version is not in proper pattern. It should have 3 order version numbering "
            "(e.g: x.y.z)")

            to

            raise ValueError("Bundle-Version %s is incorrect. Please use semantic versioning. See https://semver.org/."%jar_details['Bundle_Version'])

            Show
            ann.loraine Ann Loraine added a comment - - edited Change error message: raise ValueError("The version is not in proper pattern. It should have 3 order version numbering " "(e.g: x.y.z)") to raise ValueError("Bundle-Version %s is incorrect. Please use semantic versioning. See https://semver.org/ ."%jar_details ['Bundle_Version'] )
            Hide
            ann.loraine Ann Loraine added a comment -

            Check what happens if a Bundle-Version is 10.1.1.

            Currently I don't think we have any such bundle in the IGB Apps repositories. You will need to create one for testing. But I'm pretty sure that it will fail.

            Show
            ann.loraine Ann Loraine added a comment - Check what happens if a Bundle-Version is 10.1.1. Currently I don't think we have any such bundle in the IGB Apps repositories. You will need to create one for testing. But I'm pretty sure that it will fail.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            I got confused with IGB version. When I tested with Bundle-Version is 10.1.1, it failed.
            I used the regex mentioned in https://semver.org/ and works fine.

            I have pushed the code changes. Kindly review

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - I got confused with IGB version. When I tested with Bundle-Version is 10.1.1, it failed. I used the regex mentioned in https://semver.org/ and works fine. I have pushed the code changes. Kindly review
            noor91zahara Noor Zahara (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            ann.loraine Ann Loraine added a comment -

            The code looks fine. I have not tried to run it, but I think it will be OK to merge. Please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - The code looks fine. I have not tried to run it, but I think it will be OK to merge. Please submit PR.
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/163/igbf-2146/diff
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged but not yet deployed to dev-appstore-2

            Show
            ann.loraine Ann Loraine added a comment - Merged but not yet deployed to dev-appstore-2
            Hide
            ann.loraine Ann Loraine added a comment -

            Deployed on dev-appstore-2.
            Noor Zahara please test.

            Show
            ann.loraine Ann Loraine added a comment - Deployed on dev-appstore-2. Noor Zahara please test.
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Link This issue blocks IGBF-2147 [ IGBF-2147 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            pbole Pawan Bole (Inactive) made changes -
            Assignee Pawan Bole [ pbole ]
            Hide
            pbole Pawan Bole (Inactive) added a comment -

            Verified on dev-appstore-2 and it is working as expected. I was able to submit the 23 and Me App on dev-appstore-2.

            Show
            pbole Pawan Bole (Inactive) added a comment - Verified on dev-appstore-2 and it is working as expected. I was able to submit the 23 and Me App on dev-appstore-2.
            pbole Pawan Bole (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            pbole Pawan Bole (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            pbole Pawan Bole (Inactive) made changes -
            Assignee Pawan Bole [ pbole ] Noor Zahara [ noor91zahara ]

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: