Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2146

Fix: Can not submit any App

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Blocker
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          I am not able to submit the 23 and Me App on dev-appstore-2.

          Code deployed on dev-appstore-2 is - latest commit first:

          99bc28f (HEAD -> master, origin/master, origin/HEAD) Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
          efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes

          To repeat (if using Chrome):

          • Close all open Chrome windows or tabs
          • Open incognito window
          • Log in to App Store
          • Go to Submit App page
          • Copy jar file URL into box, click Next
          • Observe an error message at the top of the page: "max() arg is an empty sequence"

          Jar link:

          https://bitbucket.org/lorainelab/23andme-snp-converter/downloads/23andMe-snp-converter-9.1.0.jar

            Attachments

              Issue Links

              blocks

              Task - A task that needs to be done. REL-37 Check how App Store handles weird Bundle-Version strings for Apps

              • Major - Major loss of function.
              • Testing To-Do

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Observing same problem for:

                Show
                ann.loraine Ann Loraine added a comment - Observing same problem for: https://bitbucket.org/lorainelab/app-for-testing-app-workflow/downloads/app-for-testing-app-workflow-1.0.0.jar on both Chrome and Safari
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Just now merged PRs into master.
                Am deploying new master to dev-appstore-2

                Show
                ann.loraine Ann Loraine added a comment - Just now merged PRs into master. Am deploying new master to dev-appstore-2
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Redeployed newest master. Same problem occurs.

                Latest code on dev-appstore-2 is:

                ae5bd57 (HEAD -> master, origin/master, origin/HEAD) Merged in nzahara/appstore-local/IGBF-2137 (pull request #160)
                d7baac6 Merged in rpatil14/appstore_riddhi/IGBF-2131 (pull request #161)
                9579d5a IGBF-2137 Purge unwanted code from app and app edit pages.
                99bc28f Merged in sshanbh1/sameer-appstorefork/IGBF-2138 (pull request #159)
                efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes
                44a8218 Merged in nzahara/appstore-local/IGBF-2139 (pull request #158)
                52e7510 IGBF-2139 Layout/ UI Changes in App page and fix the bug related to repository.xml parsing.

                Show
                ann.loraine Ann Loraine added a comment - Redeployed newest master. Same problem occurs. Latest code on dev-appstore-2 is: ae5bd57 (HEAD -> master, origin/master, origin/HEAD) Merged in nzahara/appstore-local/ IGBF-2137 (pull request #160) d7baac6 Merged in rpatil14/appstore_riddhi/ IGBF-2131 (pull request #161) 9579d5a IGBF-2137 Purge unwanted code from app and app edit pages. 99bc28f Merged in sshanbh1/sameer-appstorefork/ IGBF-2138 (pull request #159) efa3db4 IGBF-2138 : Editor Panel to Match the Requested Changes 44a8218 Merged in nzahara/appstore-local/ IGBF-2139 (pull request #158) 52e7510 IGBF-2139 Layout/ UI Changes in App page and fix the bug related to repository.xml parsing.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Code change - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2146#diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Code change - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2146#diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Check:

                • version_pattern ="^[0-9].[0-9].[0-9]+"

                looks like it will fail if major, minor, or micro are more than one digit, e.g., 10.1.0 or 9.10.1

                Be sure to check semantic versioning Web page - see link below.

                Show
                ann.loraine Ann Loraine added a comment - - edited Check: version_pattern ="^ [0-9] . [0-9] . [0-9] +" looks like it will fail if major, minor, or micro are more than one digit, e.g., 10.1.0 or 9.10.1 Be sure to check semantic versioning Web page - see link below.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Semantic versioning Web page has regex's that properly match major.minor.micro version strings:
                See: https://semver.org/

                Show
                ann.loraine Ann Loraine added a comment - Semantic versioning Web page has regex's that properly match major.minor.micro version strings: See: https://semver.org/
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                I just tested with 'App for testing" jar version 3.0.1 which is supported by IGB version 10.0.11. It worked fine with the changes.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - I just tested with 'App for testing" jar version 3.0.1 which is supported by IGB version 10.0.11. It worked fine with the changes.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Change error message:

                raise ValueError("The version is not in proper pattern. It should have 3 order version numbering "
                "(e.g: x.y.z)")

                to

                raise ValueError("Bundle-Version %s is incorrect. Please use semantic versioning. See https://semver.org/."%jar_details['Bundle_Version'])

                Show
                ann.loraine Ann Loraine added a comment - - edited Change error message: raise ValueError("The version is not in proper pattern. It should have 3 order version numbering " "(e.g: x.y.z)") to raise ValueError("Bundle-Version %s is incorrect. Please use semantic versioning. See https://semver.org/ ."%jar_details ['Bundle_Version'] )
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Check what happens if a Bundle-Version is 10.1.1.

                Currently I don't think we have any such bundle in the IGB Apps repositories. You will need to create one for testing. But I'm pretty sure that it will fail.

                Show
                ann.loraine Ann Loraine added a comment - Check what happens if a Bundle-Version is 10.1.1. Currently I don't think we have any such bundle in the IGB Apps repositories. You will need to create one for testing. But I'm pretty sure that it will fail.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                I got confused with IGB version. When I tested with Bundle-Version is 10.1.1, it failed.
                I used the regex mentioned in https://semver.org/ and works fine.

                I have pushed the code changes. Kindly review

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - I got confused with IGB version. When I tested with Bundle-Version is 10.1.1, it failed. I used the regex mentioned in https://semver.org/ and works fine. I have pushed the code changes. Kindly review
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                The code looks fine. I have not tried to run it, but I think it will be OK to merge. Please submit PR.

                Show
                ann.loraine Ann Loraine added a comment - The code looks fine. I have not tried to run it, but I think it will be OK to merge. Please submit PR.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/163/igbf-2146/diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/163/igbf-2146/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged but not yet deployed to dev-appstore-2

                Show
                ann.loraine Ann Loraine added a comment - Merged but not yet deployed to dev-appstore-2
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Deployed on dev-appstore-2.
                Noor Zahara please test.

                Show
                ann.loraine Ann Loraine added a comment - Deployed on dev-appstore-2. Noor Zahara please test.
                Hide
                Permalink
                pbole Pawan Bole (Inactive) added a comment -

                Verified on dev-appstore-2 and it is working as expected. I was able to submit the 23 and Me App on dev-appstore-2.

                Show
                pbole Pawan Bole (Inactive) added a comment - Verified on dev-appstore-2 and it is working as expected. I was able to submit the 23 and Me App on dev-appstore-2.

                  People

                  • Assignee:
                    noor91zahara Noor Zahara (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: