Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 7 : 11 Nov to 22 Nov
Description
I am able to submit an App, but when I try to visit the App's page, App Store gives an error:
"Page not found (404)
Request Method: GET
Request URL: https://dev-appstore-2.bioviz.org/apps/org.lorainelab.igb.protannot
Raised by: apps.views.app_page
No App matches the given query.
You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard 404 page."
Let me know if you are able to take a look at this tonite – main thing is I'd like the testers to have a working copy tomorrow. If not, no worries!
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
[~aloraine] Hi Professor,
I looked into it and found out that this problem is specific to ProtAnot.
I tried to submit the Super Simpel IGB App and it works. I'll dig deeper into it and update this thread.
Another Observation:
The problem is with the symbolic name:
1. ProtAnot has Symbolic Name: org.lorainelab.igb.protannot
2. If we convert Symbolic name to org-lorainelab-igb-protanot it works. (Change from Admin Panel)
I'll try to see how we can fix this.
The issue Is resolved.
Regex needed to be fixed.
re_path(r'^(?P<app_name>[-\w\d]+)/'
changed to
*re_path(r'^(?P<app_name>[-\w\d\.]+)/'*
\. also considers "." in the url
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Comment |
[ Thank you for the fast action - and for using some of your down time on this!
Since it is a ProtAnnot thing, I think we can proceed with testing tomorrow with the codebase as-is. If you would like to continue working on it, that would be great, but please consider it completely optional. ] |
Merged to master.
Deployed to dev-appstore-2. Error no longer occurs, moving to Closed.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
https://dev-appstore-2.bioviz.org/apps/org.lorainelab.igb.protannot is properly displayed.
Editorial comment: regular expressions are very sharp knives.
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested on dev-appstore-2. After submitting the protannot app when I tried to load the App's page, it was loaded successfully without showing any errors on the appstore and the fixed version seems to work fine. Moving it to DONE.
| Assignee | Prutha Kulkarni [ prutha ] | Sameer Shanbhag [ sameer ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
I will have a look