Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Epic Link:
-
Sprint:Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec
Description
When the user hovers the mouse over the 'Get latest IGB' button, the browser should display the link destination URL in the usual place, e.g., lower-left corner in Chrome.
Attachments
Issue Links
- relates to
-
IGBF-2138 Improve box-release-info on apps page
-
- Closed
-
Activity
More Information:
The Button uses getIGB() [can be found in app_page.js] function and window.open() funcition in JavaScript to redirect user to bioviz website.
This was done as we wanted to make the bioviz.org linking central and use it everywhere.
Solution for this problem:
Hardcode the link in HTML so the Browser can see through the Javascript.
I understand. Hard-coding in this case I think is OK. Please proceed.
Just a quick clarification just in case it is required: link should go to "https://bioviz.org"
(Note https and lack of "www" subdomain")
Pull Request Submitted.
https://bitbucket.org/sshanbh1/sameer-appstorefork/pull-requests/new?source=IGBF-2153&t=1
Merged but not yet deployed on dev-appstore-2.
Shamika Gajanan Kulkarni
Pawan Bole
Philip Badzuh
Prutha Kulkarni
Please review. Note that testing this ticket will require testing the full-end-to-end workflow for installation of Apps into IGB because this change affects that functionality.
Deployed to https://dev-appstore-2.bioviz.org and ready for testing.
Tested and the link destination URL are displayed on the left corner when hovered over 'Get Latest IGB' button. The upgrade functionality is not working as expected. The 'Update app' button is not visible on Appstore, even when the update function is available in IGB. Sameer Shanbhag has fixed this is one of the tickets and it seems the changes are not yet deployed to https://dev-appstore-2.bioviz.org. Will test this once again after latest changes are merged.
My apologies Shamika Gajanan Kulkarni and Pooja Nikhare for not keeping you up to date.
Sameer Shanbhag has deployed the latest master to his EC2 yesterday - http://dev-appstore-1.bioviz.org.
I was not able to update dev-appstore-2 because I was out sick on Tuesday and I forgot to do it this morning.
Deployed to https://dev-appstore-2.bioviz.org and ready for testing.
The link destination URLs are now visible for 'Get Latest IGB' button. Upgrade functionality is also working as expected. Moving to closed.
[~aloraine]
I don't think this can be done is a better way.
I tried multiple ways to get the link to show up in the browser. But the Button's behavior is completely depended on the JAvascript and there is no way we can get a link on the button.