Pull Request Submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/184/igbf-2171/diff

Merged but not yet deployed to dev-appstore-2

Pull Request Submitted:

https://bitbucket.org/lorainelab/appstore/pull-requests/186/igbf-2171/diff

Casting to INTEGER is not supported by MSQL so changing INTEGER to UNSIGNED is required.

Sameer Shanbhag - for posterity, please explain the bug and how this fixes it.

Also, please check PR comment – looks like there is a print statement that needs to be removed.

The Bug was related to Version Comparison,

By Default Orderby clause in Django does not support String Matching as python does as
E.g.
For python "9.1.2" > "10.2.0" will return False and "10.0.0" > "9.0.0" will return True
But when Django tries to do OrderBy Query, this query is created and ran on SQL Server (SQLite for local and MySQL for AWS) the OrderBy Clasue does a basic SQL Query which does not order it properly (The Bug we faced)

Solution Proposed:
While Querying in Django, it allows us to write our own custom Query in Extra function. We just replace the "." to convert the String to a Number, then we convert (cast) this numerical string to Integer which can be sorted using OrderBy
Problem with the earlier solution: Cast to INTEGER is supported only by SQLite which is why that worked on local but not on AWS MySQL
The right way to do it (Supported by different types of Databases): Cast it to UNSIGNED (Integer), UNSIGNED is nothing but all the positive integers.

P.S. I'll remove the print statement, and update the Pull Request.

Pull Request Updated:
https://bitbucket.org/lorainelab/appstore/pull-requests/186/igbf-2171/diff

Thanks Sameer Shanbhag

Please create a new ticket to create test cases for the new function and investigate how to include testing in our workflow, e.g, instructions on how developers can test their code before submitting it for review or PR.

Note: I believe this would be our first actual use of testing in App Store – in our code or in Cytoscape project's code. So this new ticket should be at least 1 story point, or one full day of effort. It might not take that long, but developer who does it can adjust accordingly.

Hi, Professor [~aloraine],

I will create another ticket for Unit Test Cases. As of now to test this Issue Testers can follow the steps below:

1. Upload Version 1 of App 1
2. Upload Version 2 of App 1
3. Check the Release History on Appstore. It should show Version 2 as the current version
4. Upload Version 4 of App 1
5. Check the Release History on Appstore. It should show Version 4 as the current version
6. Upload Version 3 of App 1
7. Check the Release History on Appstore. It should still show Version 4 as the current version

Moving forward to Ready for Testing as changes are merged.
Deployed to https://dev-appstore-2.bioviz.org and ready for testing.

Tested on app-store-2 according to the steps given above, with following versions for merge annotation App
version 1 : 9.0.1 , version 2 : 9.1.1 , version 3 : 9.2.0 , version 4 : 9.3.1
1. Uploaded version 1 , Functionality was working fine
2. Uploaded version 2 , Functionality was working fine
3. Uploaded version 4 , "Get Latest IGB" button did not change to "Upgrade" after refreshing IGB.
4. Uploaded version 3 , Upgrade option was shown in IGB to upgrade to version 4.
Release history was shown correctly .

Observation : Issue arises when there is missing version with the minor changes . i.e when uploading 9.3.0 after 9.1.0
If this scenario will never arise in real scenario, I can move this ticket to complete .
Please review : [~aloraine] , Sameer Shanbhag

Thank you Pooja Nikhare for noticing this.

Actually, this could very well occur in real life if a developer decides to skip a minor version.
Please add a new JIRA ticket to the "Build IGB App Store" epic for us to fix this.

Raised a new JIRA ticket IGBF-2192 .