Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2172

Fix link in confirmation email

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Email sent to App submitters after App has been accepted contains wrong link.

          For example)

          quoting--
          Your app has been approved! Here is your app page:

          https://apps.bioviz.org/apps/Super%20Simple%20IGB%20App

          To edit your app page:
          1. Go to https://apps.bioviz.org/apps/Super%20Simple%20IGB%20App
          2. Sign in as aloraine@uncc.edu
          3. Under the "Editor's Actions" on the top-right, choose "Edit this page".

          endquote---

          Note how the App URL contains Bundle_Name, which is wrong. It should be using Bundle_SymbolicName.

          While working on this bug, use global grep to search out every instance of Bundle_Name to make sure that it's being used properly. Recall that previously, Bundle_Name was being used to form an App's URL. We changed it to Bundle_SymbolicName as this is guaranteed to be unique within the IGB ecosystem.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              ann.loraine Ann Loraine created issue -
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-1388 [ 17463 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Assignee Ann Loraine [ aloraine ]
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ]
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

              Code changes are present in branch:
              https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2172#diff

              Testing steps:
              1) Submit an app.
              2) Once the app is accepted by the admin, email is sent to user.
              Check the email link for app url. It should redirect to the app page

              Show
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Code changes are present in branch: https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2172#diff Testing steps: 1) Submit an app. 2) Once the app is accepted by the admin, email is sent to user. Check the email link for app url. It should redirect to the app page
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Code looks good. Please submit PR.

              Show
              ann.loraine Ann Loraine added a comment - Code looks good. Please submit PR.
              ann.loraine Ann Loraine made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              ann.loraine Ann Loraine made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              ann.loraine Ann Loraine made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ]
              Hide
              Permalink
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

              Pull request submitted:
              https://bitbucket.org/lorainelab/appstore/pull-requests/183/igbf-2172-use-bundle_symbolicname-in-urls/diff

              cc. [~aloraine]

              Show
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/183/igbf-2172-use-bundle_symbolicname-in-urls/diff cc. [~aloraine]
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ]
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged.

              Show
              ann.loraine Ann Loraine added a comment - Merged.
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Prutha Kulkarni [ prutha ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Prutha Kulkarni [ prutha ] Riddhi Jagdish Patil [ rpatil14 ]
              Hide
              Permalink
              prutha Prutha Kulkarni (Inactive) added a comment -

              Riddhi Jagdish Patil, I followed the steps mentioned for testing and tested the fix. Now, I am able to see the Bundle_SymbolicName in the confirmation link instead of a Bundle_Name which redirects user to the respective app page.
              Moving the ticket to DONE.

              Show
              prutha Prutha Kulkarni (Inactive) added a comment - Riddhi Jagdish Patil , I followed the steps mentioned for testing and tested the fix. Now, I am able to see the Bundle_SymbolicName in the confirmation link instead of a Bundle_Name which redirects user to the respective app page. Moving the ticket to DONE.
              prutha Prutha Kulkarni (Inactive) made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                People

                • Assignee:
                  rpatil14 Riddhi Jagdish Patil (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: