Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.25
-
Epic Link:
-
Sprint:Fall 9 : 9 Dec to 20 Dec
Description
We have code that shows error or info messages at the top of App Store pages for a short time and then removes them.
This occurs on the Edit App page – possibly other places as well?
Remove this code. When a message is shown, continue showing it until the user dismisses the message.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Description |
We have code that shows error or info messages at the top of App Store pages for a short time and then removes them.
Remove this code. When a message is shown, continue showing it until the user dismisses the message. |
We have code that shows error or info messages at the top of App Store pages for a short time and then removes them.
This occurs on the Edit App page -- possibly other places as well? Remove this code. When a message is shown, continue showing it until the user dismisses the message. |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Please locate and remove the code that shows a message and then removes it after a short time. This will ensure no-one will use it in future by mistake. Also make sure that code is used anywhere else. You can use a global "grep" to find all instances of same.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Re above comment: Look at add_msg method - probably it is the culprit.
I have made the necessary changes. Kindly review.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Changes look good. Can you update the comment? It looks like it may be wrong:
// type: can be "error", "warning", "success", or "info", or just empty.
// group: name of the message group; ensures that only one message in the group is shown.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
The comments seems fine. I have just updated the values of type.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
OK - Noor Zahara please submit PR.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
The feature works fine i.e a message is shown until the user dismisses the message .
But noticed a different behaviour on clicking on rating . The message 'Rating Updated ! Thank you for the input.' is shown only for the unsigned user and not for the logged in User.
Please review : Noor Zahara , [~aloraine]
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Pooja Nikhare - thank you for noticing this!
Pooja Nikhare - please re-open and move to To-Do. Please add it to the next sprint not the current one.
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Sprint | Fall 8 : 25 Nov to 6 Dec [ 79 ] | Fall 9 : 9 Dec to 20 Dec [ 80 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
After investigating, I learned that Pooja Nikhare's observation is not directly related to the code modified in this issue, so I have created a new issue and continued work there: IGBF-2201
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2184#diff