Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2186

Fix bug: App Manager should not lie about whether an App is actually installed

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Discovered during testing of App Store:

      If an App repository lists a bundle URI that is invalid and user tries to install the App using App Manager, an error is generated internally within IGB but the App Manager shows the App as installed, even though it really is not.

        Attachments

          Activity

          Hide
          ann.loraine Ann Loraine added a comment -

          Riddhi Jagdish Patil - tested using 9.0.2 and observed the same bug.

          Show
          ann.loraine Ann Loraine added a comment - Riddhi Jagdish Patil - tested using 9.0.2 and observed the same bug.
          Hide
          ann.loraine Ann Loraine added a comment -

          How to test:

          • Start IGB 9.1.0
          • Reset preferences to defaults
          • Clone an IGB App to your local - choose one that is NOT currently available in any default App store parts of IGB 9.1
          • Build it.
          • Remove or rename the jar file that is created.
          • Add the "target" folder as a local App repository
          • Observe that the App is shown on the list of Apps available to install
          • Click "Install"

          If the bug is fixed, the button will not switch to showing the App as installed.
          If the bug is still in effect, the button will show the App as installed.

          Show
          ann.loraine Ann Loraine added a comment - How to test: Start IGB 9.1.0 Reset preferences to defaults Clone an IGB App to your local - choose one that is NOT currently available in any default App store parts of IGB 9.1 Build it. Remove or rename the jar file that is created. Add the "target" folder as a local App repository Observe that the App is shown on the list of Apps available to install Click "Install" If the bug is fixed, the button will not switch to showing the App as installed. If the bug is still in effect, the button will show the App as installed.
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

          Issue:
          App Manager should not lie about whether an App is actually installed

          Solution:
          Once the resolver.deploy() is done executing, check if the app is installed by checking the installed apps list in BundleContext. If the app is installed show the status as installed else display error message.

          Files changed:
          plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/AppManagerFxPanel.java
          plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/BundleActionManager.java
          plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/service/impl/PluginManagerServiceImpl.java

          Code changes are present in folowing branch:
          https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-2186#diff

          Test scenario:
          1) Incorrect jar installation:
          Start IGB 9.1.0
          Reset preferences to defaults
          Clone an IGB App to your local - choose one that is NOT currently available in any default App store parts of IGB 9.1
          Build it.
          Remove or rename the jar file that is created.
          Add the "target" folder as a local App repository
          Observe that the App is shown on the list of Apps available to install
          Click "Install"
          Expected output - App should not be installed and error message should be displayed

          2) Correct jar installation:
          Start IGB 9.1.0
          Reset preferences to defaults
          Select any repository from Manage Repositories
          Observe that the App is shown on the list of Apps available to install
          Click "Install"
          Expected output - App should be installed and error message should not be displayed

          cc. [~aloraine]

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Issue: App Manager should not lie about whether an App is actually installed Solution: Once the resolver.deploy() is done executing, check if the app is installed by checking the installed apps list in BundleContext. If the app is installed show the status as installed else display error message. Files changed: plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/AppManagerFxPanel.java plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/BundleActionManager.java plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/service/impl/PluginManagerServiceImpl.java Code changes are present in folowing branch: https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-2186#diff Test scenario: 1) Incorrect jar installation: Start IGB 9.1.0 Reset preferences to defaults Clone an IGB App to your local - choose one that is NOT currently available in any default App store parts of IGB 9.1 Build it. Remove or rename the jar file that is created. Add the "target" folder as a local App repository Observe that the App is shown on the list of Apps available to install Click "Install" Expected output - App should not be installed and error message should be displayed 2) Correct jar installation: Start IGB 9.1.0 Reset preferences to defaults Select any repository from Manage Repositories Observe that the App is shown on the list of Apps available to install Click "Install" Expected output - App should be installed and error message should not be displayed cc. [~aloraine]
          Hide
          ann.loraine Ann Loraine added a comment -

          To test, I did this:

          • Built version 0.0.1 of super-simple-igb-app (from git@bitbucket.org:lorainelab/super-simple-igb-app.git) by running mvn package
          • Added "target" from above to IGB as a new App repository
          • Observed that super-simple-igb-app appeared as a new option in IGB App Manager
          • Removed the jar file for above (to simulate a corrupt or missing jar file)
          • Clicked "Install" button in IGB App Manager

          I expected to see an error dialog (as in Test scenario 1 above) but instead, IGB hung and I needed to force-quit IGB.

          cc: Riddhi Jagdish Patil

          Show
          ann.loraine Ann Loraine added a comment - To test, I did this: Built version 0.0.1 of super-simple-igb-app (from git@bitbucket.org:lorainelab/super-simple-igb-app.git) by running mvn package Added "target" from above to IGB as a new App repository Observed that super-simple-igb-app appeared as a new option in IGB App Manager Removed the jar file for above (to simulate a corrupt or missing jar file) Clicked "Install" button in IGB App Manager I expected to see an error dialog (as in Test scenario 1 above) but instead, IGB hung and I needed to force-quit IGB. cc: Riddhi Jagdish Patil
          Hide
          ann.loraine Ann Loraine added a comment -
          Show
          ann.loraine Ann Loraine added a comment - Above comment is from installing https://bitbucket.org/rpatil14/riddhifork-igb/downloads/IGBF-2186.dmg
          Hide
          ann.loraine Ann Loraine added a comment -

          To test, I attempted to install ProtAnnot (available from the BioViz App repository). When I clicked "Install" I observed that IGB again hung – a spinning wheel appeared and never ended.

          Show
          ann.loraine Ann Loraine added a comment - To test, I attempted to install ProtAnnot (available from the BioViz App repository). When I clicked "Install" I observed that IGB again hung – a spinning wheel appeared and never ended.
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

          I am able to get the error message.
          Attached test1.png

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - I am able to get the error message. Attached test1.png
          Hide
          ann.loraine Ann Loraine added a comment -

          Can you ask one of the other Mac users to try it out - after installing using the installer from your downloads?
          Remind them they should delete their bundles directory before trying to run the IGB from your installer.
          Their bundles directory is ~/.igb/bundles

          Show
          ann.loraine Ann Loraine added a comment - Can you ask one of the other Mac users to try it out - after installing using the installer from your downloads? Remind them they should delete their bundles directory before trying to run the IGB from your installer. Their bundles directory is ~/.igb/bundles
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

          I checked in Prutha's laptop, while installing incorrect jar App Manager hangs. I will check the logs.
          For correct jar the app was installed successfully in Mac

          cc. [~aloraine]

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - I checked in Prutha's laptop, while installing incorrect jar App Manager hangs. I will check the logs. For correct jar the app was installed successfully in Mac cc. [~aloraine]
          Hide
          ann.loraine Ann Loraine added a comment -

          Closing for now - won't fix.

          Show
          ann.loraine Ann Loraine added a comment - Closing for now - won't fix.

            People

            • Assignee:
              rpatil14 Riddhi Jagdish Patil (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: