Issue:
App Manager should not lie about whether an App is actually installed
Solution:
Once the resolver.deploy() is done executing, check if the app is installed by checking the installed apps list in BundleContext. If the app is installed show the status as installed else display error message.
Files changed:
plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/AppManagerFxPanel.java
plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/BundleActionManager.java
plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/service/impl/PluginManagerServiceImpl.java
Code changes are present in folowing branch:
https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-2186#diff
Test scenario:
1) Incorrect jar installation:
Start IGB 9.1.0
Reset preferences to defaults
Clone an IGB App to your local - choose one that is NOT currently available in any default App store parts of IGB 9.1
Build it.
Remove or rename the jar file that is created.
Add the "target" folder as a local App repository
Observe that the App is shown on the list of Apps available to install
Click "Install"
Expected output - App should not be installed and error message should be displayed
2) Correct jar installation:
Start IGB 9.1.0
Reset preferences to defaults
Select any repository from Manage Repositories
Observe that the App is shown on the list of Apps available to install
Click "Install"
Expected output - App should be installed and error message should not be displayed
cc. [~aloraine]
Riddhi Jagdish Patil - tested using 9.0.2 and observed the same bug.