Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec, Spring 1 : 25 Dec to 17 Jan
Description
When on the 'All Apps' page, sorting by Downloads does not work. Sorting by Downloads works fine on specific category/tag pages.
Debug and fix sort_app_buttons.js to allow for proper sorting.
Attachments
Issue Links
- relates to
-
REL-33 Verify Appstore links and buttons
-
- Review Requested
-
Activity
| Assignee | Philip Badzuh [ pbadzuh ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Rank | Ranked higher |
| Sprint | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec [ 79, 80 ] | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec, Spring 1 : 6 Jan to 17 Jan [ 79, 80, 84 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Ready for PR.
| Story Points | 1 | 2 |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
I have added secondary alphabetical sorting here:
https://bitbucket.org/pbadzuh/appstore_pbdev/commits/090d21ac025ed8cb858362e2e3dee3fe8a68428b?at=IGBF-2187
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I am cool with a random sort. I would say: it is the developer's choice on this one.
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Philip Badzuh [ pbadzuh ] |
Tested the ticket. For multiple apps that have the highest and equal number of downloads, they are shuffled randomly after each sort. The sorting as per count is working perfectly fine.
Question: Do we need to sort the apps with same download count alphabetically or should we let it be as it is?
Kindly refer the screenshot for the same.
The apps 23nMe SNP Converter, App for testing App Workflow and Find Annotations each have download count as 2, higher than the other apps.
Prof. [~aloraine], Philip Badzuh
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Rank | Ranked higher |
| Sprint | Fall 8 : 25 Nov to 6 Dec [ 79 ] | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec [ 79, 80 ] |
Merged but not yet deployed on dev-appstore-2.
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
I fixed the issue with a simple change that can be seen below. I think the whitespace additions/deletions are an atom issue, as I didn't make them directly. Please review: https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2187#diff
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
Merged but not yet deployed to https://dev-appstore-2.bioviz.org.