Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec, Spring 1 : 25 Dec to 17 Jan
Description
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective:
- Ensure that a given app appears no more than once in each category/row.
- Ensure that categories aren't duplicated and have a single dedicated row
- Correct total app count to represent the sum of all unique apps with categories
Attachments
Issue Links
Activity
| Epic Link | IGBF-1388 [ 17463 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Fall 8 : 25 Nov to 6 Dec [ 79 ] | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec [ 79, 80 ] |
| Rank | Ranked higher |
| Description |
On the 'Wall of Apps" page, categories display all the versions of an app matching that category, including repeats of the same app if it has multiple versions/releases.
- Ensure that apps appear no more than once in each category. - Ensure that categories aren't duplicated |
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective: - Ensure that a given app appears no more than once in each category/row. - Ensure that categories aren't duplicated and have a single dedicated row |
| Story Points | 1 | 2 |
Note that uncategorized apps are not currently displayed on the 'wall of apps' page. To add this feature, it may be convenient to create default 'Category' objects for new/uncategorized apps, as this data structure is defined in apps/models.py and used for the current construction of 'wall of apps'.
The current 'other' category refers to apps that are not in the top x categories, where x can be set and is currently 20. Uncategorized apps could be added to this category in the future, as described in the first paragraph.
| Attachment | old_categorization.png [ 14557 ] | |
| Attachment | new_categorization.png [ 14558 ] |
| Description |
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective: - Ensure that a given app appears no more than once in each category/row. - Ensure that categories aren't duplicated and have a single dedicated row |
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective: - Ensure that a given app appears no more than once in each category/row. - Ensure that categories aren't duplicated and have a single dedicated row - Correct |
| Description |
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective: - Ensure that a given app appears no more than once in each category/row. - Ensure that categories aren't duplicated and have a single dedicated row - Correct |
On the 'Wall of Apps" page, categories display all the versions/releases of an app matching that category, resulting in repeats. Different apps belonging to the same category are not placed in the same category row; rather, a multiple rows of a that category are created, with each app in its own row.
Objective: - Ensure that a given app appears no more than once in each category/row. - Ensure that categories aren't duplicated and have a single dedicated row - Correct total app count to represent the sum of all unique apps with categories |
Note 2: Category rows are ordered by the number of apps in each category, however, if a category comes to exceed another in its app number, row ordering will not be changed, despite hard refresh of the webpage, until the django server is restarted.
| Attachment | new_categorization.png [ 14558 ] |
| Attachment | new_categorization.png [ 14559 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
Please check that an App will still be visible on the Wall of Apps even if it does not yet have a logo.
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] | Philip Badzuh [ pbadzuh ] |
| Attachment | new_categorization.png [ 14559 ] |
| Attachment | new_categorization.png [ 14560 ] |
Yes, that is the case. I have updated the screenshot, so you can see it there.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
OK - looks good! Please proceed with PR.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
Merged and deployed on https://dev-appstore-2.bioviz.org.
| Attachment | Categories1.JPG [ 14561 ] | |
| Attachment | WallofApps1.JPG [ 14562 ] |
| Attachment | WallofApps1.JPG [ 14562 ] |
| Attachment | Categories1.JPG [ 14561 ] |
| Attachment | S - Categories1.JPG [ 14563 ] | |
| Attachment | S - WallofApps1.JPG [ 14564 ] |
Tested the ticket. I tried to add categories and checked the Wall of Apps. At that time, it worked perfectly fine. But when I tried to update the app and remove some categories, they were still visible on Wall of Apps page, with count as (0), and no apps displayed for those categories. Also, on the left menu on home page, one category called 'Test App' was not displayed even after refreshing the page, when an app existed for the category.
Philip Badzuh could you please have a look into this?
Another observation is that when u remove a category previously added for an app, it still exists on the left menu of homepage. I am not sure whether it is supposed to be like this so thought of noting it down here.
Kindly refer the screenshots attached.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Philip Badzuh [ pbadzuh ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I have fixed the issue I found here as well as those reported by Shamika Gajanan Kulkarni in the commit below:
https://bitbucket.org/pbadzuh/appstore_pbdev/commits/46dd28f4362ea539fced1fb19bb66998914d5a10?at=IGBF-2190
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Story Points | 2 | 3 |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Please see question regarding commit: "IGBF 2190 Delete empty categories"
(Question is a note/comment attached to the commit and referencing the bit in mk_app_page where it seems like tags are getting removed from the database.)
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I have reverted deleting empty app categories and have made it so they aren't displayed on the 'wall of apps' and home pages. They are still however in the list of suggested apps that is given when a user tries to add a category tag to an app.
The changes can be seen in the branch below. Kindly review.
https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2190#diff
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec [ 79, 80 ] | Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec, Spring 1 : 6 Jan to 17 Jan [ 79, 80, 84 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
I have added the objective changes here. Please review and suggest any changes:
https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2190#diff