Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2192

Fix button Install/Upgrade in App Store when developer skips a version increment during upgrade

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10

      Description

      See linked issue for description of the problem.

      Quoting from above:

      "Observation : Issue arises when there is missing version with the minor changes . i.e when uploading 9.3.0 after 9.1.0"

        Attachments

          Issue Links

            Activity

            pooja.nikhare Pooja Nikhare (Inactive) created issue -
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-1388 [ 17463 ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Link This issue relates to IGBF-2171 [ IGBF-2171 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec [ 80 ] Fall 9 : 9 Dec to 20 Dec, Spring 1 : 6 Jan to 17 Jan [ 80, 84 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Comment [ From [~karthik]:

            "The following CSS changes seems to fix the issue.

            html {
                position: relative;
                height:auto;
                min-height:100%
            }
            body{
                height: 100%
            }
            sticky-footer{
              position : absolute

            }

            I just made these changes in the browser itself. So I am not sure if it breaks anything or not."

            cc: [~pbadzuh] and [~nfreese] (for your reference) ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Pooja Nikhare [ pooja.nikhare ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 1 : 25 Dec to 17 Jan [ 80, 84 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan [ 80, 85 ]
            ann.loraine Ann Loraine made changes -
            Assignee Pooja Nikhare [ pooja.nikhare ] Sameer Shanbhag [ sameer ]
            ann.loraine Ann Loraine made changes -
            Comment [ [~pooja.nikhare] - please provide more details (when you get back). ]
            ann.loraine Ann Loraine made changes -
            Description See linked issue for description of the problem.

            Quoting from above:

            "Observation : Issue arises when there is missing version with the minor changes . i.e when uploading 9.3.0 after 9.1.0"
            ann.loraine Ann Loraine made changes -
            Story Points 0.5
            ann.loraine Ann Loraine made changes -
            Summary Fix button Install/Upgrade in App Store when an apps minor version change is missing Fix button Install/Upgrade in App Store when developer skips a version during upgrade
            ann.loraine Ann Loraine made changes -
            Summary Fix button Install/Upgrade in App Store when developer skips a version during upgrade Fix button Install/Upgrade in App Store when developer skips a version increment during upgrade
            ann.loraine Ann Loraine made changes -
            Story Points 0.5 1
            ann.loraine Ann Loraine made changes -
            Assignee Sameer Shanbhag [ sameer ]
            Hide
            ann.loraine Ann Loraine added a comment -

            To investigate, examine how IGB's internal "manageApp" endpoint is working. It may not be sending the correct information for App Store to consume and modify the button's appearance.

            Show
            ann.loraine Ann Loraine added a comment - To investigate, examine how IGB's internal "manageApp" endpoint is working. It may not be sending the correct information for App Store to consume and modify the button's appearance.
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Code change - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2192#diff Testing Steps - Follow IGBF-2171
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan [ 80, 85 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb [ 80, 85, 86 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb [ 80, 85, 86 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 80, 85, 86, 87 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -
            Show
            ann.loraine Ann Loraine added a comment - Pooja Nikhare - Please test using IGBF-2192 installer from Noor's branch. See https://bitbucket.org/noorzahara/integrated-genome-browser-local1/downloads/ .
            ann.loraine Ann Loraine made changes -
            Assignee Pooja Nikhare [ pooja.nikhare ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            Prof. [~aloraine] , Can I test on dev-app-store-1 https://dev-appstore-1.bioviz.org/ ?
            This issue was raised while testing in app-store-2 . Currently app-store-2 is not up.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Prof. [~aloraine] , Can I test on dev-app-store-1 https://dev-appstore-1.bioviz.org/ ? This issue was raised while testing in app-store-2 . Currently app-store-2 is not up.
            Hide
            ann.loraine Ann Loraine added a comment -

            Sure. Also, I will set up dev-appstore-2 shortly.

            Show
            ann.loraine Ann Loraine added a comment - Sure. Also, I will set up dev-appstore-2 shortly.
            Hide
            ann.loraine Ann Loraine added a comment -

            FYI: master branch deployed on dev-appstore-2 up to and including these commits:

            9db2675 (HEAD -> master, origin/master, origin/HEAD) Merged in IGBF-2231 (pull request #210)
            f5753c0 IGBF-2231 : Remove old search logic | Xapian Search
            daadc80 IGBF-2231 : Remove unnecessary line of codes and organizing file imports
            bf6733a IGBF-2231 : Remove support for Geological Tracking

            Show
            ann.loraine Ann Loraine added a comment - FYI: master branch deployed on dev-appstore-2 up to and including these commits: 9db2675 (HEAD -> master, origin/master, origin/HEAD) Merged in IGBF-2231 (pull request #210) f5753c0 IGBF-2231 : Remove old search logic | Xapian Search daadc80 IGBF-2231 : Remove unnecessary line of codes and organizing file imports bf6733a IGBF-2231 : Remove support for Geological Tracking
            Hide
            ann.loraine Ann Loraine added a comment -

            dev-appstore-2 is now live.

            Show
            ann.loraine Ann Loraine added a comment - dev-appstore-2 is now live.
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            I tested on dev-appstore-2 . Followed Testing Steps given in IGBF-2171 .

            Observed that after submitting an upgraded version of app, on app store 'Get latest IGB' changes to 'Upgrade this App' and in IGB also 'Update' is shown.
            But after clicking on upgrade the new version does not get installed on IGB , the older version gets installed . After refreshing the repository on IGB it again shows 'Update' button.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - I tested on dev-appstore-2 . Followed Testing Steps given in IGBF-2171 . Observed that after submitting an upgraded version of app, on app store 'Get latest IGB' changes to 'Upgrade this App' and in IGB also 'Update' is shown. But after clicking on upgrade the new version does not get installed on IGB , the older version gets installed . After refreshing the repository on IGB it again shows 'Update' button.
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Assignee Pooja Nikhare [ pooja.nikhare ] Noor Zahara [ noor91zahara ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Code Fix .- https://bitbucket.org/noorzahara/integrated-genome-browser-local1/commits/085fd6a9a64f54300635133907b517fa3ac509f2
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            Tested on Dev-app-store-2 using using IGBF-2192 installer . Functionality works Properly as per the testing steps .

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Tested on Dev-app-store-2 using using IGBF-2192 installer . Functionality works Properly as per the testing steps .
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Assignee Pooja Nikhare [ pooja.nikhare ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Assignee Pooja Nikhare [ pooja.nikhare ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - PR raised https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/774/igbf-2192/diff
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            nfreese Nowlan Freese made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb [ 80, 85, 86, 87 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 80, 85, 86, 87, 89 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 80, 85, 86, 87, 89 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 80, 85, 86, 87, 89, 90 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged and deployed to https://dev-appstore-2.bioviz.org.
            Read for testing.

            cc: Shamika Gajanan Kulkarni and Noor Zahara

            Show
            ann.loraine Ann Loraine added a comment - Merged and deployed to https://dev-appstore-2.bioviz.org . Read for testing. cc: Shamika Gajanan Kulkarni and Noor Zahara
            nfreese Nowlan Freese made changes -
            Sprint Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 80, 85, 86, 87, 89, 90 ] Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10 [ 80, 85, 86, 87, 89, 90, 91 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            Prof. Ann Loraine , Can I test on dev-app-store-1 https://dev-appstore-1.bioviz.org/ ?
            Currently app-store-2 is not up.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Prof. Ann Loraine , Can I test on dev-app-store-1 https://dev-appstore-1.bioviz.org/ ? Currently app-store-2 is not up.
            Hide
            ann.loraine Ann Loraine added a comment -

            I will start dev-appstore2 shortly.

            Show
            ann.loraine Ann Loraine added a comment - I will start dev-appstore2 shortly.
            Hide
            ann.loraine Ann Loraine added a comment - - edited
            Show
            ann.loraine Ann Loraine added a comment - - edited https://dev-appstore-2.bioviz.org is now on-line. cc: Pooja Nikhare
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            Tested on app-store-2 .
            Followed steps for Geometric-mean-operator app :
            1. Uploaded version 9.1.0, Functionality was working fine
            2. Uploaded version 9.1.1, Functionality was working fine
            3. Uploaded version 9.3.0, Functionality was working fine
            4. Uploaded version 9.2.0, Functionality was working fine
            5. Uploaded version 10.1.0, Functionality was working fine
            "Get Latest IGB", button changes to "Upgrade" in app-store accordingly when upgrade is available.
            "Install" button changes to "upgrade" in IGB accordingly when the upgrade is available.
            Moving the ticket to done.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Tested on app-store-2 . Followed steps for Geometric-mean-operator app : 1. Uploaded version 9.1.0, Functionality was working fine 2. Uploaded version 9.1.1, Functionality was working fine 3. Uploaded version 9.3.0, Functionality was working fine 4. Uploaded version 9.2.0, Functionality was working fine 5. Uploaded version 10.1.0, Functionality was working fine "Get Latest IGB", button changes to "Upgrade" in app-store accordingly when upgrade is available. "Install" button changes to "upgrade" in IGB accordingly when the upgrade is available. Moving the ticket to done.
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            pooja.nikhare Pooja Nikhare (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                pooja.nikhare Pooja Nikhare (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: