Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2214

Investigate parent POM property log4jVersion - is it being used?

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb

      Description

      Note: This would be a good job for someone who understands maven quite well - or who wants to learn.

      The goal of the task is to make the IGB POM simpler and more understandable. It looks like the POM property log4JVersion is not be used anywhere and can be deleted, which will simplify the POM. This task is to investigate that and delete if if possible.

      Background:

      The IGB project uses SLF4J as its logging system. SLF4J - Simple Logging Facade for Java - is basically just an API "facade" for various logging systems you can include in a Java project. In all of IGB's bundles, we include the facade API as a dependency. When we build IGB itself, we also include an implementation of the logging framework. None of the bundles needs to know anything about which framework implementation is being used. Only the master build logic that creates the final platform jar should specify the particular logging implementation.

      Note that this is complicated by the fact that some of the 3rd-party jars we include might declare dependencies on specific logging framework implementations, which would be bad. I have not checked if this is happening.

      For some reason, the parent IGB POM creates a property called log4JVersion, but it is not used anywhere in the parent POM. For this task, use grep or whatever tools you like to find out if any of the child modules in "core" or "plugins" or wherever are using this property. If they are, investigate why. If they are using any older, non-SLF4J logging system, change this so that they are using SLF4J.

      Note that the story point estimate assumes you will not have to change any code – just delete and un-used property. If this is not the case, please update the story points to show the greater effort.

        Attachments

          Activity

          ann.loraine Ann Loraine made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          ann.loraine Ann Loraine made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb [ 84, 85, 86 ] Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 84, 85, 86, 87 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan [ 84, 85 ] Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan, Spring 3 : 3 Feb to 14 Feb [ 84, 85, 86 ]
          ann.loraine Ann Loraine made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Story Points 0.5 1
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Spring 1 : 25 Dec to 17 Jan [ 84 ] Spring 1 : 25 Dec to 17 Jan, Spring 2 : 20 Jan to 31 Jan [ 84, 85 ]
          ann.loraine Ann Loraine made changes -
          Story Points 0.25 0.5
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Sprint Spring 2 : 20 Jan to 31 Jan [ 85 ] Spring 1 : 25 Dec to 17 Jan [ 84 ]
          ann.loraine Ann Loraine made changes -
          Assignee Noor Zahara [ noor91zahara ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-1531 [ 17617 ]
          ann.loraine Ann Loraine created issue -

            People

            • Assignee:
              shamika Shamika Gajanan Kulkarni (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: